New issue
Advanced search Search tips

Issue 622898 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

fast/repaint/window-resize-background-image-* tests are flaky and/or failing

Project Member Reported by dgozman@chromium.org, Jun 23 2016

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Jun 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9b64b1954ebfe60583eb60b0fda3cf7f833e550

commit b9b64b1954ebfe60583eb60b0fda3cf7f833e550
Author: dgozman <dgozman@chromium.org>
Date: Thu Jun 23 22:47:39 2016

Mark fast/repaint/window-resize-background-image-fixed-centered* as flaky.

BUG= 622898 
TBR=wangxianzhu@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2092923002
Cr-Commit-Position: refs/heads/master@{#401746}

[modify] https://crrev.com/b9b64b1954ebfe60583eb60b0fda3cf7f833e550/third_party/WebKit/LayoutTests/TestExpectations

Summary: fast/repaint/window-resize-background-image-* tests are flaky and/or failing (was: fast/repaint/window-resize-background-image-fixed-centered* tests are flaky)
window-resize-background-image-non-fixed.html is also having problems after being turned back on via the rebaseline performed by the rebaseline bot (previously it was marked as needing manual rebaseline).
https://codereview.chromium.org/2093713003/ is in the CQ to mark the test in c#2 as marking manual rebaseline again.
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b94286c06a31be7b85538f56e0dafd57731419b

commit 3b94286c06a31be7b85538f56e0dafd57731419b
Author: blundell <blundell@chromium.org>
Date: Fri Jun 24 16:28:04 2016

Mark window-resize-background-image-non-fixed.html as needing manual rebaseline

r401697 changed this test from NeedsManualRebaseline to NeedsRebaseline.
However, after the rebaseline bot rebaselined it it's failing on Win7 and Win10
due to text diff (e.g.,
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7/builds/43541/steps/webkit_tests/logs/stdio).
Hence, moving it back to NeedsManualRebaseline.

BUG= 622898 
TBR=wangxianzhu

Review-Url: https://codereview.chromium.org/2093713003
Cr-Commit-Position: refs/heads/master@{#401876}

[modify] https://crrev.com/3b94286c06a31be7b85538f56e0dafd57731419b/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ccb588c4642dd36eca1bafc9cda9a62081bee60

commit 7ccb588c4642dd36eca1bafc9cda9a62081bee60
Author: blundell <blundell@chromium.org>
Date: Mon Jul 04 10:40:12 2016

Mark window-resize-background-image-non-fixed.html as failing

Per discussion on https://codereview.chromium.org/2093713003/,
platform-specific failure is a more accurate annotation for this test
than needing manual rebaseline.

BUG= 622898 
TBR=wangxianzhu

Review-Url: https://codereview.chromium.org/2122623002
Cr-Commit-Position: refs/heads/master@{#403661}

[modify] https://crrev.com/7ccb588c4642dd36eca1bafc9cda9a62081bee60/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 6 by bugdroid1@chromium.org, Jul 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4642f6d990020c2d15902b0de97b0acc70defc51

commit 4642f6d990020c2d15902b0de97b0acc70defc51
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Fri Jul 29 23:02:44 2016

Try to fix flakiness of fast/repaint/window-resize-background-image*.html

The flakiness may be because sometimes the test was started before the image is
loaded. Now start the test in onload.

Remove wrong baselines that were created based on wrong results when the
test failed on the bots.

BUG= 622898 

Review-Url: https://codereview.chromium.org/2188383002
Cr-Commit-Position: refs/heads/master@{#408795}

[modify] https://crrev.com/4642f6d990020c2d15902b0de97b0acc70defc51/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/4642f6d990020c2d15902b0de97b0acc70defc51/third_party/WebKit/LayoutTests/fast/repaint/resources/window-resize-repaint.js
[rename] https://crrev.com/4642f6d990020c2d15902b0de97b0acc70defc51/third_party/WebKit/LayoutTests/fast/repaint/window-resize-background-image-fixed-centered-composited-expected.txt
[rename] https://crrev.com/4642f6d990020c2d15902b0de97b0acc70defc51/third_party/WebKit/LayoutTests/fast/repaint/window-resize-background-image-non-fixed-expected.txt
[delete] https://crrev.com/2b295de8104e97a4fd186e03a465ffa46747cf4a/third_party/WebKit/LayoutTests/platform/android/fast/repaint/window-resize-background-image-fixed-centered-composited-expected.txt
[delete] https://crrev.com/2b295de8104e97a4fd186e03a465ffa46747cf4a/third_party/WebKit/LayoutTests/platform/android/fast/repaint/window-resize-background-image-fixed-centered-expected.txt
[delete] https://crrev.com/2b295de8104e97a4fd186e03a465ffa46747cf4a/third_party/WebKit/LayoutTests/platform/android/fast/repaint/window-resize-background-image-generated-expected.txt
[delete] https://crrev.com/2b295de8104e97a4fd186e03a465ffa46747cf4a/third_party/WebKit/LayoutTests/platform/android/fast/repaint/window-resize-background-image-non-fixed-expected.txt
[delete] https://crrev.com/2b295de8104e97a4fd186e03a465ffa46747cf4a/third_party/WebKit/LayoutTests/platform/linux-precise/fast/repaint/window-resize-background-image-fixed-centered-composited-expected.txt
[delete] https://crrev.com/2b295de8104e97a4fd186e03a465ffa46747cf4a/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/window-resize-background-image-fixed-centered-composited-expected.txt
[delete] https://crrev.com/2b295de8104e97a4fd186e03a465ffa46747cf4a/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/window-resize-background-image-non-fixed-expected.txt
[delete] https://crrev.com/2b295de8104e97a4fd186e03a465ffa46747cf4a/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/repaint/window-resize-background-image-fixed-centered-expected.txt
[delete] https://crrev.com/2b295de8104e97a4fd186e03a465ffa46747cf4a/third_party/WebKit/LayoutTests/platform/win/fast/repaint/window-resize-background-image-fixed-centered-composited-expected.txt
[delete] https://crrev.com/2b295de8104e97a4fd186e03a465ffa46747cf4a/third_party/WebKit/LayoutTests/platform/win/fast/repaint/window-resize-background-image-non-fixed-expected.txt
[delete] https://crrev.com/2b295de8104e97a4fd186e03a465ffa46747cf4a/third_party/WebKit/LayoutTests/platform/win7/fast/repaint/window-resize-background-image-fixed-centered-composited-expected.txt
[delete] https://crrev.com/2b295de8104e97a4fd186e03a465ffa46747cf4a/third_party/WebKit/LayoutTests/platform/win7/fast/repaint/window-resize-background-image-fixed-centered-expected.txt
[delete] https://crrev.com/2b295de8104e97a4fd186e03a465ffa46747cf4a/third_party/WebKit/LayoutTests/platform/win7/fast/repaint/window-resize-background-image-non-fixed-expected.txt

Status: Fixed (was: Assigned)

Sign in to add a comment