New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 622885 link

Starred by 10 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Tile sizes are wrong when DSF changes.

Project Member Reported by danakj@chromium.org, Jun 23 2016

Issue description

The default tile size is a LayerTreeSetting, which are constant from construction of LayerTreeHost, but it is based on the DSF which can change for a given LayerTreeHost, at which point we'll be using the wrong tile sizes.
 

Comment 1 by danakj@chromium.org, Jun 25 2016

Cc: danakj@chromium.org hendr...@chromium.org aelias@chromium.org boliu@chromium.org
 Issue 472813  has been merged into this issue.

Comment 2 by danakj@chromium.org, Jun 25 2016

 http://crbug.com/159524  was filed to unify the tile size decisions for all platforms. It got duped/fixed when we added a DSF tile size for chromeos.

Also, ganesh uses viewport-sized tiles which is terrible when windows get resized, as we recreate everything all the time.

Comment 3 by danakj@chromium.org, Jun 25 2016

I think we can solve all of these by making tile size a divisor of the physical screen size (different from the viewport, and more stable on desktop).

Comment 4 by danakj@chromium.org, Jun 25 2016

From aelias:

> Hmm, I had to look it up a bit.  Unfortunately, physical_backing_size_/device_viewport_size is not stable.
> 
> There are two reasonable ways to get a stable viewport size in physical pixels:
> 1) OutputSurface::SurfaceSize()
> 2) (viewport_size + top_controls_shrink_blink_size ? top_controls_height : 0) * device_scale_factor
> 
> I actually propose that you take the intersection (min) of those two sizes.  The reason is WebView.
> WebView can have the viewport (Android View size) either much larger or much smaller than the
> OutputSurface size (GL framebuffer size).  Taking the smaller of the two will solve  http://crbug.com/472813 
> while avoiding introducing the inverse problem for tiny WebViews.

Comment 5 by danakj@chromium.org, May 10 2017

Status: Available (was: Assigned)
https://codereview.chromium.org/2099903002/ is a WIP CL for this "Make tile size a function of the device scale factor."

Comment 6 by danakj@chromium.org, May 10 2017

Owner: ----
Components: Internals>Compositing
Project Member

Comment 8 by sheriffbot@chromium.org, Oct 29

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Fixed (was: Untriaged)
This appears fixed in PictureLayerImpl.
Only for gpu raster path I think, FWIW.
Status: Available (was: Fixed)
Oh, quite right.

Sign in to add a comment