New issue
Advanced search Search tips

Issue 622875 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

crosperf: bad handling of error when an image cannot be found.

Project Member Reported by llozano@chromium.org, Jun 23 2016

Issue description

This is pretty cryptic!


OUTPUT: trybot_image is 'trybot-x86-alex-release/R53-8491.0.0-b4407'
OUTPUT: build_status is 0
trybot_image: trybot-x86-alex-release/R53-8491.0.0-b4407
vanilla_image: x86-alex-release/R53-8491.0.0
nonafdo_image: x86-alex-chrome-pfq/R53-8490.0.0-rc1
CMD (): chmod 600 /var/cache/chromeos-cache/distfiles/target/chrome-src-internal/src/third_party/chromite/ssh_keys/testing_rsa
CMD (None): cd /usr/local/google2/crostc/chromeos; cros_sdk  -- bash -c '~/trunk/src/scripts/in_chroot_cmdjVn7Ay.sh'
CMD (None): /usr/local/google/home/mobiletc-prebuild/toolchain_utils/crosperf/crosperf --no_email=True --results_dir=/usr/local/google/crostc/nightly_test_reports/2016-06-23_04:00:02.x86-alex --json_report=True  /usr/local/google2/crostc/chromeos/../Thu/x86-alex_toolchain_experiment.txt
Traceback (most recent call last):
  File "/usr/local/google/home/mobiletc-prebuild/toolchain_utils/crosperf/crosperf.py", line 128, in <module>
    Main(sys.argv)
  File "/usr/local/google/home/mobiletc-prebuild/toolchain_utils/crosperf/crosperf.py", line 110, in Main
    working_directory, log_dir)
  File "/usr/local/google/home/mobiletc-prebuild/toolchain_utils/crosperf/experiment_factory.py", line 223, in GetExperiment
    log_level)
  File "/usr/local/google/home/mobiletc-prebuild/toolchain_utils/crosperf/settings.py", line 78, in GetXbuddyPath
    misc.CanonicalizePath(chromeos_root), xbuddy_path)
  File "/usr/local/google/home/mobiletc-prebuild/toolchain_utils/crosperf/download_images.py", line 100, in Run
    self.UncompressImage(chromeos_root, build_id)
  File "/usr/local/google/home/mobiletc-prebuild/toolchain_utils/crosperf/download_images.py", line 83, in UncompressImage
    raise MissingImage('Cannot uncompress image: %s.' % build_id)
download_images.MissingImage: Cannot uncompress image: x86-alex-release/R53-8491.0.0.
OUTPUT: Preparing to download x86-alex-release/R53-8491.0.0 image to local directory.
OUTPUT: CMD: gsutil cp gs://chromeos-image-archive/x86-alex-release/R53-8491.0.0/chromiumos_test_image.tar.xz /tmp/x86-alex-release/R53-8491.0.0
OUTPUT: CMD: cd /tmp/x86-alex-release/R53-8491.0.0 ;unxz chromiumos_test_image.tar.xz; tar -xvf chromiumos_test_image.tar
(Uncompressing and un-tarring may take a couple of minutes...please be patient.)
Traceback (most recent call last):
  File "./buildbot_test_toolchains.py", line 379, in <module>
    retval = Main(sys.argv)
  File "./buildbot_test_toolchains.py", line 375, in Main
    return fc.DoAll()
  File "./buildbot_test_toolchains.py", line 318, in DoAll
    self._TestImages(trybot_image, vanilla_image, nonafdo_image)
  File "./buildbot_test_toolchains.py", line 219, in _TestImages
    raise RuntimeError("Couldn't run crosperf!")
RuntimeError: Couldn't run crosperf!



 

Comment 1 by cmt...@chromium.org, Jun 23 2016

download_images.MissingImage: Cannot uncompress image: x86-alex-release/R53-8491.0.0.

What's cryptic?  How would you like to see this improved?  Suppressing the stack traces?
Labels: Build-Toolchain OS-Chrome
should it fail there? it seems to continue, tries to download and then fails with "cannot run crosperf"! it seems our error handling is weird.
Cc: cmt...@chromium.org
Owner: manojgupta@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 25 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/toolchain-utils/+/aee96b71ad4ffde231ca5bf9c0509d15b0e9b753

commit aee96b71ad4ffde231ca5bf9c0509d15b0e9b753
Author: Manoj Gupta <manojgupta@google.com>
Date: Mon Oct 24 20:43:28 2016

Status: Fixed (was: Assigned)

Comment 7 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 8 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58
Status: Verified (was: Fixed)

Sign in to add a comment