New issue
Advanced search Search tips

Issue 622862 link

Starred by 2 users
Status: Fixed
Owner:
bsep@chromium.org
Closed: Jul 2016
EstimatedDays: ----
NextAction: ----
OS: Windows , Chrome
Pri: 1
Type: Bug

Blocking:
issue 613414



Sign in to add a comment

dev tools element highlight not aligned with the element with use-zoom-for-dsf on

Project Member Reported by bsep@chromium.org, Jun 23 2016 
Bringing up the dev tools menu and trying to hover HTML elements to highlight the on-page elements results in the highlight being misaligned. See the attached screenshots, which are at 2x dsf.

I reproed this on Windows 10, not sure if it affects other platforms.
input-debug.PNG
6.3 KB View Download
wikipedia-debug.PNG
262 KB View Download

Comment 1 by osh...@chromium.org, Jun 23 2016

Labels: -Pri-3 M-53 OS-Chrome Pri-1

Comment 2 by bsep@chromium.org, Jun 28 2016

Blocking: 613414

Comment 3 by osh...@chromium.org, Jun 28 2016

Owner: bsep@chromium.org
WIP CL: https://codereview.chromium.org/2102033002/

you need to pass the scale to scale back the path.
Project Member

Comment 4 by sheriffbot@chromium.org, Jul 3 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a427768ddb6797924f968113b78491feecf95cd

commit 9a427768ddb6797924f968113b78491feecf95cd
Author: tkent <tkent@chromium.org>
Date: Thu Jul 07 06:49:31 2016

Revert of Fix inspector overlay when use-zoom-for-dsf is enabled. (patchset #8 id:140001 of https://codereview.chromium.org/2108803006/ )

Reason for revert:
inspector/elements/shadow/elements-panel-shadow-selection-on-refresh-1.html is crashy after this change.

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=inspector%2Felements%2Fshadow%2Felements-panel-shadow-selection-on-refresh-1.html

Original issue's description:
> Fix inspector overlay when use-zoom-for-dsf is enabled.
>
> Inspector overlays were misaligned because the path points were drawing
> in window coordinates and needed to be scaled to viewport coordinates.
> Should be no change when use-zoom-for-dsf is off.
>
> BUG= 622862 
>
> Committed: https://crrev.com/6651b97ebd509e97bea8929303738dc20a3ed880
> Cr-Commit-Position: refs/heads/master@{#404063}

TBR=dgozman@chromium.org,oshima@chromium.org,bokan@chromium.org,bsep@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 622862 

Review-Url: https://codereview.chromium.org/2127053002
Cr-Commit-Position: refs/heads/master@{#404093}

[modify] https://crrev.com/9a427768ddb6797924f968113b78491feecf95cd/content/renderer/devtools/devtools_agent.cc
[modify] https://crrev.com/9a427768ddb6797924f968113b78491feecf95cd/third_party/WebKit/Source/core/inspector/InspectorHighlight.cpp
[modify] https://crrev.com/9a427768ddb6797924f968113b78491feecf95cd/third_party/WebKit/Source/core/inspector/InspectorHighlight.h
[modify] https://crrev.com/9a427768ddb6797924f968113b78491feecf95cd/third_party/WebKit/Source/web/InspectorOverlay.cpp
[modify] https://crrev.com/9a427768ddb6797924f968113b78491feecf95cd/third_party/WebKit/Source/web/InspectorOverlay.h
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 8 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fca01d88e345fce580cd8acc7245f6cdc89a0c84

commit fca01d88e345fce580cd8acc7245f6cdc89a0c84
Author: bsep <bsep@chromium.org>
Date: Fri Jul 08 01:03:40 2016

Fix inspector overlay when use-zoom-for-dsf is enabled.

Inspector overlays were misaligned because the path points were drawing
in window coordinates and needed to be scaled to viewport coordinates.
Should be no change when use-zoom-for-dsf is off.

BUG= 622862 

Committed: https://crrev.com/6651b97ebd509e97bea8929303738dc20a3ed880
Review-Url: https://codereview.chromium.org/2108803006
Cr-Original-Commit-Position: refs/heads/master@{#404063}
Cr-Commit-Position: refs/heads/master@{#404285}

[modify] https://crrev.com/fca01d88e345fce580cd8acc7245f6cdc89a0c84/content/renderer/devtools/devtools_agent.cc
[modify] https://crrev.com/fca01d88e345fce580cd8acc7245f6cdc89a0c84/third_party/WebKit/Source/core/inspector/InspectorHighlight.cpp
[modify] https://crrev.com/fca01d88e345fce580cd8acc7245f6cdc89a0c84/third_party/WebKit/Source/core/inspector/InspectorHighlight.h
[modify] https://crrev.com/fca01d88e345fce580cd8acc7245f6cdc89a0c84/third_party/WebKit/Source/web/InspectorOverlay.cpp
[modify] https://crrev.com/fca01d88e345fce580cd8acc7245f6cdc89a0c84/third_party/WebKit/Source/web/InspectorOverlay.h

Comment 8 by bsep@chromium.org, Jul 8 2016

Labels: -M-54 -MovedFrom-53 Merge-Request-53 M-53

Comment 9 by dimu@google.com, Jul 9 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Project Member

Comment 10 by bugdroid1@chromium.org, Jul 11 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/832b7af69ca7e4d63a86d04f6f6ffc4a4466a1cb

commit 832b7af69ca7e4d63a86d04f6f6ffc4a4466a1cb
Author: Bret Sepulveda <bsep@chromium.org>
Date: Mon Jul 11 18:29:18 2016

Fix inspector overlay when use-zoom-for-dsf is enabled.

Inspector overlays were misaligned because the path points were drawing
in window coordinates and needed to be scaled to viewport coordinates.
Should be no change when use-zoom-for-dsf is off.

BUG= 622862 

Committed: https://crrev.com/6651b97ebd509e97bea8929303738dc20a3ed880
Review-Url: https://codereview.chromium.org/2108803006
Cr-Original-Commit-Position: refs/heads/master@{#404063}
Cr-Commit-Position: refs/heads/master@{#404285}
(cherry picked from commit fca01d88e345fce580cd8acc7245f6cdc89a0c84)

Review URL: https://codereview.chromium.org/2134273002 .

Cr-Commit-Position: refs/branch-heads/2785@{#86}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/832b7af69ca7e4d63a86d04f6f6ffc4a4466a1cb/content/renderer/devtools/devtools_agent.cc
[modify] https://crrev.com/832b7af69ca7e4d63a86d04f6f6ffc4a4466a1cb/third_party/WebKit/Source/core/inspector/InspectorHighlight.cpp
[modify] https://crrev.com/832b7af69ca7e4d63a86d04f6f6ffc4a4466a1cb/third_party/WebKit/Source/core/inspector/InspectorHighlight.h
[modify] https://crrev.com/832b7af69ca7e4d63a86d04f6f6ffc4a4466a1cb/third_party/WebKit/Source/web/InspectorOverlay.cpp
[modify] https://crrev.com/832b7af69ca7e4d63a86d04f6f6ffc4a4466a1cb/third_party/WebKit/Source/web/InspectorOverlay.h

Comment 11 by bsep@chromium.org, Jul 11 2016

Status: Fixed (was: Assigned)

Comment 12 by ajha@chromium.org, Jul 12 2016

Labels: TE-Verified-M53 TE-Verified-53.0.2785.14
Verified the merge on the latest M-53(53.0.2785.14, 2785@{#96}). This is working as intended on Windows-7 at device pixel ratio=2. Attached is the screen-shot for the same.
622862.png
406 KB View Download
►

Sign in to add a comment