Yeah - I've noticed this too. The real problem is that the dialog is being shown as a window-modal sheet, but it should be a tab-modal dialog similar to http-auth ( Issue 95455 )

I'm not sure whether it regressed, or if it has been like this since r393854. I've been meaning to look, but maybe elly has some cycles.

Hm, should it actually be tab-modal? It looks like there's explicit logic in ExtensionInstallPrompt::Prompt::ShouldUseTabModalDialog() to decide to use a tab-modal only for inline install prompts.

I think it might be better to fix the layout when it is used as a window-modal, which should be doable.

Ooh - interesting. The Cocoa ones are all tab-modal, always. I'm not sure if we want these to be sheets on Mac, and modal dialogs are generally annoying anyway.

But yes, there is a layout problem for both. Comparing with Windows, it looks like removing the close button affected the layout and shifted everything up.

Fixed by https://codereview.chromium.org/2148963002/ :)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f06ef4ac6ac3dd2f3a76486d2efde9ec35583ae6

commit f06ef4ac6ac3dd2f3a76486d2efde9ec35583ae6
Author: ellyjones <ellyjones@chromium.org>
Date: Thu Jul 21 15:26:44 2016

BubbleFrameView: add top padding even when close button is hidden

If there's no title or close button present, BubbleFrameView still needs some
top padding to avoid the content being hard up against the top edge. Always pad
as though the close button was visible, even if it's not, unless there's a
title.

BUG= 622859 

Review-Url: https://codereview.chromium.org/2148963002
Cr-Commit-Position: refs/heads/master@{#406856}

[modify] https://crrev.com/f06ef4ac6ac3dd2f3a76486d2efde9ec35583ae6/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_container.cc
[modify] https://crrev.com/f06ef4ac6ac3dd2f3a76486d2efde9ec35583ae6/ui/views/bubble/bubble_dialog_delegate_unittest.cc
[modify] https://crrev.com/f06ef4ac6ac3dd2f3a76486d2efde9ec35583ae6/ui/views/bubble/bubble_frame_view.cc
[modify] https://crrev.com/f06ef4ac6ac3dd2f3a76486d2efde9ec35583ae6/ui/views/bubble/bubble_frame_view.h
[modify] https://crrev.com/f06ef4ac6ac3dd2f3a76486d2efde9ec35583ae6/ui/views/bubble/bubble_frame_view_unittest.cc

The fix in #5 has broken the bubbles top padding. See  issue 630444 .

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e8b6973cc757a5fe723fca9c3efb1ee540406abb

commit e8b6973cc757a5fe723fca9c3efb1ee540406abb
Author: ellyjones <ellyjones@chromium.org>
Date: Fri Jul 22 15:05:51 2016

Revert of BubbleFrameView: add top padding even when close button is hidden (patchset #7 id:120001 of https://codereview.chromium.org/2148963002/ )

Reason for revert:
Caused  https://crbug.com/630539 

Original issue's description:
> BubbleFrameView: add top padding even when close button is hidden
>
> If there's no title or close button present, BubbleFrameView still needs some
> top padding to avoid the content being hard up against the top edge. Always pad
> as though the close button was visible, even if it's not, unless there's a
> title.
>
> BUG= 622859 
>
> Committed: https://crrev.com/f06ef4ac6ac3dd2f3a76486d2efde9ec35583ae6
> Cr-Commit-Position: refs/heads/master@{#406856}

TBR=msw@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 622859 

Review-Url: https://codereview.chromium.org/2177533002
Cr-Commit-Position: refs/heads/master@{#407161}

[modify] https://crrev.com/e8b6973cc757a5fe723fca9c3efb1ee540406abb/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_container.cc
[modify] https://crrev.com/e8b6973cc757a5fe723fca9c3efb1ee540406abb/ui/views/bubble/bubble_dialog_delegate_unittest.cc
[modify] https://crrev.com/e8b6973cc757a5fe723fca9c3efb1ee540406abb/ui/views/bubble/bubble_frame_view.cc
[modify] https://crrev.com/e8b6973cc757a5fe723fca9c3efb1ee540406abb/ui/views/bubble/bubble_frame_view.h
[modify] https://crrev.com/e8b6973cc757a5fe723fca9c3efb1ee540406abb/ui/views/bubble/bubble_frame_view_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be7bb00e00a42a5d69c831758b4e24513d666f3a

commit be7bb00e00a42a5d69c831758b4e24513d666f3a
Author: ellyjones <ellyjones@chromium.org>
Date: Tue Aug 02 21:24:50 2016

BubbleFrameView: add padding if platform dislikes close buttons

On Mac, the close button is always hidden, which means that dialogs that expect
the height of the close button to be included in their insets have too little
top inset. This change causes dialogs to always include the close button size
in the top inset if the platform doesn't show close buttons.

BUG= 622859 

Review-Url: https://codereview.chromium.org/2189123002
Cr-Commit-Position: refs/heads/master@{#409322}

[modify] https://crrev.com/be7bb00e00a42a5d69c831758b4e24513d666f3a/ui/views/bubble/bubble_frame_view.cc
[modify] https://crrev.com/be7bb00e00a42a5d69c831758b4e24513d666f3a/ui/views/bubble/bubble_frame_view_unittest.cc
[modify] https://crrev.com/be7bb00e00a42a5d69c831758b4e24513d666f3a/ui/views/widget/widget_delegate.cc

I think this is fixed - thanks Elly!