content_browsertests failing on 64-bit N5X |
||||
Issue descriptionHello! Android N5X Swarm Builder[1] is a new builder testing out a 64-bit version of Chrome on Android N5Xs. In the course of greening up the bot, we noticed that content_browsertests is repeatedly failing[2]: C 547.451s Main IFrameZoomBrowserTest.SiblingFramesZoomFAILED C 547.451s Main FAILURES!!! Tests run: 1, Failures: 1, Errors: 0 C 547.451s Main [UNKNOWN] IFrameZoomBrowserTest.SubframesZoomProperly: C 547.451s Main [ RUN ] IFrameZoomBrowserTest.SubframesZoomProperly C 547.451s Main [WARNING:dns_config_service_posix.cc(316)] Failed to read DnsConfig. C 547.451s Main [ERROR:devtools_http_handler.cc(228)] Cannot start http server for devtools. Stop devtools. C 547.451s Main [ERROR:shell_android.cc(70)] Not implemented reached in void content::Shell::PlatformSetTitle(const string16&): Cross-site iframe factory C 547.451s Main referenceTable head length=54 1 C 547.451s Main ../../content/browser/iframe_zoom_browsertest.cc:211: Failure C 547.451s Main Value of: GetMainFrameZoomFactor(web_contents(), main_frame_window_border) C 547.451s Main Actual: 2.5025510204081631 C 547.451s Main Expected: new_zoom_factor C 547.451s Main Which is: 2.5 C 547.451s Main [ FAILED ] IFrameZoomBrowserTest.SubframesZoomProperly, where TypeParam = and GetParam() = (570 ms) C 547.451s Main [----------] 1 test from IFrameZoomBrowserTest (572 ms total) C 547.451s Main C 547.452s Main [----------] Global test environment tear-down C 547.452s Main [==========] 1 test from 1 test case ran. (573 ms total) It looks like the zoom factor is slightly off on the N5X. Is this a real failure or a failure in the test expectation? [1] https://build.chromium.org/p/chromium.android/builders/Android%20N5X%20Swarm%20Builder [2] https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.android%2FAndroid_N5X_Swarm_Builder%2F1279%2F%2B%2Frecipes%2Fsteps%2Fcontent_browsertests_on_Android%2F0%2Fstdout
,
Jun 23 2016
,
Jun 24 2016
Some of the other tests in this suite use EXPECT_NEAR, and the value being returned by the N5X bot is certainly close enough to consider it correct. Given (1) the use of double for zoom levels, and (2) the various conversions to/from zoom factors using exp/log functions, I'm comfortable making this expectation EXPECT_NEAR as well. I have a CL doing a dry-run right now, and will commit it once I've verified it doesn't upset anything else.
,
Jun 24 2016
Awesome, thank you!
,
Jun 24 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4b90fc62dee86ae8a3426df7e45f4253c79ed77a commit 4b90fc62dee86ae8a3426df7e45f4253c79ed77a Author: wjmaclean <wjmaclean@chromium.org> Date: Fri Jun 24 13:55:35 2016 Use approximate zoom level comparisons in test to accommodate N5X. Zoom level comparisons in test on the N5X bots are returning results that are off by a fraction of a percent, but otherwise seem fine. This CL changes EXPECT_DOUBLE_EQ to EXPECT_NEAR to accommodate this. BUG= 622858 TBR=creis@chromium.org Review-Url: https://codereview.chromium.org/2097063002 Cr-Commit-Position: refs/heads/master@{#401859} [modify] https://crrev.com/4b90fc62dee86ae8a3426df7e45f4253c79ed77a/content/browser/iframe_zoom_browsertest.cc
,
Jun 24 2016
Hopefully this should be ok now, please re-open if I'm wrong.
,
Jun 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/838630d2efaf6ad90ab5b3c18bd752ac9d4fd144 commit 838630d2efaf6ad90ab5b3c18bd752ac9d4fd144 Author: stip <stip@chromium.org> Date: Tue Jun 28 01:09:05 2016 Also use EXPECT_NEAR in AllFramesGetDefaultZoom and SubframeRetainsZoomOnNavigation. BUG= 622858 Review-Url: https://codereview.chromium.org/2100233002 Cr-Commit-Position: refs/heads/master@{#402358} [modify] https://crrev.com/838630d2efaf6ad90ab5b3c18bd752ac9d4fd144/content/browser/iframe_zoom_browsertest.cc |
||||
►
Sign in to add a comment |
||||
Comment 1 by stip@chromium.org
, Jun 23 2016Owner: wjmaclean@chromium.org