New issue
Advanced search Search tips

Issue 622855 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

make component build work for Monochrome

Project Member Reported by michaelbai@chromium.org, Jun 23 2016

Issue description

make component build work for Monochrome
 
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ecdcbc6d42854e4a710f208d0a3875d75dafa90

commit 4ecdcbc6d42854e4a710f208d0a3875d75dafa90
Author: machenbach <machenbach@chromium.org>
Date: Mon Sep 12 09:07:32 2016

Revert of Make secondary abi work for component build (patchset #2 id:110001 of https://codereview.chromium.org/2326973003/ )

Reason for revert:
Doesn't implement a guarded import as described. Leads to the same problems as on first CL downstream:
https://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/24283/steps/generate_build_files/logs/stdout

Original issue's description:
> Reland of Make secondary abi work for component build
>
> Reverted in:
> https://codereview.chromium.org/2327063002/
>
> Reason for reland:
> Now guards non-build import behind enable_java_templates
>
> TBR=michaelbai,machenbach
> BUG= 622855 
>
> Committed: https://crrev.com/2ded0b9b26d3cfdd3068b36c28d157c87cb8ab39
> Cr-Commit-Position: refs/heads/master@{#417597}

TBR=michaelbai@chromium.org,agrieve@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 622855 

Review-Url: https://codereview.chromium.org/2333593002
Cr-Commit-Position: refs/heads/master@{#417897}

[modify] https://crrev.com/4ecdcbc6d42854e4a710f208d0a3875d75dafa90/build/android/BUILD.gn
[modify] https://crrev.com/4ecdcbc6d42854e4a710f208d0a3875d75dafa90/build/android/gyp/write_build_config.py
[modify] https://crrev.com/4ecdcbc6d42854e4a710f208d0a3875d75dafa90/build/config/android/internal_rules.gni
[modify] https://crrev.com/4ecdcbc6d42854e4a710f208d0a3875d75dafa90/build/config/android/rules.gni

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 14 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/2defa15e50773de24e664faf527e9ba99746eef1

commit 2defa15e50773de24e664faf527e9ba99746eef1
Author: Tao Bai <michaelbai@google.com>
Date: Wed Sep 07 20:57:17 2016

Status: Fixed (was: Untriaged)

Sign in to add a comment