New issue
Advanced search Search tips

Issue 622828 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

git cl upload --dry-run doesn't work for gerrit

Project Member Reported by tandrii@chromium.org, Jun 23 2016

Issue description

As title says. Uploads the patch just fine, but doesn't trigger CQ.

 
Labels: Pri-2
Status: Assigned (was: Started)

Comment 3 by benhenry@google.com, Jun 27 2016

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/6c515e74528cfa12a7bc8a259ad4568d2f599293

commit 6c515e74528cfa12a7bc8a259ad4568d2f599293
Author: recipe-roller <recipe-roller@chromium.org>
Date: Wed Jul 06 10:55:39 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

depot_tools:
  https://crrev.com/4b233bdb48571ab5b4f4567f3cee7a4dc28bb93c Implement git cl set-commit --dry-run for Rietveld. (tandrii@chromium.org)

R=machenbach@chromium.org,emso@chromium.org,tandrii@chromium.org
BUG= 622828 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2124953003

[modify] https://crrev.com/6c515e74528cfa12a7bc8a259ad4568d2f599293/infra/config/recipes.cfg

Project Member

Comment 6 by bugdroid1@chromium.org, Jul 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/6c515e74528cfa12a7bc8a259ad4568d2f599293

commit 6c515e74528cfa12a7bc8a259ad4568d2f599293
Author: recipe-roller <recipe-roller@chromium.org>
Date: Wed Jul 06 10:55:39 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

depot_tools:
  https://crrev.com/4b233bdb48571ab5b4f4567f3cee7a4dc28bb93c Implement git cl set-commit --dry-run for Rietveld. (tandrii@chromium.org)

R=machenbach@chromium.org,emso@chromium.org,tandrii@chromium.org
BUG= 622828 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2124953003

[modify] https://crrev.com/6c515e74528cfa12a7bc8a259ad4568d2f599293/infra/config/recipes.cfg

Project Member

Comment 7 by bugdroid1@chromium.org, Jul 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/4d0545a43968c2cf1d03f03df368da05c94a4a6e

commit 4d0545a43968c2cf1d03f03df368da05c94a4a6e
Author: tandrii <tandrii@chromium.org>
Date: Wed Jul 06 10:56:49 2016

Implement git cl upload --dry-run or --use-commit-queue for Gerrit.

Previously, it only worked for Rietveld.

BUG= 622828 
R=emso@chromium.org,machenbach@chromium.org

Review-Url: https://codereview.chromium.org/2117183004

[modify] https://crrev.com/4d0545a43968c2cf1d03f03df368da05c94a4a6e/git_cl.py

Project Member

Comment 8 by bugdroid1@chromium.org, Jul 6 2016

Project Member

Comment 9 by bugdroid1@chromium.org, Jul 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/938d099715b4ff6c88e8fc5d3a81cac5757f9b00

commit 938d099715b4ff6c88e8fc5d3a81cac5757f9b00
Author: recipe-roller <recipe-roller@chromium.org>
Date: Wed Jul 06 11:06:44 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

depot_tools:
  https://crrev.com/4d0545a43968c2cf1d03f03df368da05c94a4a6e Implement git cl upload --dry-run or --use-commit-queue for Gerrit. (tandrii@chromium.org)

R=machenbach@chromium.org,emso@chromium.org,tandrii@chromium.org
BUG= 622828 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2129473002

[modify] https://crrev.com/938d099715b4ff6c88e8fc5d3a81cac5757f9b00/infra/config/recipes.cfg

Project Member

Comment 10 by bugdroid1@chromium.org, Jul 6 2016

Project Member

Comment 11 by bugdroid1@chromium.org, Jul 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/0d3f4d37f2360c160a5c2ec12cc8390aadfdcc03

commit 0d3f4d37f2360c160a5c2ec12cc8390aadfdcc03
Author: recipe-roller <recipe-roller@chromium.org>
Date: Wed Jul 06 11:19:28 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/6c515e74528cfa12a7bc8a259ad4568d2f599293 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
depot_tools:
  https://crrev.com/4b233bdb48571ab5b4f4567f3cee7a4dc28bb93c Implement git cl set-commit --dry-run for Rietveld. (tandrii@chromium.org)

R=tandrii@chromium.org,machenbach@chromium.org,emso@chromium.org,recipe-roller@chromium.org,martiniss@chromium.org,phajdan.jr@chromium.org
BUG= 622828 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2121293002

[modify] https://crrev.com/0d3f4d37f2360c160a5c2ec12cc8390aadfdcc03/infra/config/recipes.cfg

Project Member

Comment 12 by bugdroid1@chromium.org, Jul 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/0d3f4d37f2360c160a5c2ec12cc8390aadfdcc03

commit 0d3f4d37f2360c160a5c2ec12cc8390aadfdcc03
Author: recipe-roller <recipe-roller@chromium.org>
Date: Wed Jul 06 11:19:28 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/6c515e74528cfa12a7bc8a259ad4568d2f599293 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
depot_tools:
  https://crrev.com/4b233bdb48571ab5b4f4567f3cee7a4dc28bb93c Implement git cl set-commit --dry-run for Rietveld. (tandrii@chromium.org)

R=tandrii@chromium.org,machenbach@chromium.org,emso@chromium.org,recipe-roller@chromium.org,martiniss@chromium.org,phajdan.jr@chromium.org
BUG= 622828 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2121293002

[modify] https://crrev.com/0d3f4d37f2360c160a5c2ec12cc8390aadfdcc03/infra/config/recipes.cfg

Project Member

Comment 13 by bugdroid1@chromium.org, Jul 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/ffdc4130ecb6238a826aecd57f10dd060be674d0

commit ffdc4130ecb6238a826aecd57f10dd060be674d0
Author: recipe-roller <recipe-roller@chromium.org>
Date: Wed Jul 06 11:38:39 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/6c515e74528cfa12a7bc8a259ad4568d2f599293 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
  https://crrev.com/938d099715b4ff6c88e8fc5d3a81cac5757f9b00 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
depot_tools:
  https://crrev.com/4b233bdb48571ab5b4f4567f3cee7a4dc28bb93c Implement git cl set-commit --dry-run for Rietveld. (tandrii@chromium.org)
  https://crrev.com/4d0545a43968c2cf1d03f03df368da05c94a4a6e Implement git cl upload --dry-run or --use-commit-queue for Gerrit. (tandrii@chromium.org)

R=tandrii@chromium.org,machenbach@chromium.org,emso@chromium.org,recipe-roller@chromium.org,martiniss@chromium.org,phajdan.jr@chromium.org
BUG= 622828 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2129483002

[modify] https://crrev.com/ffdc4130ecb6238a826aecd57f10dd060be674d0/infra/config/recipes.cfg

Status: Fixed (was: Started)
Project Member

Comment 15 by bugdroid1@chromium.org, Jul 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/5b8376e53b330fe36c1210df898030e0cc05c94f

commit 5b8376e53b330fe36c1210df898030e0cc05c94f
Author: recipe-roller <recipe-roller@chromium.org>
Date: Wed Jul 06 20:07:53 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/6c515e74528cfa12a7bc8a259ad4568d2f599293 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
  https://crrev.com/938d099715b4ff6c88e8fc5d3a81cac5757f9b00 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
  https://crrev.com/7e2069ad4011c6f8ca6989ea43e80c6921142385 V8: Remove gyp-flag-comparison feature after MB switch. (machenbach@chromium.org)
  https://crrev.com/6cd6eedf865126865cd6bf937f32f199dd0b8d03 V8: Add temporary bots to support gyp (machenbach@chromium.org)
  https://crrev.com/cf1ef26b8334f62563e36511c643d1836767e137 Search in apks/ as well as *_apk/ for built apks. (stip@chromium.org)
  https://crrev.com/74a4652c0bb9202b6b418789dae5df67555bd8bc Move known_devices file to ~/.android (bpastene@chromium.org)
depot_tools:
  https://crrev.com/4b233bdb48571ab5b4f4567f3cee7a4dc28bb93c Implement git cl set-commit --dry-run for Rietveld. (tandrii@chromium.org)
  https://crrev.com/4d0545a43968c2cf1d03f03df368da05c94a4a6e Implement git cl upload --dry-run or --use-commit-queue for Gerrit. (tandrii@chromium.org)

R=bpastene@chromium.org,tandrii@chromium.org,machenbach@chromium.org,emso@chromium.org,stip@chromium.org,recipe-roller@chromium.org,martiniss@chromium.org,phajdan.jr@chromium.org
BUG= chromium:474921 , 625921 , 624502 , 622828 , 616035 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2128653002

[modify] https://crrev.com/5b8376e53b330fe36c1210df898030e0cc05c94f/infra/config/recipes.cfg

Sign in to add a comment