We should have touchpad equivalents to TouchToScrollUpdateSwapBegin and TouchToFirstScrollUpdateSwapBegin.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/69895c817b673b47db19ca948ab0e6249e5bd699 commit 69895c817b673b47db19ca948ab0e6249e5bd699 Author: sahel <sahel@chromium.org> Date: Fri Sep 16 17:36:49 2016 SourceEventType added to LatencyInfo The source event type information will be used in a follow up patch to compute scroll latency metrics for touch and wheel, separately. BUG= 622827 TEST=RenderWidgetHostViewAuraTest.SourceEventTypeExistsInLatencyInfo, RenderWidgetHostViewMacTest.SourceEventTypeExistsInLatencyInfo, EventTest.PointerEventSourceEventTypeExistsInLatencyInfo CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2317253005 Cr-Commit-Position: refs/heads/master@{#419204} [modify] https://crrev.com/69895c817b673b47db19ca948ab0e6249e5bd699/content/browser/browser_plugin/browser_plugin_guest.cc [modify] https://crrev.com/69895c817b673b47db19ca948ab0e6249e5bd699/content/browser/frame_host/render_widget_host_view_guest.cc [modify] https://crrev.com/69895c817b673b47db19ca948ab0e6249e5bd699/content/browser/renderer_host/input/mouse_wheel_event_queue.cc [modify] https://crrev.com/69895c817b673b47db19ca948ab0e6249e5bd699/content/browser/renderer_host/render_widget_host_impl.cc [modify] https://crrev.com/69895c817b673b47db19ca948ab0e6249e5bd699/content/browser/renderer_host/render_widget_host_impl.h [modify] https://crrev.com/69895c817b673b47db19ca948ab0e6249e5bd699/content/browser/renderer_host/render_widget_host_input_event_router.cc [modify] https://crrev.com/69895c817b673b47db19ca948ab0e6249e5bd699/content/browser/renderer_host/render_widget_host_input_event_router.h [modify] https://crrev.com/69895c817b673b47db19ca948ab0e6249e5bd699/content/browser/renderer_host/render_widget_host_view_android.cc [modify] https://crrev.com/69895c817b673b47db19ca948ab0e6249e5bd699/content/browser/renderer_host/render_widget_host_view_aura.cc [modify] https://crrev.com/69895c817b673b47db19ca948ab0e6249e5bd699/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc [modify] https://crrev.com/69895c817b673b47db19ca948ab0e6249e5bd699/content/browser/renderer_host/render_widget_host_view_mac.mm [modify] https://crrev.com/69895c817b673b47db19ca948ab0e6249e5bd699/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm [modify] https://crrev.com/69895c817b673b47db19ca948ab0e6249e5bd699/content/browser/site_per_process_browsertest.cc [modify] https://crrev.com/69895c817b673b47db19ca948ab0e6249e5bd699/ui/events/blink/web_input_event_traits.cc [modify] https://crrev.com/69895c817b673b47db19ca948ab0e6249e5bd699/ui/events/blink/web_input_event_traits.h [modify] https://crrev.com/69895c817b673b47db19ca948ab0e6249e5bd699/ui/events/event.cc [modify] https://crrev.com/69895c817b673b47db19ca948ab0e6249e5bd699/ui/events/event_unittest.cc [modify] https://crrev.com/69895c817b673b47db19ca948ab0e6249e5bd699/ui/events/ipc/latency_info_param_traits.cc [modify] https://crrev.com/69895c817b673b47db19ca948ab0e6249e5bd699/ui/events/ipc/latency_info_param_traits_macros.h [modify] https://crrev.com/69895c817b673b47db19ca948ab0e6249e5bd699/ui/events/latency_info.cc [modify] https://crrev.com/69895c817b673b47db19ca948ab0e6249e5bd699/ui/events/latency_info.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3c16fd5c44f7559ec668260f24e46214009d201e commit 3c16fd5c44f7559ec668260f24e46214009d201e Author: sahel <sahel@chromium.org> Date: Wed Oct 05 22:03:41 2016 revert "SourceEventType added to LatencyInfo." to see if it solves the content_browsertest timeouts on win64 official build. reverted cl: https://crrev.com/2317253005 TBR=jochen@chromium.org, sky@chromium.org BUG=650175, 622827 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2394593002 Cr-Commit-Position: refs/heads/master@{#423309} [modify] https://crrev.com/3c16fd5c44f7559ec668260f24e46214009d201e/content/browser/browser_plugin/browser_plugin_guest.cc [modify] https://crrev.com/3c16fd5c44f7559ec668260f24e46214009d201e/content/browser/frame_host/render_widget_host_view_guest.cc [modify] https://crrev.com/3c16fd5c44f7559ec668260f24e46214009d201e/content/browser/renderer_host/input/mouse_wheel_event_queue.cc [modify] https://crrev.com/3c16fd5c44f7559ec668260f24e46214009d201e/content/browser/renderer_host/render_widget_host_impl.cc [modify] https://crrev.com/3c16fd5c44f7559ec668260f24e46214009d201e/content/browser/renderer_host/render_widget_host_impl.h [modify] https://crrev.com/3c16fd5c44f7559ec668260f24e46214009d201e/content/browser/renderer_host/render_widget_host_input_event_router.cc [modify] https://crrev.com/3c16fd5c44f7559ec668260f24e46214009d201e/content/browser/renderer_host/render_widget_host_input_event_router.h [modify] https://crrev.com/3c16fd5c44f7559ec668260f24e46214009d201e/content/browser/renderer_host/render_widget_host_view_android.cc [modify] https://crrev.com/3c16fd5c44f7559ec668260f24e46214009d201e/content/browser/renderer_host/render_widget_host_view_aura.cc [modify] https://crrev.com/3c16fd5c44f7559ec668260f24e46214009d201e/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc [modify] https://crrev.com/3c16fd5c44f7559ec668260f24e46214009d201e/content/browser/renderer_host/render_widget_host_view_mac.mm [modify] https://crrev.com/3c16fd5c44f7559ec668260f24e46214009d201e/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm [modify] https://crrev.com/3c16fd5c44f7559ec668260f24e46214009d201e/content/browser/site_per_process_browsertest.cc [modify] https://crrev.com/3c16fd5c44f7559ec668260f24e46214009d201e/ui/events/blink/web_input_event_traits.cc [modify] https://crrev.com/3c16fd5c44f7559ec668260f24e46214009d201e/ui/events/blink/web_input_event_traits.h [modify] https://crrev.com/3c16fd5c44f7559ec668260f24e46214009d201e/ui/events/event.cc [modify] https://crrev.com/3c16fd5c44f7559ec668260f24e46214009d201e/ui/events/event_unittest.cc [modify] https://crrev.com/3c16fd5c44f7559ec668260f24e46214009d201e/ui/events/ipc/latency_info_param_traits.cc [modify] https://crrev.com/3c16fd5c44f7559ec668260f24e46214009d201e/ui/events/ipc/latency_info_param_traits_macros.h [modify] https://crrev.com/3c16fd5c44f7559ec668260f24e46214009d201e/ui/events/latency_info.cc [modify] https://crrev.com/3c16fd5c44f7559ec668260f24e46214009d201e/ui/events/latency_info.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2a19cf18cdd4bdbf45a9e1a41c685d43319de8d1 commit 2a19cf18cdd4bdbf45a9e1a41c685d43319de8d1 Author: sahel <sahel@chromium.org> Date: Fri Oct 07 13:40:08 2016 re-land the "SourceEventType added to LatencyInfo." Reverting the cl didn't solve the content_browsertest timeouts on win64 official build. re-landed cl: https://crrev.com/2317253005 TBR=wjmaclean@chromium.org, nasko@chromium.org, tdresser@chromium.org, sky@chromium.org BUG=650175, 622827 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2393783005 Cr-Commit-Position: refs/heads/master@{#423847} [modify] https://crrev.com/2a19cf18cdd4bdbf45a9e1a41c685d43319de8d1/content/browser/browser_plugin/browser_plugin_guest.cc [modify] https://crrev.com/2a19cf18cdd4bdbf45a9e1a41c685d43319de8d1/content/browser/frame_host/render_widget_host_view_guest.cc [modify] https://crrev.com/2a19cf18cdd4bdbf45a9e1a41c685d43319de8d1/content/browser/renderer_host/input/mouse_wheel_event_queue.cc [modify] https://crrev.com/2a19cf18cdd4bdbf45a9e1a41c685d43319de8d1/content/browser/renderer_host/render_widget_host_impl.cc [modify] https://crrev.com/2a19cf18cdd4bdbf45a9e1a41c685d43319de8d1/content/browser/renderer_host/render_widget_host_impl.h [modify] https://crrev.com/2a19cf18cdd4bdbf45a9e1a41c685d43319de8d1/content/browser/renderer_host/render_widget_host_input_event_router.cc [modify] https://crrev.com/2a19cf18cdd4bdbf45a9e1a41c685d43319de8d1/content/browser/renderer_host/render_widget_host_input_event_router.h [modify] https://crrev.com/2a19cf18cdd4bdbf45a9e1a41c685d43319de8d1/content/browser/renderer_host/render_widget_host_view_android.cc [modify] https://crrev.com/2a19cf18cdd4bdbf45a9e1a41c685d43319de8d1/content/browser/renderer_host/render_widget_host_view_aura.cc [modify] https://crrev.com/2a19cf18cdd4bdbf45a9e1a41c685d43319de8d1/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc [modify] https://crrev.com/2a19cf18cdd4bdbf45a9e1a41c685d43319de8d1/content/browser/renderer_host/render_widget_host_view_mac.mm [modify] https://crrev.com/2a19cf18cdd4bdbf45a9e1a41c685d43319de8d1/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm [modify] https://crrev.com/2a19cf18cdd4bdbf45a9e1a41c685d43319de8d1/content/browser/site_per_process_browsertest.cc [modify] https://crrev.com/2a19cf18cdd4bdbf45a9e1a41c685d43319de8d1/ui/events/blink/web_input_event_traits.cc [modify] https://crrev.com/2a19cf18cdd4bdbf45a9e1a41c685d43319de8d1/ui/events/blink/web_input_event_traits.h [modify] https://crrev.com/2a19cf18cdd4bdbf45a9e1a41c685d43319de8d1/ui/events/event.cc [modify] https://crrev.com/2a19cf18cdd4bdbf45a9e1a41c685d43319de8d1/ui/events/event_unittest.cc [modify] https://crrev.com/2a19cf18cdd4bdbf45a9e1a41c685d43319de8d1/ui/events/ipc/latency_info_param_traits.cc [modify] https://crrev.com/2a19cf18cdd4bdbf45a9e1a41c685d43319de8d1/ui/events/ipc/latency_info_param_traits_macros.h [modify] https://crrev.com/2a19cf18cdd4bdbf45a9e1a41c685d43319de8d1/ui/events/latency_info.cc [modify] https://crrev.com/2a19cf18cdd4bdbf45a9e1a41c685d43319de8d1/ui/events/latency_info.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e05ae5d2865b5c1095b552a39f4dbafa14a82e0d commit e05ae5d2865b5c1095b552a39f4dbafa14a82e0d Author: sahel <sahel@chromium.org> Date: Fri Oct 07 19:54:46 2016 New scroll latency metrics added for touch and wheel. The new latency metrics are calculated based on the difference between the first and last event time of the start and end componenets, respectively. They deprecate the old metrics that use the average event time of both components, and report the latency only for touch scrolls. BUG= 622827 TEST=RenderWidgetHostLatencyTrackerTest.TouchTestHistograms, RenderWidgetHostLatencyTrackerTest.WheelTestHistograms Review-Url: https://codereview.chromium.org/2341413002 Cr-Commit-Position: refs/heads/master@{#423944} [modify] https://crrev.com/e05ae5d2865b5c1095b552a39f4dbafa14a82e0d/content/browser/renderer_host/input/render_widget_host_latency_tracker.cc [modify] https://crrev.com/e05ae5d2865b5c1095b552a39f4dbafa14a82e0d/content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc [modify] https://crrev.com/e05ae5d2865b5c1095b552a39f4dbafa14a82e0d/tools/metrics/histograms/histograms.xml [modify] https://crrev.com/e05ae5d2865b5c1095b552a39f4dbafa14a82e0d/ui/events/ipc/latency_info_param_traits_macros.h [modify] https://crrev.com/e05ae5d2865b5c1095b552a39f4dbafa14a82e0d/ui/events/latency_info.cc [modify] https://crrev.com/e05ae5d2865b5c1095b552a39f4dbafa14a82e0d/ui/events/latency_info.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/956857461fdc0f0d2beb304bbc96ffda398d9c37 commit 956857461fdc0f0d2beb304bbc96ffda398d9c37 Author: sahel <sahel@chromium.org> Date: Fri Oct 14 20:21:26 2016 Rename Event.Latency.* to Event.Latency.ScrollUpdate.* BUG= 622827 Review-Url: https://codereview.chromium.org/2416173003 Cr-Commit-Position: refs/heads/master@{#425452} [modify] https://crrev.com/956857461fdc0f0d2beb304bbc96ffda398d9c37/content/browser/renderer_host/input/render_widget_host_latency_tracker.cc [modify] https://crrev.com/956857461fdc0f0d2beb304bbc96ffda398d9c37/content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc [modify] https://crrev.com/956857461fdc0f0d2beb304bbc96ffda398d9c37/tools/metrics/histograms/histograms.xml
[Automated comment] removing mislabelled merge-merged-2840
Comment 1 by sahel@chromium.org
, Sep 1 2016