Hitting enter/return should submit input |
||||||
Issue description1. Click the Show home button checkbox 2. Click in www.example.com 3. Type www.apple.com When I press Return I expect my new URL to be accepted but instead the insertion point just keeps flashing at me. I see that if I switch to another web page the URL is converted into http://www.apple.com/ and accepted. I guess there's code that sanitizes the URL that's triggered by some event. That explains another problem I saw several times where I was able to type www.apple.c and right at that point the URL was converted to http://www.apple.c/ and entered. I tried to find what triggered the sanitizer in this case but was not successful.
,
Jun 23 2016
This is a common issue with textboxes in Settings.
,
Jun 29 2016
,
Dec 10 2016
,
Jan 13 2017
I'll take this on.
,
Jan 14 2017
The add On Startup url dialog may be a good place to check.
,
Jan 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/604d8749c2e91c437dc6e7e0e2d541fb28770527 commit 604d8749c2e91c437dc6e7e0e2d541fb28770527 Author: tommycli <tommycli@chromium.org> Date: Sat Jan 14 01:14:47 2017 MD Settings: Use "change" event instead of "blur" for settings-input. Update the pref on the "change" event instead of the "blur" event. The "change" event is fired when the user presses the Enter key. It also is notably not fired if the value stays the same and the input is blurred. BUG= 622816 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2631863002 Cr-Commit-Position: refs/heads/master@{#443756} [modify] https://crrev.com/604d8749c2e91c437dc6e7e0e2d541fb28770527/chrome/browser/resources/settings/controls/settings_input.html [modify] https://crrev.com/604d8749c2e91c437dc6e7e0e2d541fb28770527/chrome/browser/resources/settings/controls/settings_input.js
,
Jan 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/83d63d4b6acb4af448f5532f0ca7fee1828dae32 commit 83d63d4b6acb4af448f5532f0ca7fee1828dae32 Author: tommycli <tommycli@chromium.org> Date: Tue Jan 17 19:31:10 2017 MD Settings: Update some ChromeOS inputs to on-change To fire on the Enter key, and only fire when the value changes, change the listened event on some ChromeOS inputs from on-blur to on-change. BUG= 622816 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2624213008 Cr-Commit-Position: refs/heads/master@{#444109} [modify] https://crrev.com/83d63d4b6acb4af448f5532f0ca7fee1828dae32/chrome/browser/resources/settings/internet_page/network_nameservers.html [modify] https://crrev.com/83d63d4b6acb4af448f5532f0ca7fee1828dae32/chrome/browser/resources/settings/internet_page/network_property_list.html [modify] https://crrev.com/83d63d4b6acb4af448f5532f0ca7fee1828dae32/chrome/browser/resources/settings/internet_page/network_proxy.html [modify] https://crrev.com/83d63d4b6acb4af448f5532f0ca7fee1828dae32/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.html [modify] https://crrev.com/83d63d4b6acb4af448f5532f0ca7fee1828dae32/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.js [modify] https://crrev.com/83d63d4b6acb4af448f5532f0ca7fee1828dae32/chrome/browser/resources/settings/printing_page/cups_printer_details_page.html [modify] https://crrev.com/83d63d4b6acb4af448f5532f0ca7fee1828dae32/chrome/browser/resources/settings/printing_page/cups_printer_details_page.js
,
Jan 19 2017
Tested the issue on Chrome Dev# 57.0.2986.0 on Windows, Mac and Linux and below are the observations. Observation (i) 1. Navigated to chrome://settings 2. Checked "Show Home Button" and entered www.google.com and clicked Enter from key board. 3. Change in URL is accepted. Observation (ii) -- Followed steps from Bug ID: 624331. 1. Navigated to chrome://md-settings 2. Checked "Show Home Button" and entered www.google.com and clicked Enter from key board. 3. Nothing happens when Enter is clicked. @shirke -- Could you please confirm the above observations so that the issue can be triaged further. Thanks in Advance.
,
Jan 23 2017
msrchandra: Can you try again with Canary? I'm testing, and the change is accepted.
,
Jan 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c2f23d8d70cf93aef29ee64a957ab6a8714798b7 commit c2f23d8d70cf93aef29ee64a957ab6a8714798b7 Author: tommycli <tommycli@chromium.org> Date: Mon Jan 23 21:33:43 2017 MD Settings People: Make Enter key work for Sync Page Fixes these two cases: 1) Enter key for creating a new passphrase 2) Enter key for submitting the previously-set sync passphrase. BUG= 622816 TEST=MANUAL CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2632783003 Cr-Commit-Position: refs/heads/master@{#445491} [modify] https://crrev.com/c2f23d8d70cf93aef29ee64a957ab6a8714798b7/chrome/browser/resources/settings/people_page/sync_page.html
,
Jan 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8e4c91b58fd813b88518f6826ae79adde7a4c240 commit 8e4c91b58fd813b88518f6826ae79adde7a4c240 Author: tommycli <tommycli@chromium.org> Date: Tue Jan 24 01:20:36 2017 MD Settings: Make Enter key submit changes in the Internet section 1. In the input field to add a new proxy exception, the Enter key now adds the entered proxy exception. 2. In the PIN dialog boxes for the Cellular networks, the Enter key now submits the PIN. BUG= 622816 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2650693005 Cr-Commit-Position: refs/heads/master@{#445577} [modify] https://crrev.com/8e4c91b58fd813b88518f6826ae79adde7a4c240/chrome/browser/resources/settings/internet_page/network_proxy.html [modify] https://crrev.com/8e4c91b58fd813b88518f6826ae79adde7a4c240/chrome/browser/resources/settings/internet_page/network_siminfo.html
,
Jan 24 2017
@tommycli -- As mentioned in Comment# 9 the behavior is still same in latest Canary# 57.0.2991.0. When hitting Enter near Home Button, the URL change is seen. When doing the same under "Open specific page or set of pages" --> Enter URL and click Enter --> Nothing happens. Could you please confirm and let me know if any more information is required. Thanks in Advance.
,
Jan 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5d586aa2a68a7a5c4051e7a0a0ecc8a925414576 commit 5d586aa2a68a7a5c4051e7a0a0ecc8a925414576 Author: tommycli <tommycli@chromium.org> Date: Tue Jan 24 22:04:16 2017 MD Settings: Update Autofill Address Dialog to accept Enter Key BUG= 622816 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2654663006 Cr-Commit-Position: refs/heads/master@{#445831} [modify] https://crrev.com/5d586aa2a68a7a5c4051e7a0a0ecc8a925414576/chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.html [modify] https://crrev.com/5d586aa2a68a7a5c4051e7a0a0ecc8a925414576/chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.js
,
Jan 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7be13603d26805f7502868b60df51767f2ae21a9 commit 7be13603d26805f7502868b60df51767f2ae21a9 Author: tommycli <tommycli@chromium.org> Date: Tue Jan 24 22:06:26 2017 MD Settings: Update Autofill Credit Card Dialog to accept Enter Key 1) Updates the credit card dialog to accept the Enter key on the name and CC number fields, just as the Options dialog allows. 2) Also controls the Save button state to prohibit saving of blank cards, just like the Options dialog. BUG= 622816 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2654553004 Cr-Commit-Position: refs/heads/master@{#445832} [modify] https://crrev.com/7be13603d26805f7502868b60df51767f2ae21a9/chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.html [modify] https://crrev.com/7be13603d26805f7502868b60df51767f2ae21a9/chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.js [modify] https://crrev.com/7be13603d26805f7502868b60df51767f2ae21a9/chrome/test/data/webui/settings/settings_autofill_section_browsertest.js
,
Jan 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7be13603d26805f7502868b60df51767f2ae21a9 commit 7be13603d26805f7502868b60df51767f2ae21a9 Author: tommycli <tommycli@chromium.org> Date: Tue Jan 24 22:06:26 2017 MD Settings: Update Autofill Credit Card Dialog to accept Enter Key 1) Updates the credit card dialog to accept the Enter key on the name and CC number fields, just as the Options dialog allows. 2) Also controls the Save button state to prohibit saving of blank cards, just like the Options dialog. BUG= 622816 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2654553004 Cr-Commit-Position: refs/heads/master@{#445832} [modify] https://crrev.com/7be13603d26805f7502868b60df51767f2ae21a9/chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.html [modify] https://crrev.com/7be13603d26805f7502868b60df51767f2ae21a9/chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.js [modify] https://crrev.com/7be13603d26805f7502868b60df51767f2ae21a9/chrome/test/data/webui/settings/settings_autofill_section_browsertest.js
,
Jan 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2b25cef27d965ba56848727cf3097be410403cb6 commit 2b25cef27d965ba56848727cf3097be410403cb6 Author: tommycli <tommycli@chromium.org> Date: Thu Jan 26 19:45:19 2017 MD Settings: Update some dialogs to accept Enter key. Updates the following dialogs to accept the Enter key: 1. Certificate decryption. 2. Certificate encryption. 3. Startup URL. 4. Search Engine. BUG= 622816 R=dpapad@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2653023003 Cr-Commit-Position: refs/heads/master@{#446402} [modify] https://crrev.com/2b25cef27d965ba56848727cf3097be410403cb6/chrome/browser/resources/settings/certificate_manager_page/certificate_password_decryption_dialog.html [modify] https://crrev.com/2b25cef27d965ba56848727cf3097be410403cb6/chrome/browser/resources/settings/certificate_manager_page/certificate_password_decryption_dialog.js [modify] https://crrev.com/2b25cef27d965ba56848727cf3097be410403cb6/chrome/browser/resources/settings/certificate_manager_page/certificate_password_encryption_dialog.html [modify] https://crrev.com/2b25cef27d965ba56848727cf3097be410403cb6/chrome/browser/resources/settings/certificate_manager_page/certificate_password_encryption_dialog.js [modify] https://crrev.com/2b25cef27d965ba56848727cf3097be410403cb6/chrome/browser/resources/settings/on_startup_page/startup_url_dialog.html [modify] https://crrev.com/2b25cef27d965ba56848727cf3097be410403cb6/chrome/browser/resources/settings/on_startup_page/startup_url_dialog.js [modify] https://crrev.com/2b25cef27d965ba56848727cf3097be410403cb6/chrome/browser/resources/settings/search_engines_page/search_engine_dialog.html [modify] https://crrev.com/2b25cef27d965ba56848727cf3097be410403cb6/chrome/browser/resources/settings/search_engines_page/search_engine_dialog.js [modify] https://crrev.com/2b25cef27d965ba56848727cf3097be410403cb6/chrome/test/data/webui/settings/startup_urls_page_test.js
,
Jan 26 2017
This is done, but we should follow up here to make the code more maintainable: 685699 |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by shrike@chromium.org
, Jun 23 2016