Presubmit doesn't check for single quoted html property values |
||
Issue descriptionIn a HTML, add a tag with a single quoted property, such as: <a foo='bar'> Expected: presubmit should warn the programmer that double quotes should be used for property values.
,
Jun 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/02602da5b8e5075e81ff0162262e0523fe4b1863 commit 02602da5b8e5075e81ff0162262e0523fe4b1863 Author: dschuyler <dschuyler@chromium.org> Date: Tue Jun 28 23:56:08 2016 [Presubmit] check for single quotes in html properties This CL will cause presubmit to warn programmers when using single quotes in HTML property names. BUG= 622814 Review-Url: https://codereview.chromium.org/2091903002 Cr-Commit-Position: refs/heads/master@{#402605} [modify] https://crrev.com/02602da5b8e5075e81ff0162262e0523fe4b1863/chrome/browser/web_dev_style/html_checker.py [modify] https://crrev.com/02602da5b8e5075e81ff0162262e0523fe4b1863/chrome/browser/web_dev_style/html_checker_test.py [modify] https://crrev.com/02602da5b8e5075e81ff0162262e0523fe4b1863/chrome/browser/web_dev_style/test_util.py
,
Jun 29 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by dbeam@chromium.org
, Jun 23 2016note: Polymer's gonna make this harder to detect, i.e. <div id="my-id">[[getThing('stringLiteral')]]</div>