New issue
Advanced search Search tips

Issue 622802 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 671375



Sign in to add a comment

Checkbox rows in Appearance look like they are indented under "Themes"

Project Member Reported by shrike@chromium.org, Jun 23 2016

Issue description

I wondered why "Themes" is bolded but "Show home button" is not. I figured out that Themes, Customize fonts, etc. are titles of their subsections while "Show home button" is a control label. What's confusing is "Themes" and "Show home button" are in the same location in their subsection, which makes "Show home button" look like a title where you forgot the bolding.

The location of these subsection titles, and their relation to content within the subsections, needs to be consistent. They should never, for example, be pushed to the right to accommodate an icon. See attachment.
 
SubsectionRework.png
20.8 KB View Download
Labels: Hotlist-MD-Settings-Appearance
Owner: dschuyler@chromium.org
Status: Assigned (was: Untriaged)
This looks like visual bugs -- the all the strings you mentioned should have a normal weight, and the indentation does not match the mocks for Themes / Customize fonts.
Status: WontFix (was: Assigned)
I'm not able to reproduce this. Is it still happening.
It looks pretty bad, so it may have been fixed right away.

Comment 3 by shrike@chromium.org, Aug 29 2016

It's definitely better - "Themes" is now at the same indentation as Show home button. In that sense the bug is fixed. However it is a mistake for Themes, Show home button, etc. to be indented to accommodate the checkboxes while other titles like Font size and Customize fonts live at a lower indentation level. It implies the titles have different status/importance when they are equivalent.

Owner: bettes@chromium.org
Status: Assigned (was: WontFix)
Alan is working on a different layout to address that.

Alan@ I'm sending this to you to while you're getting that new layout proposal ready. Feel free to send this back to me when you're ready.
Blocking: 671375
Labels: -Pri-2 Pri-1
@bettes, should we move these to toggles?
Summary: Checkbox rows in Appearance look like they are indented under "Themes" (was: [Settings, Appearance] Subsections in the Appearance section are confusing)

Comment 7 by bettes@chromium.org, Dec 12 2016

Owner: tbuck...@chromium.org
Yes. Toggles are preferred here. 
Screen Shot 2016-12-12 at 2.45.02 PM.png
65.2 KB View Download
Owner: dbeam@chromium.org
@dbeam is this fixed as part of the move to toggles?

Comment 9 by dbeam@chromium.org, Jan 24 2017

Status: Fixed (was: Assigned)
appearance_after_toggles.png
16.7 KB View Download

Sign in to add a comment