New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 622796 link

Starred by 3 users

Issue metadata

Status: Started
Owner:
User never visited
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature



Sign in to add a comment

add preload library for generic containers

Project Member Reported by ashishgaurav@chromium.org, Jun 23 2016

Issue description

The library extends open and open64 for now.
 
Cc: vapier@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/c3188b6179469d3c908dc26edade36e161458046

commit c3188b6179469d3c908dc26edade36e161458046
Author: Ashish Gaurav <ashishgaurav@google.com>
Date: Thu Jun 23 18:09:47 2016

libcontainer_overrides: new ebuild

libcontainer_overrides is a preload library for generic containers.

BUG=chromium:622796
TEST=emerge-cyan libpreload with platform2/libpreload
Change-Id: Id32fb70e2519603a618578850456a0d5a269a565
Reviewed-on: https://chromium-review.googlesource.com/355691
Commit-Ready: Ashish Gaurav <ashishgaurav@chromium.org>
Tested-by: Ashish Gaurav <ashishgaurav@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[add] https://crrev.com/c3188b6179469d3c908dc26edade36e161458046/chromeos-base/libcontainer_overrides/libcontainer_overrides-9999.ebuild

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/57527f10988868b4ebef0174076a4ae7d88c6824

commit 57527f10988868b4ebef0174076a4ae7d88c6824
Author: Ashish Gaurav <ashishgaurav@google.com>
Date: Thu Jun 23 18:41:20 2016

libcontainer_overrides: initial revision

This is a preload library for custom generic containers. For now,
can talk to broker_service outside the container, and it just
implements open and open64. Based off initial code by ksanthanam@.

BUG=chromium:622796
TEST=emerge-cyan libpreload with ebuild produces preload.so
Change-Id: Ia72620316d7d0c67cd529c6effe66ebce8dce1b9
Reviewed-on: https://chromium-review.googlesource.com/355710
Commit-Ready: Ashish Gaurav <ashishgaurav@chromium.org>
Tested-by: Ashish Gaurav <ashishgaurav@chromium.org>
Reviewed-by: Andrew de los Reyes <adlr@chromium.org>

[add] https://crrev.com/57527f10988868b4ebef0174076a4ae7d88c6824/libcontainer_overrides/libcontainer_overrides.gyp
[add] https://crrev.com/57527f10988868b4ebef0174076a4ae7d88c6824/libcontainer_overrides/broker_client.c
[add] https://crrev.com/57527f10988868b4ebef0174076a4ae7d88c6824/libcontainer_overrides/broker_client.h
[add] https://crrev.com/57527f10988868b4ebef0174076a4ae7d88c6824/libcontainer_overrides/preload.c

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/a61f8d89e4a4115abec59f071fbc3469d2a1b17f

commit a61f8d89e4a4115abec59f071fbc3469d2a1b17f
Author: Keshav Santhanam <ksanthanam@google.com>
Date: Tue Jul 26 00:29:46 2016

libcontainer_overrides: Add open and open64 to preload

This adds overrides for the open and open64 calls to
allow programs running inside a container as non-root
to open USB devices with write access.

BUG=chromium:622796
TEST=Run fastboot inside a container and verify that
it takes the preload path.

Change-Id: Id74117a2fb455a8ae67440f2028c5a64aada4c85
Reviewed-on: https://chromium-review.googlesource.com/363005
Commit-Ready: Keshav Santhanam <ksanthanam@google.com>
Tested-by: Keshav Santhanam <ksanthanam@google.com>
Reviewed-by: Dylan Reid <dgreid@chromium.org>

[modify] https://crrev.com/a61f8d89e4a4115abec59f071fbc3469d2a1b17f/libcontainer_overrides/preload.c

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/21c2a89ceea57e6b6de9ea5841f2a9601dfd90ae

commit 21c2a89ceea57e6b6de9ea5841f2a9601dfd90ae
Author: Keshav Santhanam <ksanthanam@google.com>
Date: Wed Jul 27 20:11:21 2016

libcontainer_overrides: Remove debugging statements

This removes the fprintf and perror calls used for
debugging broker_client

BUG=chromium:622796
TEST=none

Change-Id: I1b60d8ce59d36b4b7242beaf6fd39c36340a6bed
Reviewed-on: https://chromium-review.googlesource.com/363930
Commit-Ready: Keshav Santhanam <ksanthanam@google.com>
Tested-by: Keshav Santhanam <ksanthanam@google.com>
Reviewed-by: Dylan Reid <dgreid@chromium.org>

[modify] https://crrev.com/21c2a89ceea57e6b6de9ea5841f2a9601dfd90ae/libcontainer_overrides/broker_client.c

Components: OS>Systems>Containers

Sign in to add a comment