New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 622786 link

Starred by 2 users
Status: Fixed
Owner:
█ dschuyler@chromium.org
Last visit > 30 days ago
Closed: Aug 2016
Cc:
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Settings, Appearance] "Themes" should be singular

Project Member Reported by shrike@chromium.org, Jun 23 2016 
Unless this section lets you manage multiple themes, the title should be "Theme".

Comment 1 by tbuck...@chromium.org, Jun 23 2016

Labels: -Pri-2 Hotlist-MD-Settings-Appearance Pri-3
Owner: dschuyler@chromium.org
Status: Assigned (was: Untriaged)
Fair point!

Comment 2 by dschuyler@chromium.org, Aug 27 2016

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 31 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1900650f2f08e845531db6b01c8aafc4365d4d8

commit d1900650f2f08e845531db6b01c8aafc4365d4d8
Author: dschuyler <dschuyler@chromium.org>
Date: Wed Aug 31 00:21:25 2016

[MD settings] change theme label text

This CL changes the label text from Themes to Theme since there is a
single theme (not plural).

BUG= 622786 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2284113002
Cr-Commit-Position: refs/heads/master@{#415510}

[modify] https://crrev.com/d1900650f2f08e845531db6b01c8aafc4365d4d8/chrome/app/settings_strings.grdp
[modify] https://crrev.com/d1900650f2f08e845531db6b01c8aafc4365d4d8/chrome/browser/resources/settings/appearance_page/appearance_page.html
[modify] https://crrev.com/d1900650f2f08e845531db6b01c8aafc4365d4d8/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Comment 4 by dschuyler@chromium.org, Aug 31 2016

Status: Fixed (was: Started)
►

Sign in to add a comment