The PIN keyboard needs to be localized. Specifically: - The digits need to be locale specific (maybe use [1]?) - If the user is entering a PIN, text should be LTR, but if they are entering a password, it should be RTL. A complicating factor here is that the PIN keyboard is used in settings and oobe, which use different localization methods. Settings uses $i18n[2], and oobe uses i18n-content/i18n-values. Looking at the code, oobe_ui sets the localized strings using web_ui_data_source[3], which looks[4] like it might support the $i18n syntax. So we might get lucky and both oobe and settings may support the $18n syntax. The localized strings need to be added to both oobe[5] and to settings[6]. 1: https://cs.chromium.org/chromium/src/base/i18n/number_formatting.h?l=17 2: https://cs.chromium.org/chromium/src/ui/base/template_expressions.h?l=25 3: https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc?l=120 4: https://cs.chromium.org/chromium/src/content/browser/webui/web_ui_data_source_impl.cc?l=244 5: https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc?l=367 6: https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/23157c0328600c84af5880c229c25d92a34816df commit 23157c0328600c84af5880c229c25d92a34816df Author: sammiequon <sammiequon@chromium.org> Date: Wed Jul 06 20:39:06 2016 Added strings of i18n and made the pin-keyboard work for rtl lang. BUG= 622785 , 623622 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2108813002 Cr-Commit-Position: refs/heads/master@{#403945} [modify] https://crrev.com/23157c0328600c84af5880c229c25d92a34816df/chrome/app/generated_resources.grd [modify] https://crrev.com/23157c0328600c84af5880c229c25d92a34816df/chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html [modify] https://crrev.com/23157c0328600c84af5880c229c25d92a34816df/chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js [modify] https://crrev.com/23157c0328600c84af5880c229c25d92a34816df/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc [modify] https://crrev.com/23157c0328600c84af5880c229c25d92a34816df/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/23157c0328600c84af5880c229c25d92a34816df/ui/login/account_picker/user_pod_template.html
Comment 1 by sammiequon@chromium.org
, Jun 29 2016