Issue 622768 link

Starred by 2 users

Issue metadata

Status:	Assigned
Owner:	thakis@chromium.org
Components:	Build
EstimatedDays:	----
NextAction:	----
OS:	All
Pri:	3
Type:	Bug

Remove --build-tool param from compile.py

Project Member Reported by thakis@chromium.org, Jun 23 2016

Issue description

--build-tool has defaulted to ninja for a while and is now ignored. We should stop passing it from all bots, and then delete the param.

bb_android passes it, so we need to remove it there, wait for that change to reach stable, and only then can we remove it from compile.py

Project Member

Comment 1 by bugdroid1@chromium.org, Jun 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/fdb3c016e913e8b9adb6162b085c8462d8a7f60e

commit fdb3c016e913e8b9adb6162b085c8462d8a7f60e
Author: thakis <thakis@chromium.org>
Date: Thu Jun 23 17:10:20 2016

Stop passing --build-tool=ninja in master configs

BUG=622768

Review-Url: https://codereview.chromium.org/2092543005

[modify] https://crrev.com/fdb3c016e913e8b9adb6162b085c8462d8a7f60e/masters/master.chromium.memory.fyi/master.cfg
[modify] https://crrev.com/fdb3c016e913e8b9adb6162b085c8462d8a7f60e/scripts/master/factory/dart/dart_factory.py
[modify] https://crrev.com/fdb3c016e913e8b9adb6162b085c8462d8a7f60e/scripts/master/factory/gclient_factory.py

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/50e9dfa629b4df812e8c42ef5c0ad8237b36f333

commit 50e9dfa629b4df812e8c42ef5c0ad8237b36f333
Author: thakis <thakis@chromium.org>
Date: Fri Jun 24 19:09:52 2016

android bb: Stop passing --buildtool=ninja

No intended behavior change.

BUG=622768

Review-Url: https://codereview.chromium.org/2090743004
Cr-Commit-Position: refs/heads/master@{#401919}

[modify] https://crrev.com/50e9dfa629b4df812e8c42ef5c0ad8237b36f333/build/android/buildbot/bb_host_steps.py

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/acfeec2bde1a7bef76690827dbfc46a9760d91d3

commit acfeec2bde1a7bef76690827dbfc46a9760d91d3
Author: thakis <thakis@chromium.org>
Date: Wed Jul 13 16:44:23 2016

recipes: Stop passing --build-tool=ninja to compile.py

compile.py has been asserting --build-tool is either ninja or not passed since
end of June (https://codereview.chromium.org/2089333003), so we know that
nothing ever passes anything not ninja.  Since the flag carries no information,
stop passing it.

BUG=622768

Review-Url: https://codereview.chromium.org/2152453003

[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipe_modules/chromium/api.py
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipe_modules/chromium/example.expected/basic_out_dir.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipe_modules/chromium_android/example.expected/basic_builder_basic.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipe_modules/chromium_android/example.expected/coverage_builder_basic.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipe_modules/chromium_android/example.expected/gerrit_refs.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipe_modules/chromium_android/example.expected/gerrit_try_builder_basic.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipe_modules/chromium_android/example.expected/java_method_count_builder_basic.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipe_modules/chromium_android/example.expected/restart_usb_builder_basic.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipe_modules/cronet/example.expected/gn_test.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipe_modules/cronet/example.expected/local_test.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipe_modules/pgo/example.expected/full_chromium_pgo_test_Test_builder.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipe_modules/pgo/example.expected/full_chromium_pgo_test_Test_builder_benchmark_failure.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipe_modules/syzygy/example.expected/full_master_client_syzygy_Syzygy_Coverage.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipe_modules/syzygy/example.expected/full_master_client_syzygy_Syzygy_Debug.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipe_modules/syzygy/example.expected/full_master_client_syzygy_Syzygy_Official.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/android/builder.expected/chromium_android_Android_x64_Builder__dbg__fail_check_licenses.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/android/builder.expected/full_chromium_android_Android_MIPS_Builder__dbg_.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/android/builder.expected/full_chromium_android_Android_x64_Builder__dbg_.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/android/builder.expected/full_chromium_android_Android_x86_Builder__dbg_.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/android/builder.expected/full_chromium_perf_Android_Builder.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/android/builder.expected/full_chromium_perf_Android_arm64_Builder.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/android/builder.expected/full_client_v8_fyi_Android_Builder.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/android/builder.expected/full_tryserver_chromium_perf_android_arm64_perf_bisect_builder.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/android/builder.expected/full_tryserver_chromium_perf_android_perf_bisect_builder.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_fyi_perf_bisect.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_nexus5X_perf_bisect.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_nexus5_perf_bisect.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_nexus6_perf_bisect.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_nexus7_perf_bisect.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_nexus9_perf_bisect.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_one_perf_bisect.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_s5_perf_bisect.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_s5_perf_cq.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_webview_arm64_aosp_perf_bisect.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_fyi_perf_bisect.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_nexus5X_perf_bisect.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_nexus5_perf_bisect.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_nexus6_perf_bisect.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_nexus7_perf_bisect.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_nexus9_perf_bisect.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_one_perf_bisect.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_s5_perf_bisect.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_s5_perf_cq.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_webview_arm64_aosp_perf_bisect.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/bisection/desktop_bisect.expected/perf_cq_no_benchmark_to_run.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/bisection/desktop_bisect.expected/perf_cq_run_benchmark.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64___ignition_fail.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64___ignition_pass.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64__dbg__fail.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64__dbg__pass.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64_fail.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64_pass.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Mac_fail.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Mac_pass.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Win_fail.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Win_pass.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/blink_downstream.expected/minimal_pass_continues.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/blink_downstream.expected/too_many_failures_for_retcode.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/blink_downstream.expected/webkit_tests_interrupted.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/blink_downstream.expected/webkit_tests_unexpected_error.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/build_dynamic_isolated_script_test.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/build_dynamic_isolated_script_test_compile_target_overriden.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/build_dynamic_swarmed_isolated_script_test.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/build_dynamic_swarmed_isolated_script_test_compile_target_overidden.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/chromium_webkit_crash.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/chromium_webkit_revision_chromium.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/chromium_webkit_revision_webkit.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/chromium_webkit_warnings.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/dynamic_android_cloud_gtest.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/dynamic_gtest_memory_builder.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/dynamic_gtest_on_builder.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/dynamic_instrumentation_cloud_test.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/dynamic_instrumentation_nodefault_build.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/dynamic_swarmed_gn_instrumentation_test.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/dynamic_swarmed_gtest.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/dynamic_swarmed_gtest_override_compile_targets.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/ensure_goma_fail.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_bot_update_always_on_coverage_clobber.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_Android.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_Linux_x64.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_Mac.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_Win.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_Win_x64.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_android_Android_MIPS_Builder__dbg_.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_android_Android_N5X_Swarm_Builder.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_android_Android_Swarm_Builder.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_android_Android_arm64_Builder__dbg_.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_android_Android_arm_Builder__dbg_.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_android_Android_x64_Builder__dbg_.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_android_Android_x86_Builder__dbg_.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_chrome_Google_Chrome_ChromeOS.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_chrome_Google_Chrome_Linux_x64.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_chrome_Google_Chrome_Mac.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_chrome_Google_Chrome_Win.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_ChromiumOS_amd64_generic_Compile.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_ChromiumOS_daisy_Compile.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_ChromiumOS_x86_generic_Compile.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_Linux_ChromiumOS_Builder.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_Linux_ChromiumOS_Builder__dbg_.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_Linux_ChromiumOS_Full.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_Linux_ChromiumOS_GN.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_Linux_ChromiumOS_GN__dbg_.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_Linux_ChromiumOS_Ozone_Builder.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Android_Asan_Builder_Tests__dbg_.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Android_Builder__dbg_.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Android_Cloud_Tests.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Browser_Side_Navigation_Linux.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CFI_Linux.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CFI_Linux_CF.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CFI_Linux_ToT.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Linux32_Goma_Canary__clobber_.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Linux_Goma_Canary.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Linux_Goma_Canary__clobber_.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Linux_Precise_Goma_LinkTest.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Mac_10_10_MacViews.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Mac_10_11.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Mac_10_11_Force_Mac_Toolchain.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Mac_10_9_Goma_Canary.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Mac_10_9_Goma_Canary__clobber_.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Mac_10_9_Goma_Canary__dbg_.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Mac_10_9_Goma_Canary__dbg__clobber_.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTAndroidASan.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTLinux.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTLinuxASan.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTLinuxLLD.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTLinuxUBSanVptr.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTLinux__dbg_.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTMac.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTMacASan.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTMac__dbg_.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin64.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin64_dbg_.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin64_dll_.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin_dbg_.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin_dll_.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWin7Goma.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWin7Goma_clbr_.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWin7Goma_dbg_.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWin7Goma_dll_.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinAsan.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinAsanCov.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinAsan_dll_.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang64.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang64_dbg_.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang64_dll_.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClangGoma.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClangLLD.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClangLLD64.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang_dbg_.json
[modify] https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3/scripts/slave/rec

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/e7d61f2c495b38f77d31168d16aae44849195b88

commit e7d61f2c495b38f77d31168d16aae44849195b88
Author: thakis <thakis@chromium.org>
Date: Wed Jul 13 17:11:41 2016

Add a bug link to a TODO

BUG=622768

Review-Url: https://codereview.chromium.org/2143003004

[modify] https://crrev.com/e7d61f2c495b38f77d31168d16aae44849195b88/scripts/slave/compile.py

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/bdf6acee3d9ded7d2efdce92eaaa6e19c0d1cf40

commit bdf6acee3d9ded7d2efdce92eaaa6e19c0d1cf40
Author: recipe-roller <recipe-roller@chromium.org>
Date: Wed Jul 13 17:17:19 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/22a19f89867ce30a57f3543dca613621a46343f0 Add cronet_perf_test_apk to the list of compile targets for cronet (xunjieli@chromium.org)
  https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3 recipes: Stop passing --build-tool=ninja to compile.py (thakis@chromium.org)
  https://crrev.com/853bfd83aba00955eccd0cf39eec2e14141384c7 recipes: Remove unused compile_py.solution and compile_py.xcode_project. (thakis@chromium.org)

R=jbudorick@chromium.org,thakis@chromium.org,xunjieli@chromium.org
BUG= 625282 ,none,622768

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2143943003

[modify] https://crrev.com/bdf6acee3d9ded7d2efdce92eaaa6e19c0d1cf40/infra/config/recipes.cfg

Project Member

Comment 6 by bugdroid1@chromium.org, Jul 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/bdf6acee3d9ded7d2efdce92eaaa6e19c0d1cf40

commit bdf6acee3d9ded7d2efdce92eaaa6e19c0d1cf40
Author: recipe-roller <recipe-roller@chromium.org>
Date: Wed Jul 13 17:17:19 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/22a19f89867ce30a57f3543dca613621a46343f0 Add cronet_perf_test_apk to the list of compile targets for cronet (xunjieli@chromium.org)
  https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3 recipes: Stop passing --build-tool=ninja to compile.py (thakis@chromium.org)
  https://crrev.com/853bfd83aba00955eccd0cf39eec2e14141384c7 recipes: Remove unused compile_py.solution and compile_py.xcode_project. (thakis@chromium.org)

R=jbudorick@chromium.org,thakis@chromium.org,xunjieli@chromium.org
BUG= 625282 ,none,622768

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2143943003

[modify] https://crrev.com/bdf6acee3d9ded7d2efdce92eaaa6e19c0d1cf40/infra/config/recipes.cfg

Project Member

Comment 7 by bugdroid1@chromium.org, Jul 13 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/d87ed8e620bda91d3d1ef41c109b90621ebdcef0

commit d87ed8e620bda91d3d1ef41c109b90621ebdcef0
Author: recipe-roller <recipe-roller@chromium.org>
Date: Wed Jul 13 17:33:27 2016

Project Member

Comment 8 by bugdroid1@chromium.org, Jul 13 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/2b764906cf4bbc0a529a668a70139886d6e13953

commit 2b764906cf4bbc0a529a668a70139886d6e13953
Author: recipe-roller <recipe-roller@chromium.org>
Date: Wed Jul 13 17:38:48 2016

Project Member

Comment 9 by bugdroid1@chromium.org, Jul 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/78e40933779d30f9d1d47efdaf3d336373d23c73

commit 78e40933779d30f9d1d47efdaf3d336373d23c73
Author: recipe-roller <recipe-roller@chromium.org>
Date: Wed Jul 13 17:45:41 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3 recipes: Stop passing --build-tool=ninja to compile.py (thakis@chromium.org)
  https://crrev.com/853bfd83aba00955eccd0cf39eec2e14141384c7 recipes: Remove unused compile_py.solution and compile_py.xcode_project. (thakis@chromium.org)
  https://crrev.com/e7d61f2c495b38f77d31168d16aae44849195b88 Add a bug link to a TODO (thakis@chromium.org)
  https://crrev.com/613c3cddd1e718a2ef76554ece74cfbf16ae5ca6 Add a new Cronet bot configuration to run tests with ASAN (xunjieli@chromium.org)

R=thakis@chromium.org,xunjieli@chromium.org
BUG= 567323 ,622768,none

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2144023002

[modify] https://crrev.com/78e40933779d30f9d1d47efdaf3d336373d23c73/infra/config/recipes.cfg

►

Issue 622768 link

Issue metadata

Remove --build-tool param from compile.py

Issue description

Comment 1 by bugdroid1@chromium.org, Jun 23 2016

Comment 1 Deleted

Comment 2 by bugdroid1@chromium.org, Jun 24 2016

Comment 2 Deleted

Comment 3 by bugdroid1@chromium.org, Jul 13 2016

Comment 3 Deleted

Comment 4 by bugdroid1@chromium.org, Jul 13 2016

Comment 4 Deleted

Comment 5 by bugdroid1@chromium.org, Jul 13 2016

Comment 5 Deleted

Comment 6 by bugdroid1@chromium.org, Jul 13 2016

Comment 6 Deleted

Comment 7 by bugdroid1@chromium.org, Jul 13 2016

Comment 7 Deleted

Comment 8 by bugdroid1@chromium.org, Jul 13 2016

Comment 8 Deleted

Comment 9 by bugdroid1@chromium.org, Jul 13 2016

Comment 9 Deleted

Sign in to add a comment