New issue
Advanced search Search tips

Issue 622765 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Verify gn_all on iOS (i.e., that GN builds everything GYP builds)

Project Member Reported by dpranke@chromium.org, Jun 23 2016

Issue description

Verify gn_all on iOS (i.e., that GN builds everything GYP builds)

We need to go through the GYP and GN builds and verify that we're actually building everything we should be.

In particular, we need to address

https://cs.chromium.org/chromium/src/BUILD.gn?rcl=0&l=482

and see what's still missing.

From:

https://bugs.chromium.org/p/chromium/issues/detail?id=431177#c74 by thakis@:

I did a build of all targets with both gn and gyp. These test binaries are missing in a gn build:

$ comm -2 -3 <(cd out/Release && ls *tests) <(cd out/gn && ls *tests)
...

https://bugs.chromium.org/p/chromium/issues/detail?id=431177#c74 by thakis@:

I then compared if the tests in the binaries built in both builds are identical like so:

comm -1 -2 <(cd out/Release && ls *tests) <(cd out/gn && ls *tests) > tests.txt
for t in $(cat tests.txt); do echo $t; diff <(out/gn/$t --gtest_list_tests | grep -v GetParam | sort) <(out/Release/$t --gtest_list_tests | grep -v GetParam | sort); done

 
Labels: -M-53
Blocking: -459705 -621680
Labels: -Proj-GN-Migration Proj-GN-Migration-Ship
I'm going to try tracking ship-blocking things via the label "Proj-GN-Migration-Ship" (instead of Proj-GN-Migration) as suggested w/ a conversation w/ laforge@ and the monorail folks a while ago.

Querying for "Proj=GN-Migration%" should still return bugs for both labels, and this will allow us to filter out rollup things more easily, so that we can use blocking just for things that are truly blocking other bugs.
Is this done?
Status: Fixed (was: Available)
It better be ...

Sign in to add a comment