Issue metadata
Sign in to add a comment
|
Restoring a single tab from "History > Recently Closed > X Tabs" does not work
Reported by
he...@danieldelaney.net,
Jun 23 2016
|
||||||||||||||||||||
Issue descriptionChrome Version: 51.0.2704.103 (Official Build) (64-bit) To reproduce: (1) Open two tabs and visit different URLs in each. (2) Close the browser window. (3) Attempt to re-open a single tab from History > Recently Closed > 2 Tabs. Expected result: The tab is restored. Actual result: No effect. Video evidence attached. (Gfycat mirror: https://gfycat.com/GoldenLimpingDeviltasmanian)
,
Jun 30 2016
This is actually a cross-platform problem.
,
Jul 3 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3d931371a8a5f795e7b9a559489b50a877f3db8a commit 3d931371a8a5f795e7b9a559489b50a877f3db8a Author: blundell <blundell@chromium.org> Date: Wed Jul 20 09:15:32 2016 Fix restore of a tab from a recently-closed browser window https://codereview.chromium.org/1343833002 introduced a manually-written copy constructor and assignment operator for TabRestoreService::Tab in order to accommodate a new member that had to be copied via an explicit Clone() method. However, that CL failed to copy the fields of TabRestoreService::Entry, the base class of TabRestoreService::Tab. This problem resulted in not being able to restore individual tabs from a recently-closed browser window because the ID of the tab got lost in a copy somewhere along the way and didn't match the one of the menu item that the user clicked on. This CL also adds a browsertest that fails without this change. BUG= 622752 TEST=On a desktop system, open 2 tabs, close the browser window and open a new browser window. In that new window go into the "Recently Closed" section of the History menu, find the entry that says "2 Tabs", and click on one of the individual tabs. That tab should be restored in the new window. Review-Url: https://codereview.chromium.org/2114673002 Cr-Commit-Position: refs/heads/master@{#406523} [modify] https://crrev.com/3d931371a8a5f795e7b9a559489b50a877f3db8a/chrome/browser/sessions/tab_restore_browsertest.cc [modify] https://crrev.com/3d931371a8a5f795e7b9a559489b50a877f3db8a/components/components_tests.gyp [modify] https://crrev.com/3d931371a8a5f795e7b9a559489b50a877f3db8a/components/sessions/BUILD.gn [modify] https://crrev.com/3d931371a8a5f795e7b9a559489b50a877f3db8a/components/sessions/core/tab_restore_service.cc [add] https://crrev.com/3d931371a8a5f795e7b9a559489b50a877f3db8a/components/sessions/core/tab_restore_service_unittest.cc
,
Jul 20 2016
,
Jul 22 2016
Hah, I'm currently working on a refactor of this code and pushed out a quick fix earlier in the week (see issue 585564 ). I'll cc you on the CL :).
,
Jul 22 2016
,
Jul 22 2016
The issue was actually cross-platform; it looks like your quick fix was Mac-specific. You should be able to revert that quick fix now I think, as the CL I pushed fixed the underlying problem that you correctly identified. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by ranjitkan@chromium.org
, Jun 27 2016Labels: -Type-Bug -Pri-3 has-Bisect M-53 OS-Mac Pri-2 Type-Bug-Regression
Owner: blundell@chromium.org
Status: Assigned (was: Unconfirmed)