New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 622725 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Jul 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

87.5%-94.4% regression in cc_perftests at 401378:401411

Project Member Reported by mustaq@chromium.org, Jun 23 2016

Issue description

See the link to graphs below.
 
Project Member

Comment 2 by sheriffbot@chromium.org, Jul 3 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Mustaq, can you follow up on this?

From the instructions (https://chromium.googlesource.com/chromium/src/+/master/tools/perf/docs/perf_regression_sheriffing.md):
"After your shift, please try to follow up on the bugs you filed weekly. Kick off new bisects if the previous ones failed, and if the bisect picks a likely culprit follow up to ensure the CL author addresses the problem. If you are certain that a specific CL caused a performance regression, and the author does not have an immediate plan to address the problem, please revert the CL."

Comment 4 by mustaq@chromium.org, Jul 11 2016

Kicked off another bisect. The original ones failed silently.
Owner: wkorman@chromium.org
Practical range for this is 401406-401408. Only one change there touches cc and it's 2e7928680f0af8a1d5486499f41c58124b95f601. wkorman, can you investigate.
Cc: vmp...@chromium.org
My change only affects a fake used in tests. We now use an alpha rather than two separate rects to force a fake raster source to be considered non-solid-color. The alpha must be more expensive.

If my change is in fact the culprit then AFAIK we should rebaseline and consider these the new normal. But I realize the perf graph is markedly different, from 30K runs/s to 2.5K runs/s so we should make sure the new world is still ok re: testing what that test is aiming to test.

https://chromeperf.appspot.com/report?sid=2e80a90590a63b410f79e1b2deb353d584ef9ae071457851034a08a65a5eec04&rev=401435

+vmpstr@ for his input.

Comment 7 by vmp...@chromium.org, Jul 26 2016

Cc: -vmp...@chromium.org wkorman@chromium.org
Owner: vmp...@chromium.org
I'll take a look to see why there is such a significant impact. Off the top of my head, there shouldn't be much difference between the two ways we specify that the raster source is not solid. That is unless one of the approaches erroneously was being detected as solid.

The change here is indeed only to the tests, so generally I would agree with wkorman that this is likely a WontFix, but I'll update when I have a better understanding of what's going on. 

Comment 8 by vmp...@chromium.org, Jul 26 2016

Status: WontFix (was: Assigned)
This was indeed an issue with the test that wkorman fixed. The problem was that previously, the tiles were detected as solid and as a result, we ended up marking them solid on the first run and subsequent runs were lighting fast since no more tiles needed to be processed. This was not the intent of the test.

Sign in to add a comment