New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 622720 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Android MediaRouter only (left Chro...
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Measure whether muted videos that started playing with play() become visible at some point

Project Member Reported by mlamouri@chromium.org, Jun 23 2016

Issue description

^
 
Components: Blink>Media>Video
Owner: zqzh...@chromium.org
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 3 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Pri-3 -M-54 -MovedFrom-53 M-53 Pri-2
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 11 2016

Labels: -M-53 M-54
Status: Fixed (was: Available)
Not merging to M53 since the patch is a bit large for merge.
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a8c92c522776d84bfeff56855205fbb5771b785

commit 4a8c92c522776d84bfeff56855205fbb5771b785
Author: dbeam <dbeam@chromium.org>
Date: Tue Jul 12 21:30:56 2016

Revert "Measure whether muted videos that started playing with play() become visible at some point"

This reverts commit 9d961d0a083fe4ebd8c200c31b87d75e4727958b.

Seems to be leaking, broke WebKit Leak bots here:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/builds/20963

BUG= 627539 , 622720 

TBR=zqzhang@chromium.org
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true

Review-Url: https://codereview.chromium.org/2141093003
Cr-Commit-Position: refs/heads/master@{#404836}

[modify] https://crrev.com/4a8c92c522776d84bfeff56855205fbb5771b785/third_party/WebKit/LayoutTests/media/video-autoplay-experiment-modes-expected.txt
[modify] https://crrev.com/4a8c92c522776d84bfeff56855205fbb5771b785/third_party/WebKit/Source/core/core.gypi
[delete] https://crrev.com/e2276c4abe46c25480470c3f6d6b968671a8a4df/third_party/WebKit/Source/core/html/AutoplayUmaHelper.cpp
[delete] https://crrev.com/e2276c4abe46c25480470c3f6d6b968671a8a4df/third_party/WebKit/Source/core/html/AutoplayUmaHelper.h
[modify] https://crrev.com/4a8c92c522776d84bfeff56855205fbb5771b785/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
[modify] https://crrev.com/4a8c92c522776d84bfeff56855205fbb5771b785/third_party/WebKit/Source/core/html/HTMLMediaElement.h
[modify] https://crrev.com/4a8c92c522776d84bfeff56855205fbb5771b785/third_party/WebKit/Source/core/html/OWNERS
[modify] https://crrev.com/4a8c92c522776d84bfeff56855205fbb5771b785/tools/metrics/histograms/histograms.xml

Project Member

Comment 8 by bugdroid1@chromium.org, Aug 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/061ad2b0252c21ba4adf49f6cd8ba63db1e89b02

commit 061ad2b0252c21ba4adf49f6cd8ba63db1e89b02
Author: zqzhang <zqzhang@chromium.org>
Date: Tue Aug 16 11:34:19 2016

Reland: Measure whether muted videos that started playing with play() become visible at some point

Relanding previous CL (https://codereview.chromium.org/2108403003)
after the memory leak and crash have been fixed.

Marking as TBR since the previous CL has already been reviewed.

BUG= 622720 
TBR=haraken@chromium.org,mlamouri@chromium.org,rkaplow@chromium.org

Review-Url: https://codereview.chromium.org/2154303002
Cr-Commit-Position: refs/heads/master@{#412214}

[modify] https://crrev.com/061ad2b0252c21ba4adf49f6cd8ba63db1e89b02/third_party/WebKit/LayoutTests/media/video-autoplay-experiment-modes-expected.txt
[modify] https://crrev.com/061ad2b0252c21ba4adf49f6cd8ba63db1e89b02/third_party/WebKit/Source/core/core.gypi
[add] https://crrev.com/061ad2b0252c21ba4adf49f6cd8ba63db1e89b02/third_party/WebKit/Source/core/html/AutoplayUmaHelper.cpp
[add] https://crrev.com/061ad2b0252c21ba4adf49f6cd8ba63db1e89b02/third_party/WebKit/Source/core/html/AutoplayUmaHelper.h
[modify] https://crrev.com/061ad2b0252c21ba4adf49f6cd8ba63db1e89b02/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
[modify] https://crrev.com/061ad2b0252c21ba4adf49f6cd8ba63db1e89b02/third_party/WebKit/Source/core/html/HTMLMediaElement.h
[modify] https://crrev.com/061ad2b0252c21ba4adf49f6cd8ba63db1e89b02/third_party/WebKit/Source/core/html/OWNERS
[modify] https://crrev.com/061ad2b0252c21ba4adf49f6cd8ba63db1e89b02/tools/metrics/histograms/histograms.xml

Sign in to add a comment