New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 622713 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Measure how often autoplay settings is turned off

Project Member Reported by mlamouri@chromium.org, Jun 23 2016

Issue description

It's a metric for success for the feature.
 
Components: Blink>Media>Video
Owner: finnur@chromium.org
Status: Assigned (was: Available)
FWIW, there is a ContentSettings.Exceptions.autoplay that records how many autoplay exceptions are set. We want to know about users disabling the feature (contrary to simply set exceptions). I'm not sure if there are common pattern in settings to deal with this.
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd376092ad7bf6a2764f31eeee556f4b2c77584b

commit bd376092ad7bf6a2764f31eeee556f4b2c77584b
Author: finnur <finnur@chromium.org>
Date: Fri Jul 01 17:07:19 2016

Site Settings Android: Add UMA for measuring the Autoplay
default setting value at profile startup.

BUG= 622713 

Review-Url: https://codereview.chromium.org/2115873002
Cr-Commit-Position: refs/heads/master@{#403473}

[modify] https://crrev.com/bd376092ad7bf6a2764f31eeee556f4b2c77584b/components/content_settings/core/browser/content_settings_default_provider.cc
[modify] https://crrev.com/bd376092ad7bf6a2764f31eeee556f4b2c77584b/tools/metrics/histograms/histograms.xml

Labels: Merge-Request-53
This needs to be merged to the M53 branch, which I understand was cut yesterday.

Comment 5 by dimu@google.com, Jul 1 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 4 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/59710b712a89a124805fe7725d57743569795aae

commit 59710b712a89a124805fe7725d57743569795aae
Author: Finnur Thorarinsson <finnur@chromium.org>
Date: Mon Jul 04 10:25:14 2016

Site Settings Android: Add UMA for measuring the Autoplay default setting value at profile startup.

BUG= 622713 

Review-Url: https://codereview.chromium.org/2115873002
Cr-Commit-Position: refs/heads/master@{#403473}
(cherry picked from commit bd376092ad7bf6a2764f31eeee556f4b2c77584b)

Review URL: https://codereview.chromium.org/2115423002 .

Cr-Commit-Position: refs/branch-heads/2785@{#10}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/59710b712a89a124805fe7725d57743569795aae/components/content_settings/core/browser/content_settings_default_provider.cc
[modify] https://crrev.com/59710b712a89a124805fe7725d57743569795aae/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Assigned)
Thank you Finnur! :)

Sign in to add a comment