New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 622707 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 622708



Sign in to add a comment

Support serializing gpu::GPUInfo in mojo

Project Member Reported by penghuang@chromium.org, Jun 23 2016

Issue description

Right now, we have GpuInfo defined as mojo struct in components/mus/public/interfaces/gpu.mojom, it only contains part of gpu::GPUInfo. To fully support HW rendering, we need support serializing gpu::GPUInfo in mojo.
 
Blocking: 622708
Owner: staraz@chromium.org
Status: Assigned (was: Available)
(Assigning to Alex since he said he is working on this now)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6bc355f1871c4c85f56ae4a05370b6c44fcab1f5

commit 6bc355f1871c4c85f56ae4a05370b6c44fcab1f5
Author: staraz <staraz@chromium.org>
Date: Wed Jul 13 20:18:17 2016

Added typemap for gpu.mojom.GpuInfo, gpu.mojom.GpuDevice and gpu.mojom.CollectInfoResult

BUG= 622707 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2133833002
Cr-Commit-Position: refs/heads/master@{#405266}

[modify] https://crrev.com/6bc355f1871c4c85f56ae4a05370b6c44fcab1f5/gpu/ipc/common/BUILD.gn
[modify] https://crrev.com/6bc355f1871c4c85f56ae4a05370b6c44fcab1f5/gpu/ipc/common/OWNERS
[add] https://crrev.com/6bc355f1871c4c85f56ae4a05370b6c44fcab1f5/gpu/ipc/common/gpu_info.mojom
[add] https://crrev.com/6bc355f1871c4c85f56ae4a05370b6c44fcab1f5/gpu/ipc/common/gpu_info.typemap
[add] https://crrev.com/6bc355f1871c4c85f56ae4a05370b6c44fcab1f5/gpu/ipc/common/gpu_info_struct_traits.cc
[add] https://crrev.com/6bc355f1871c4c85f56ae4a05370b6c44fcab1f5/gpu/ipc/common/gpu_info_struct_traits.h
[modify] https://crrev.com/6bc355f1871c4c85f56ae4a05370b6c44fcab1f5/gpu/ipc/common/mailbox.typemap
[modify] https://crrev.com/6bc355f1871c4c85f56ae4a05370b6c44fcab1f5/gpu/ipc/common/struct_traits_unittest.cc
[modify] https://crrev.com/6bc355f1871c4c85f56ae4a05370b6c44fcab1f5/gpu/ipc/common/traits_test_service.mojom
[modify] https://crrev.com/6bc355f1871c4c85f56ae4a05370b6c44fcab1f5/gpu/ipc/common/typemaps.gni

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8fb38080e8833699973f510470fe2664e4fd3df6

commit 8fb38080e8833699973f510470fe2664e4fd3df6
Author: staraz <staraz@chromium.org>
Date: Mon Jul 25 18:48:21 2016

base::Version constructor from std::vector<uint32_t>

The new constructor is to be used by Version's mojom struct and its type mapping.

BUG= 622707 

Review-Url: https://codereview.chromium.org/2163033002
Cr-Commit-Position: refs/heads/master@{#407529}

[modify] https://crrev.com/8fb38080e8833699973f510470fe2664e4fd3df6/base/version.cc
[modify] https://crrev.com/8fb38080e8833699973f510470fe2664e4fd3df6/base/version.h
[modify] https://crrev.com/8fb38080e8833699973f510470fe2664e4fd3df6/base/version_unittest.cc

Comment 5 by sadrul@chromium.org, Jul 26 2016

Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a639771dc3abd8e8030757c3c04e26a37c86348c

commit a639771dc3abd8e8030757c3c04e26a37c86348c
Author: staraz <staraz@chromium.org>
Date: Fri Aug 05 14:10:34 2016

Struct traits used by GpuInfo

This CL contains struct traits of the structs used by gpu::GPUInfo

BUG= 622707 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2147693002
Cr-Commit-Position: refs/heads/master@{#410053}

[modify] https://crrev.com/a639771dc3abd8e8030757c3c04e26a37c86348c/gpu/ipc/common/BUILD.gn
[add] https://crrev.com/a639771dc3abd8e8030757c3c04e26a37c86348c/gpu/ipc/common/dx_diag_node.mojom
[add] https://crrev.com/a639771dc3abd8e8030757c3c04e26a37c86348c/gpu/ipc/common/dx_diag_node.typemap
[add] https://crrev.com/a639771dc3abd8e8030757c3c04e26a37c86348c/gpu/ipc/common/dx_diag_node_struct_traits.cc
[add] https://crrev.com/a639771dc3abd8e8030757c3c04e26a37c86348c/gpu/ipc/common/dx_diag_node_struct_traits.h
[modify] https://crrev.com/a639771dc3abd8e8030757c3c04e26a37c86348c/gpu/ipc/common/gpu_info.mojom
[modify] https://crrev.com/a639771dc3abd8e8030757c3c04e26a37c86348c/gpu/ipc/common/gpu_info.typemap
[modify] https://crrev.com/a639771dc3abd8e8030757c3c04e26a37c86348c/gpu/ipc/common/gpu_info_struct_traits.cc
[modify] https://crrev.com/a639771dc3abd8e8030757c3c04e26a37c86348c/gpu/ipc/common/gpu_info_struct_traits.h
[modify] https://crrev.com/a639771dc3abd8e8030757c3c04e26a37c86348c/gpu/ipc/common/struct_traits_unittest.cc
[modify] https://crrev.com/a639771dc3abd8e8030757c3c04e26a37c86348c/gpu/ipc/common/traits_test_service.mojom
[modify] https://crrev.com/a639771dc3abd8e8030757c3c04e26a37c86348c/gpu/ipc/common/typemaps.gni
[modify] https://crrev.com/a639771dc3abd8e8030757c3c04e26a37c86348c/mojo/common/BUILD.gn
[modify] https://crrev.com/a639771dc3abd8e8030757c3c04e26a37c86348c/mojo/common/OWNERS
[modify] https://crrev.com/a639771dc3abd8e8030757c3c04e26a37c86348c/mojo/common/common_custom_types.mojom
[modify] https://crrev.com/a639771dc3abd8e8030757c3c04e26a37c86348c/mojo/common/common_custom_types.typemap
[add] https://crrev.com/a639771dc3abd8e8030757c3c04e26a37c86348c/mojo/common/common_custom_types_struct_traits.cc
[add] https://crrev.com/a639771dc3abd8e8030757c3c04e26a37c86348c/mojo/common/common_custom_types_struct_traits.h
[add] https://crrev.com/a639771dc3abd8e8030757c3c04e26a37c86348c/mojo/common/common_custom_types_struct_traits_unittest.cc
[add] https://crrev.com/a639771dc3abd8e8030757c3c04e26a37c86348c/mojo/common/struct_traits_unittest.cc
[add] https://crrev.com/a639771dc3abd8e8030757c3c04e26a37c86348c/mojo/common/traits_test_service.mojom

Project Member

Comment 7 by bugdroid1@chromium.org, Aug 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf90a8e911d48f0055bd2676460f48b8c669324b

commit bf90a8e911d48f0055bd2676460f48b8c669324b
Author: staraz <staraz@chromium.org>
Date: Thu Aug 11 20:22:14 2016

GpuInfo mojom struct and struct traits and unit test

The mojom struct corresponds to gpu::GPUInfo. Serializing GPUInfo in mojo
enables full support for hardware rendering.

BUG= 622707 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2220093002
Cr-Commit-Position: refs/heads/master@{#411413}

[modify] https://crrev.com/bf90a8e911d48f0055bd2676460f48b8c669324b/gpu/ipc/common/BUILD.gn
[modify] https://crrev.com/bf90a8e911d48f0055bd2676460f48b8c669324b/gpu/ipc/common/dx_diag_node.mojom
[modify] https://crrev.com/bf90a8e911d48f0055bd2676460f48b8c669324b/gpu/ipc/common/gpu_info.mojom
[modify] https://crrev.com/bf90a8e911d48f0055bd2676460f48b8c669324b/gpu/ipc/common/gpu_info.typemap
[modify] https://crrev.com/bf90a8e911d48f0055bd2676460f48b8c669324b/gpu/ipc/common/gpu_info_struct_traits.cc
[modify] https://crrev.com/bf90a8e911d48f0055bd2676460f48b8c669324b/gpu/ipc/common/gpu_info_struct_traits.h
[modify] https://crrev.com/bf90a8e911d48f0055bd2676460f48b8c669324b/gpu/ipc/common/struct_traits_unittest.cc
[modify] https://crrev.com/bf90a8e911d48f0055bd2676460f48b8c669324b/gpu/ipc/common/traits_test_service.mojom

Comment 8 by staraz@chromium.org, Aug 11 2016

Status: Fixed (was: Started)
Components: -MUS Internals>Services>WindowService

Sign in to add a comment