New issue
Advanced search Search tips

Issue 622672 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

virtual/threaded/fast/scroll-behavior/overflow-interrupted-scroll.html is flaky on WebKit Mac10.11 (dbg)

Project Member Reported by hbos@chromium.org, Jun 23 2016

Issue description

Comment 1 by hbos@chromium.org, Jun 23 2016

Owner: ajuma@chromium.org
Status: Assigned (was: Available)
Can you please take a look, ajuma? I see you haven't touched it in ages but it started flaking recently and I didn't find the culprit.

Comment 2 by hbos@chromium.org, Jun 23 2016

Cc: flackr@chromium.org dgozman@chromium.org
+CC other sheriffs FYI.

Comment 3 by hbos@chromium.org, Jun 23 2016

NOTE: I disabled the test in https://codereview.chromium.org/2091753002/, it didn't show up in the bug.

Comment 4 by hbos@chromium.org, Jun 23 2016

This still flakes, I think

virtual/threaded/fast/scroll-behavior/overflow-interrupted-scroll.html

is not the same as

fast/scroll-behavior/overflow-interrupted-scroll.html

which I had assumed. Do you know?

Comment 5 by ajuma@chromium.org, Jun 23 2016

Yes, these are not equivalent. To disable the virtual version you need to add virtual/threaded/fast/scroll-behavior/overflow-interrupted-scroll.html to TestExpectations rather than adding fast/scroll-behavior/overflow-interrupted-scroll.html

Comment 6 by hbos@chromium.org, Jun 23 2016

Summary: virtual/threaded/fast/scroll-behavior/overflow-interrupted-scroll.html is flaky on WebKit Mac10.11 (dbg) (was: fast/scroll-behavior/overflow-interrupted-scroll.html is flaky on WebKit Mac10.11 (dbg))
OK I'll change it to virtual/threaded/ since that was what was flaking.

Comment 7 by hbos@chromium.org, Jun 23 2016

Being addressed here: https://codereview.chromium.org/2090363002
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc0dcdcf4d9fc890d5b96db5856ec0037dce3b43

commit bc0dcdcf4d9fc890d5b96db5856ec0037dce3b43
Author: hbos <hbos@chromium.org>
Date: Thu Jun 23 15:07:03 2016

virtual/threaded/fast/scroll-behavior/overflow-interrupted-scroll.html is flaky on WebKit Mac10.11 (dbg).

Added it as a flake to TestExpectations.
This is a correction to a previous CL (https://codereview.chromium.org/2091753002/), where

fast/scroll-behavior/overflow-interrupted-scroll.html

was added instead of

virtual/threaded/fast/scroll-behavior/overflow-interrupted-scroll.html

TBR=ajuma@chromium.org
NOPRESUBMIT=True
NOTRY=True
BUG= 622672 

Review-Url: https://codereview.chromium.org/2090363002
Cr-Commit-Position: refs/heads/master@{#401607}

[modify] https://crrev.com/bc0dcdcf4d9fc890d5b96db5856ec0037dce3b43/third_party/WebKit/LayoutTests/TestExpectations

Comment 9 by hbos@chromium.org, Jun 27 2016

Status: Verified (was: Assigned)
Project Member

Comment 10 by bugdroid1@chromium.org, Sep 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8c31351d42c9ed62418ac6fcab6acea74b094db

commit c8c31351d42c9ed62418ac6fcab6acea74b094db
Author: qyearsley <qyearsley@chromium.org>
Date: Thu Sep 29 22:23:14 2016

Run update-test-expectations after making it less conservative.

The change http://crrev.com/2380173002 would make update-test-expectations delete lines as long as the test appears non-flaky on all configurations with existing builders, ignoring configurations with no existing builders.

This CL is the result of running that script -- so for any lines deleted here, that script has found that in recent runs for all existing matching continuous builders, the test appears non-flaky, i.e. passing all recent runs.

BUG=248938, 339597 , 352405 , 364250 , 381730 , 404597 , 410949 , 419696 , 473718 , 498539 , 518915 , 520169 , 520180 , 520183 ,520187, 520191 , 520612 , 520614 , 521084 ,521086, 521090 , 521093 , 521094 , 521099 , 521107 , 521855 , 522645 , 542541 , 552532 , 587593 , 587779 ,588103, 594595 , 594672 , 597572 , 613510 , 614197 , 622672 , 629711 

Review-Url: https://codereview.chromium.org/2384573002
Cr-Commit-Position: refs/heads/master@{#421954}

[modify] https://crrev.com/c8c31351d42c9ed62418ac6fcab6acea74b094db/third_party/WebKit/LayoutTests/TestExpectations

Sign in to add a comment