Improve look and feel of chrome://flags |
|||||||||||
Issue descriptionchrome://flags could do with an overhaul: + Use shared CSS for webUI (chrome://resources/css/chrome_shared.css) + Make it mobile friendly. Make it touch friendly. + Make it more accessible, grey on grey text has poor contrast. For inspiration, I did build a prototype of a suggested update a couple of years ago, pre material.
,
Jun 23 2016
,
Jun 25 2016
Thanks for filing, Edward. I'm taking into account your bullet points, but just to be clear: are you looking for this redesign to be material, or be similar to your screenshot, or whatever I come up with?
,
Jun 25 2016
I would aim to be material. However this isn't a normal user facing page so would be open to your suggestions for what would work best. Probably be good to do static designs / HTML mocks first so that they can be refined before implementation.
,
Aug 11 2016
,
Aug 11 2017
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 7 2017
,
Sep 26 2017
Designs prototyped, ready for implementation.
,
Oct 2 2017
I still don't know if "Default" refers to "Enable" or "Disable" when it's the selected option in a preference. Why can't "Default" be killed off?
,
Oct 2 2017
#11, the default can differ between different users or profiles for testing purposes. We're not supposed to know what the default state is. Flags aren't meant to be preferences or advanced settings.
,
Oct 5 2017
Are we intentionally killing the WARNING text at the top? I don't see it in the new screenshots. What's the reason for removing it?
,
Oct 5 2017
,
Oct 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e08766ea8fe70ad0fcd967351063e6b3b32f82b0 commit e08766ea8fe70ad0fcd967351063e6b3b32f82b0 Author: Edward Jung <edwardjung@chromium.org> Date: Fri Oct 06 16:05:31 2017 Redesign of the chrome://flags page + Improve responsive design for mobile devices. Larger touch targets. + Simplified the warning blurb. + Add in page flag search for better filtering, significantly better search experience on mobile devices. + Add tab interface separating Available and Unavailable flags. + Uses updated modern colour scheme and typography. + Display Chrome version number on the page. Bug: 622640 Change-Id: I55f1739ab12c4d28c7ace0f234fabb30577abf21 Reviewed-on: https://chromium-review.googlesource.com/693256 Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Edward Jung <edwardjung@chromium.org> Cr-Commit-Position: refs/heads/master@{#507085} [modify] https://crrev.com/e08766ea8fe70ad0fcd967351063e6b3b32f82b0/chrome/browser/ui/webui/flags_ui.cc [modify] https://crrev.com/e08766ea8fe70ad0fcd967351063e6b3b32f82b0/components/flags_ui/flags_ui_constants.cc [modify] https://crrev.com/e08766ea8fe70ad0fcd967351063e6b3b32f82b0/components/flags_ui/flags_ui_constants.h [modify] https://crrev.com/e08766ea8fe70ad0fcd967351063e6b3b32f82b0/components/flags_ui/resources/flags.css [modify] https://crrev.com/e08766ea8fe70ad0fcd967351063e6b3b32f82b0/components/flags_ui/resources/flags.html [modify] https://crrev.com/e08766ea8fe70ad0fcd967351063e6b3b32f82b0/components/flags_ui/resources/flags.js [modify] https://crrev.com/e08766ea8fe70ad0fcd967351063e6b3b32f82b0/components/flags_ui_strings.grdp [modify] https://crrev.com/e08766ea8fe70ad0fcd967351063e6b3b32f82b0/ios/chrome/browser/ui/webui/flags_ui.cc
,
Oct 7 2017
Hi edwardjung@: Today I noticed the change in Canary - great - thank you! There is one issue that I noticed: Before changing a flag you can maximize the description by double-clicking on the it. But after changing the flag, the "Restart Now" bar appears at the bottom of the page and now it is no longer possible to maximize the description. A screencast is attached. Should I file a separate report for it? Thanks for looking into it.
,
Oct 9 2017
Thanks for the comments. I'll file a bug for the text clicking. The focus ring is normal behaviour for buttons which all those shown in the screenshot are.
,
Oct 9 2017
There are a few bugs being reported which I'm looking at now.
,
Oct 9 2017
Hello edwardjung@: Thank you for your feedback. Regarding the focus ring: Normally these kind of focus rings appear only, when you use the Tab-Key and not clicking on them. This must also be extra activated in the Chrome settings (Web Content section: Pressing TAB on a webpage...). Thanks for looking into it.
,
Oct 9 2017
The buttons which have custom styling result in the focus outline being enabled when activated (See the restart button on pre redesigned flags page for example). I'll look to making the outlines more attractive but they are important for accessibility.
,
Oct 9 2017
Great, thank you very much.
,
Dec 17
The First Meaningful Paint for the new chrome://flags is quite slow for such a simple page - 500ms on a 4GHz i7 PC. Profiling shows most of the time is spent in jstemplate library that creates all the DOM nodes at once. I wonder should I file a new bug in case someone gets interested in enhancing the performance? Could be as trivial as throttling the job in say 50ms chunks via setTimeout. Or as advanced as switching to Polymer with its lazy load lists.
,
Dec 17
I agree with the above. Flags needs another overhaul. best, f On Mon, Dec 17, 2018, 6:45 AM wox… via monorail < monorail+v2.652523902@chromium.org wrote:
,
Dec 17
Re:#23 feel free to file a bug for performance issues, there might be takers. |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by edwardjung@chromium.org
, Jun 23 2016386 KB
386 KB View Download