New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 622630 link

Starred by 1 user
Status: WontFix
Owner:
ellyjo...@chromium.org
Closed: Apr 2017
Cc:
nyerramilli@chromium.org
ellyjo...@chromium.org
█ tkonch...@chromium.org
mac-bugs-priority@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression
Team-Security-UX



Sign in to add a comment

Regression: Focus issue is observed on permission bubble

Project Member Reported by tkonch...@chromium.org, Jun 23 2016 
Version: 53.0.2777.0 (Official Build)cd5f1c60daa702f416e719edf13358571e0bf084-refs/heads/master@{#401526} 64 bit
OS:  MAC (10.10.4,10.11.4)

Pre-condition: Toolkit-Views WebUI-style Browser Dialogs.

Steps to reproduce the issue

1. Launch chrome and navigate to https://adrifelt.github.io/demos/bubble-demo.html
2. Click on permission bubble and the press Tab key such that dotted border reaches first ‘Allow’ button.
3. Mouse click on Second ‘Allow button and observe dotted border.

Actual: 1. Dotted focus stay on first Allow button after step 3.
        2. Dotted focus for close button is not proper.

Expected: 1. Dotted focus should transfer to second ‘Allow’ button after step 3.
          2. Dotted focus should be proper for close button.

This is regression issue, broken in ‘M 53’ and will soon update the bisect info.

Comment 1 by dmascare...@etouch.net, Jun 23 2016

Labels: hasbisect
Owner: est...@chromium.org
Status: Assigned (was: Untriaged)
Narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/c97cdcc4d02b8823790798f2e812d933a4045a03..aa60ff405b46620f283640f1f6571670b65d8fe8?pretty=fuller&n=1000

Suspecting: r401301 ?

Good build: 53.0.2776.0
Bad build: 53.0.2777.0

Note: Issue is not seen on Windows and Linux OS.
Actual.mov
4.8 MB Download

Comment 2 by est...@chromium.org, Jun 23 2016

Owner: ellyjo...@chromium.org
are you sure that's the correct regression range? I only touched the website settings popup, not the permissions bubble.
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 3 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by ellyjo...@chromium.org, Sep 6 2016

Cc: ellyjo...@chromium.org
Owner: karandeepb@chromium.org
Over to karandeepb@

karandeepb@, I think this was introduced by your https://codereview.chromium.org/1963563002 - MenuButton is a subclass of CustomButton, but it *should* take focus when clicked, I think, so we need to do something to allow that.

Comment 5 by karandeepb@chromium.org, Sep 6 2016 

I explicitly removed buttons taking focus on clicks in https://chromiumcodereview.appspot.com/1994463002/. I wasn't able to find any Cocoa button which took focus on click. The behavior is the same on the equivalent Cocoa permission bubble. 

Also the report says "Dotted focus for close button is not proper." but it looks OK to me.

Comment 6 by karandeepb@chromium.org, Sep 7 2016

Owner: ellyjo...@chromium.org
Hey Elly, I think the button not getting focus on click is a Non-issue and matches Cocoa behavior. Can you check the other issue reported, "Dotted focus for close button is not proper."? Assigning to you for further comment.

Comment 7 by raymes@chromium.org, Nov 3 2016

Components: -UI>Browser>Permissions UI>Browser>Permissions>Prompts

Comment 8 by ellyjo...@chromium.org, Apr 24 2017

Status: WontFix (was: Assigned)
Yes, Cocoa menu buttons do not behave that way and MacViews buttons should not either.
►

Sign in to add a comment