New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 622620 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Stop syncing preferences on Android if they are not meant to be synced

Project Member Reported by vabr@chromium.org, Jun 23 2016

Issue description

Chrome will start sync prefs on mobile.

For some of them it is not desired, examples include:
 * prefs::kPasswordManagerSavingEnabled, which would collide with kCredentialsEnableService
 * browser.enable_spellchecking
 * browser.show_home_button
 * default_search_provider.synced_guid
 * homepage
 * homepage_is_newtabpage

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9352a69e3b8cbf81e7a46dd9ea07a7e05ece94ee

commit 9352a69e3b8cbf81e7a46dd9ea07a7e05ece94ee
Author: melandory <melandory@chromium.org>
Date: Thu Jun 23 13:02:31 2016

Don't sync pref which controls the password manager to mobile.

Chrome will start sync prefs on mobile. It's not desired behaviour for the password manager pref, because it collides with the prefs reconciliation.

BUG= 622620 

Review-Url: https://codereview.chromium.org/2084033002
Cr-Commit-Position: refs/heads/master@{#401592}

[modify] https://crrev.com/9352a69e3b8cbf81e7a46dd9ea07a7e05ece94ee/components/password_manager/core/browser/password_manager.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/760a953ded79dfb404f381eba21efd9c7d10b6e6

commit 760a953ded79dfb404f381eba21efd9c7d10b6e6
Author: melandory <melandory@chromium.org>
Date: Thu Jun 23 22:04:05 2016

Don't sync kEnableContinuousSpellcheck  to mobile platforms.

Chrome will start sync prefs on mobile. It's not desired behaviour for the kEnableContinuousSpellcheck.

BUG= 622620 

Review-Url: https://codereview.chromium.org/2086663006
Cr-Commit-Position: refs/heads/master@{#401740}

[modify] https://crrev.com/760a953ded79dfb404f381eba21efd9c7d10b6e6/chrome/browser/spellchecker/spellcheck_factory.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/533065686d0cb35523939ae71d45173aa208a558

commit 533065686d0cb35523939ae71d45173aa208a558
Author: melandory <melandory@chromium.org>
Date: Mon Jun 27 15:52:37 2016

Don't sync homepage pref to mobile platforms.

Chrome will start sync prefs on mobile. For homepage it is not desired.

BUG= 622620 

Review-Url: https://codereview.chromium.org/2092073003
Cr-Commit-Position: refs/heads/master@{#402190}

[modify] https://crrev.com/533065686d0cb35523939ae71d45173aa208a558/chrome/browser/profiles/profile_impl.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/336b04cf3eab38e8663988ff2f2286a57e3d341b

commit 336b04cf3eab38e8663988ff2f2286a57e3d341b
Author: melandory <melandory@chromium.org>
Date: Tue Jun 28 10:04:52 2016

Don't sync browser.show_home_button and homepage_is_newtabpageto mobile platforms.

Chrome will start sync prefs on mobile. For browser.show_home_button it and for homepage_is_newtabpage it is not desired.

BUG= 622620 

Review-Url: https://codereview.chromium.org/2086143004
Cr-Commit-Position: refs/heads/master@{#402436}

[modify] https://crrev.com/336b04cf3eab38e8663988ff2f2286a57e3d341b/chrome/browser/ui/browser_ui_prefs.cc

Comment 5 by groby@chromium.org, Jun 28 2016

Cc: zea@chromium.org
+zea@ for sync question: I might have misunderstood what you said, but didn't you mention that anything that is not SYNCABLE_PRIORITY_PREF is not synced to mobile devices anyways?

Comment 6 by zea@chromium.org, Jun 28 2016

Correct. Normal pref sync is not enabled on mobile devices (yet), but it's something we're hoping to turn on soon. The work melandory@ is doing is necessary before we turn it on (we want to make sure all the SYNCABLE_PREF's are appropriate to sync on mobile).

Comment 7 by groby@chromium.org, Jun 28 2016

Ah, gotcha - thank you for the explanation!
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a54a050049d669a1c55517159d2c5b0fa95e7e4b

commit a54a050049d669a1c55517159d2c5b0fa95e7e4b
Author: melandory <melandory@chromium.org>
Date: Fri Jul 01 11:31:57 2016

Don't sync session.startup_urls to mobile platforms.

Chrome will start sync prefs to mobile. It's not desired behaviour for
the session.startup_urls and the session.urls_to_restore_on_startup prefs.

BUG= 622620 

Review-Url: https://codereview.chromium.org/2114923002
Cr-Commit-Position: refs/heads/master@{#403436}

[modify] https://crrev.com/a54a050049d669a1c55517159d2c5b0fa95e7e4b/chrome/browser/prefs/session_startup_pref.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Jul 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1105ec72a099911751513d4a38a6c9ae3840158

commit c1105ec72a099911751513d4a38a6c9ae3840158
Author: melandory <melandory@chromium.org>
Date: Fri Jul 01 12:11:53 2016

Don't sync default_search_provider.synced_guid to mobile.

Chrome will start sync prefs on mobile. It's not desired behaviour for
the default_search_provider.synced_guid pref.

BUG= 622620 
TBR=stevet@chromium.org

Review-Url: https://codereview.chromium.org/2091763002
Cr-Commit-Position: refs/heads/master@{#403439}

[modify] https://crrev.com/c1105ec72a099911751513d4a38a6c9ae3840158/components/search_engines/template_url_service.cc

Comment 10 by fi...@chromium.org, Jul 29 2016

Labels: zine-triaged
Status: Fixed (was: Started)
Components: -UI>Browser>Spellcheck UI>Browser>Language>Spellcheck

Sign in to add a comment