New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 622619 link

Starred by 1 user
Status: Assigned
Owner:
danno@chromium.org
Cc:
bmeu...@chromium.org
ishell@chromium.org
█ epertoso@chromium.org
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

test-gap-resolver/FuzzResolver fails on mips

Project Member Reported by ishell@chromium.org, Jun 23 2016 
If you run

out/mipsel.optdebug/cctest --predictable test-gap-resolver/FuzzResolver

then this happens:

#
# Fatal error in ../src/compiler/instruction.cc, line 257
# Check failed: !(kind == REGISTER && (rep == MachineRepresentation::kFloat64)) || (DoubleRegister::from_code(index).IsAllocatable()).
#

==== C stack trace ===============================

 1: V8_Fatal
 2: 0x8c0e08a
 3: v8::internal::compiler::ParallelMoveCreator::CreateRandomOperand(bool, v8::internal::MachineRepresentation)
 4: v8::internal::compiler::ParallelMoveCreator::Create(int)
 5: 0x8462cab
 6: CcTest::Run()
 7: main
 8: __libc_start_main
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 24 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/5cda2db7d3ca954733a82cb203d46d2f6f73484c

commit 5cda2db7d3ca954733a82cb203d46d2f6f73484c
Author: balazs.kilvady <balazs.kilvady@imgtec.com>
Date: Fri Jun 24 08:23:52 2016

Fix '[tests] Don't test moves between different reps in test-gap-resolver.cc'

Port fc59eb8a7a1eb45edd2d4ff7910e66fab3093030

Original commit message:
Moves between operands with different representations shouldn't happen,
so don't test them. This makes it easier to modify canonicalization to
differentiate between floating point types, which is needed to support
floating point register aliasing for ARM and MIPS.

This change also expands tests to include explicit FP moves (both register and stack slot).

LOG=N
BUG= v8:4124 
BUG=chromium:622619

Review-Url: https://codereview.chromium.org/2090993002
Cr-Commit-Position: refs/heads/master@{#37241}

[modify] https://crrev.com/5cda2db7d3ca954733a82cb203d46d2f6f73484c/src/arm/assembler-arm.h
[modify] https://crrev.com/5cda2db7d3ca954733a82cb203d46d2f6f73484c/src/arm64/assembler-arm64.h
[modify] https://crrev.com/5cda2db7d3ca954733a82cb203d46d2f6f73484c/src/assembler.cc
[modify] https://crrev.com/5cda2db7d3ca954733a82cb203d46d2f6f73484c/src/assembler.h
[modify] https://crrev.com/5cda2db7d3ca954733a82cb203d46d2f6f73484c/src/compiler/instruction.cc
[modify] https://crrev.com/5cda2db7d3ca954733a82cb203d46d2f6f73484c/src/ia32/assembler-ia32.h
[modify] https://crrev.com/5cda2db7d3ca954733a82cb203d46d2f6f73484c/src/mips/assembler-mips.h
[modify] https://crrev.com/5cda2db7d3ca954733a82cb203d46d2f6f73484c/src/mips64/assembler-mips64.h
[modify] https://crrev.com/5cda2db7d3ca954733a82cb203d46d2f6f73484c/src/ppc/assembler-ppc.h
[modify] https://crrev.com/5cda2db7d3ca954733a82cb203d46d2f6f73484c/src/s390/assembler-s390.h
[modify] https://crrev.com/5cda2db7d3ca954733a82cb203d46d2f6f73484c/src/x64/assembler-x64.h
[modify] https://crrev.com/5cda2db7d3ca954733a82cb203d46d2f6f73484c/src/x87/assembler-x87.h
[modify] https://crrev.com/5cda2db7d3ca954733a82cb203d46d2f6f73484c/test/cctest/compiler/test-gap-resolver.cc
►

Sign in to add a comment