New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 622607 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression : Profile icon is missing in 'Edit person' overlay in chrome://md-settings page

Reported by mni...@etouch.net, Jun 23 2016

Issue description

Chrome Version: 53.0.2776.0 07025e9df358bb0249550d6124b9817333421fc0-refs/heads/master@{#401299} (32/64 bit)
OS: Windows (7,8,8.1,10),Mac OS X(10.10.5, 10.11.4)
 
What steps will reproduce the problem?
1. Launch Chrome and navigate to chrome://md-settings
2. Click on 'Person 1' avatar icon and observe

Actual : Profile icon is not seen in 'Edit person' overlay
Expected : Profile icon should be seen in 'Edit person' overlay

This is a regression issue, broken in 'M-53', below is manual bisect and Narrow bisect info :
Good Build: 53.0.2774.3
Bad Build: 53.0.2776.0

Narrow Bisect:
https://chromium.googlesource.com/chromium/src/+log/b050f1526d5016e5e70d72682f4bb64b5ec2d50f..c065affd6e62ba7e1658ace14f0d1186f789f503?pretty=fuller&n=10000

Suspecting: r401041 from Narrow bisect

@mahmadi : Could you please help to reassign if your change is not the cause for this change.

 
Actual_video.mp4
187 KB View Download
Expected_video.mp4
182 KB View Download
Actual_screenshot.png
253 KB View Download
Expected_screenshot.png
252 KB View Download
Cc: tommycli@chromium.org
tommycli@ IIRC the silhouette profile avatar is deprecated. that's why I remove it from the list of available avatars in crrev.com/401041
what do you think the behavior should be in this scenario?
Yeah if the silhouette profile avatar should be gone, then we have no problem.

Just confirm with ewald that it should be gone. If that's true, mark it WONTFIX and let the TEs know that the new expected behavior does not include the silhouette icon.
Cc: ew...@chromium.org
Thanks tommy. ewald@ could you confirm if the silhouette profile avatar is deprecated? I received a feedback on one of my early MD User Manager CLs that it is deprecated. Thank you.

Comment 4 by ew...@chromium.org, Jun 27 2016

Cc: bettes@chromium.org
Adding in Alan. Alan - is the profile avatar deprecated?

Just to make sure I understand - when you're signed in, you'll be able to select your profile picture, right? This is just for the signed-out case?
correct. When you're signed in your profile picture is the first option to select.

Comment 6 by ew...@chromium.org, Jun 27 2016

Status: WontFix (was: Assigned)
OK yeah, I also recall us saying that the signed-out profile avatar was deprecated.

I'll mark this as WontFix for now and say that's the expected behavior (i.e. this is WAI). I'll double check with Alan when he's back, and if it's different than that, I'll post back here.

Comment 7 by ew...@chromium.org, Jul 11 2016

Confirmed with Alan. When you're signed out, we don't need to show this avatar.

Sign in to add a comment