New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 622590 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature



Sign in to add a comment

Add a notification warning the user when low on disk space

Project Member Reported by dspaid@chromium.org, Jun 23 2016

Issue description

Feature description:
When the user is low on disk space on cryptohome a notification should be displayed which allows them to open the storage manager to clear up free space.

Eng owner: dspaid@chromium.org
Product owner: mitsuji@chromium.org

Design doc: https://docs.google.com/document/d/1ru0oRMlT24xUWv3XB_gaGhS-_wm8dNgD6whhBcyoTcQ/edit#heading=h.hpn72ii2h7qu

Are you planning on experimenting before launch? No
Any new strings? Yes
Any implications for Google webservices (i.e. sync, translate)? No
Binary size? No
Do the existing perf tests exercise all aspects of your new feature(s)?

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ab0d85b5bea7fca2637d10e7ccc1fa8cb0e3a94

commit 3ab0d85b5bea7fca2637d10e7ccc1fa8cb0e3a94
Author: dspaid <dspaid@chromium.org>
Date: Fri Jun 24 06:08:52 2016

Add strings and notifier ID for low disk.

Actual notifications using these strings will be added in a followup CL.

BUG= 622590 

Review-Url: https://codereview.chromium.org/2090913002
Cr-Commit-Position: refs/heads/master@{#401825}

[modify] https://crrev.com/3ab0d85b5bea7fca2637d10e7ccc1fa8cb0e3a94/ash/common/system/system_notifier.cc
[modify] https://crrev.com/3ab0d85b5bea7fca2637d10e7ccc1fa8cb0e3a94/ash/common/system/system_notifier.h
[modify] https://crrev.com/3ab0d85b5bea7fca2637d10e7ccc1fa8cb0e3a94/chrome/app/chromeos_strings.grdp

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e12692bad71ee7926296f703be5ab204e21d235f

commit e12692bad71ee7926296f703be5ab204e21d235f
Author: dspaid <dspaid@chromium.org>
Date: Thu Jun 30 02:15:30 2016

Roll src/third_party/cros_system_api/ 11d79edee..2cf87623e (2 commits).

https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/11d79edeefbd..2cf87623ebe6

$ git log 11d79edee..2cf87623e --date=short --no-merges --format='%ad %ae %s'
2016-06-29 fukino cryptohome: Add constants and protobuf for GetAccountDiskUsage.
2016-06-28 dspaid Add name of new signal handler to dbus constants.

BUG= 622590 

Review-Url: https://codereview.chromium.org/2107363002
Cr-Commit-Position: refs/heads/master@{#403064}

[modify] https://crrev.com/e12692bad71ee7926296f703be5ab204e21d235f/DEPS

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43c9801f43e8feb9bd5a58436ead31deae5382c4

commit 43c9801f43e8feb9bd5a58436ead31deae5382c4
Author: dspaid <dspaid@chromium.org>
Date: Thu Jun 30 04:48:39 2016

Add signal handler for low disk notification

Cryptohome polls every minute for remaining disk space and emits a DBus
signal if the remaining space is lower than a given threshold.  This
patch adds a handler that will call the specified callback when this
signal is received.

BUG= 622590 
TEST=unit tests in following CL to implement notifications

Review-Url: https://codereview.chromium.org/2101853002
Cr-Commit-Position: refs/heads/master@{#403089}

[modify] https://crrev.com/43c9801f43e8feb9bd5a58436ead31deae5382c4/chromeos/dbus/cryptohome_client.cc
[modify] https://crrev.com/43c9801f43e8feb9bd5a58436ead31deae5382c4/chromeos/dbus/cryptohome_client.h
[modify] https://crrev.com/43c9801f43e8feb9bd5a58436ead31deae5382c4/chromeos/dbus/fake_cryptohome_client.cc
[modify] https://crrev.com/43c9801f43e8feb9bd5a58436ead31deae5382c4/chromeos/dbus/fake_cryptohome_client.h
[modify] https://crrev.com/43c9801f43e8feb9bd5a58436ead31deae5382c4/chromeos/dbus/mock_cryptohome_client.h

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d43514effc1b793aef2794815bc6f5b5e2811db

commit 0d43514effc1b793aef2794815bc6f5b5e2811db
Author: dspaid <dspaid@chromium.org>
Date: Thu Jun 30 23:39:17 2016

Show notifications on low disk space.

The notifications are shown at most once per hour, or whenever the severity of the notification changes.

BUG= 622590 
TEST=./out/Release/unit_tests --gtest_filter=LowDiskNotificationTest.*

Review-Url: https://codereview.chromium.org/2082363004
Cr-Commit-Position: refs/heads/master@{#403342}

[modify] https://crrev.com/0d43514effc1b793aef2794815bc6f5b5e2811db/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
[modify] https://crrev.com/0d43514effc1b793aef2794815bc6f5b5e2811db/chrome/browser/chromeos/chrome_browser_main_chromeos.h
[add] https://crrev.com/0d43514effc1b793aef2794815bc6f5b5e2811db/chrome/browser/chromeos/ui/low_disk_notification.cc
[add] https://crrev.com/0d43514effc1b793aef2794815bc6f5b5e2811db/chrome/browser/chromeos/ui/low_disk_notification.h
[add] https://crrev.com/0d43514effc1b793aef2794815bc6f5b5e2811db/chrome/browser/chromeos/ui/low_disk_notification_unittest.cc
[modify] https://crrev.com/0d43514effc1b793aef2794815bc6f5b5e2811db/chrome/chrome_browser_chromeos.gypi
[modify] https://crrev.com/0d43514effc1b793aef2794815bc6f5b5e2811db/chrome/chrome_tests_unit.gypi
[add] https://crrev.com/0d43514effc1b793aef2794815bc6f5b5e2811db/ui/chromeos/resources/default_100_percent/filesystem/button_storage_manager.png
[add] https://crrev.com/0d43514effc1b793aef2794815bc6f5b5e2811db/ui/chromeos/resources/default_100_percent/filesystem/notification_disk_space_critical.png
[add] https://crrev.com/0d43514effc1b793aef2794815bc6f5b5e2811db/ui/chromeos/resources/default_100_percent/filesystem/notification_disk_space_low.png
[add] https://crrev.com/0d43514effc1b793aef2794815bc6f5b5e2811db/ui/chromeos/resources/default_200_percent/filesystem/button_storage_manager.png
[add] https://crrev.com/0d43514effc1b793aef2794815bc6f5b5e2811db/ui/chromeos/resources/default_200_percent/filesystem/notification_disk_space_critical.png
[add] https://crrev.com/0d43514effc1b793aef2794815bc6f5b5e2811db/ui/chromeos/resources/default_200_percent/filesystem/notification_disk_space_low.png
[modify] https://crrev.com/0d43514effc1b793aef2794815bc6f5b5e2811db/ui/chromeos/resources/ui_chromeos_resources.grd

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df142fd2cb934119b9dadc9971cd6b52dd85f249

commit df142fd2cb934119b9dadc9971cd6b52dd85f249
Author: dspaid <dspaid@chromium.org>
Date: Fri Jul 01 07:15:15 2016

Properly initialize last_notification_severity_.

BUG= 622590 
TEST=./out/Debug/unit_tests --gtest_filter=LowDiskNotificationTest.*

Review-Url: https://codereview.chromium.org/2115793002
Cr-Commit-Position: refs/heads/master@{#403420}

[modify] https://crrev.com/df142fd2cb934119b9dadc9971cd6b52dd85f249/chrome/browser/chromeos/ui/low_disk_notification.h

Comment 6 by dspaid@chromium.org, Jul 13 2016

Status: Fixed (was: Assigned)
Labels: VerifyIn-54

Comment 8 by dchan@chromium.org, Oct 7 2016

Labels: VerifyIn-55
Status: Verified (was: Fixed)

Sign in to add a comment