New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 622585 link

Starred by 4 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Support Shadow DOM in fullscreen API

Project Member Reported by kochi@chromium.org, Jun 23 2016

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Jul 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d79429192ab8246c6f88a79b076e7ff1ddcba45c

commit d79429192ab8246c6f88a79b076e7ff1ddcba45c
Author: kochi <kochi@chromium.org>
Date: Fri Jul 15 09:13:50 2016

Rename adjustPointerLockElement

The function (adjustPointerLockElement) will also be used by fullscreenElement,
rename the function not specific to pointer lock.

No functional change.

BUG=622585

Review-Url: https://codereview.chromium.org/2146013003
Cr-Commit-Position: refs/heads/master@{#405729}

[modify] https://crrev.com/d79429192ab8246c6f88a79b076e7ff1ddcba45c/third_party/WebKit/Source/core/dom/DocumentOrShadowRoot.h
[modify] https://crrev.com/d79429192ab8246c6f88a79b076e7ff1ddcba45c/third_party/WebKit/Source/core/dom/TreeScope.cpp
[modify] https://crrev.com/d79429192ab8246c6f88a79b076e7ff1ddcba45c/third_party/WebKit/Source/core/dom/TreeScope.h

Comment 2 by kochi@chromium.org, Oct 7 2016

Cc: foolip@chromium.org kochi@chromium.org
 Issue 627614  has been merged into this issue.

Comment 3 by hayato@chromium.org, Oct 12 2016

Components: -Blink>WebComponents Blink>DOM>ShadowDOM
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7025a706a1b4d382e5241905904ca803808000f9

commit 7025a706a1b4d382e5241905904ca803808000f9
Author: kochi <kochi@chromium.org>
Date: Wed Oct 26 06:33:02 2016

Move Document.fullscreenElement to DocumentOrShadowRoot

This change aims to prevent nodes in shadow tree from
leaking via global API (document.fullscreenElement).

The change is discussed at:
https://github.com/w3c/webcomponents/issues/180

And spec is being updated at:
https://github.com/whatwg/fullscreen/pull/54

BUG=622585
TBR=ericwilligers@chromium.org for tools/metrics/histograms/histograms.xml

Review-Url: https://codereview.chromium.org/2340263003
Cr-Commit-Position: refs/heads/master@{#427610}

[add] https://crrev.com/7025a706a1b4d382e5241905904ca803808000f9/third_party/WebKit/LayoutTests/shadow-dom/fullscreen-element-in-shadow-complex.html
[add] https://crrev.com/7025a706a1b4d382e5241905904ca803808000f9/third_party/WebKit/LayoutTests/shadow-dom/fullscreen-element-in-shadow-simple.html
[add] https://crrev.com/7025a706a1b4d382e5241905904ca803808000f9/third_party/WebKit/LayoutTests/shadow-dom/v0/fullscreen-element-in-v0.html
[modify] https://crrev.com/7025a706a1b4d382e5241905904ca803808000f9/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/7025a706a1b4d382e5241905904ca803808000f9/third_party/WebKit/Source/core/dom/DocumentFullscreen.cpp
[modify] https://crrev.com/7025a706a1b4d382e5241905904ca803808000f9/third_party/WebKit/Source/core/dom/DocumentFullscreen.idl
[modify] https://crrev.com/7025a706a1b4d382e5241905904ca803808000f9/third_party/WebKit/Source/core/dom/DocumentOrShadowRoot.h
[modify] https://crrev.com/7025a706a1b4d382e5241905904ca803808000f9/third_party/WebKit/Source/core/dom/DocumentOrShadowRoot.idl
[modify] https://crrev.com/7025a706a1b4d382e5241905904ca803808000f9/third_party/WebKit/Source/core/dom/Fullscreen.cpp
[modify] https://crrev.com/7025a706a1b4d382e5241905904ca803808000f9/third_party/WebKit/Source/core/dom/Fullscreen.h
[modify] https://crrev.com/7025a706a1b4d382e5241905904ca803808000f9/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/7025a706a1b4d382e5241905904ca803808000f9/tools/metrics/histograms/histograms.xml

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf66552a405a371dc840136ba216d67f82802883

commit bf66552a405a371dc840136ba216d67f82802883
Author: kochi <kochi@chromium.org>
Date: Wed Nov 02 04:16:11 2016

Add tests while FullscreenUnprefixed flag is turned off.

Adds test cases for fullscreenElement retargeting, when
FullscreenUnprefixed runtime enabled flag is turned off.

Document.webkitFullscreenElement and .webkitCurrentFullScreenElement
changes behavior depending on the flag, and when it is turned off,
it keeps compatibility with the current behavior (not retargeting
fullscreen element when it is in a shadow tree).

The behavior when the flag is on is already covered in the previous
CL: https://codereview.chromium.org/2340263003/

BUG=622585

Review-Url: https://codereview.chromium.org/2446323003
Cr-Commit-Position: refs/heads/master@{#429206}

[modify] https://crrev.com/bf66552a405a371dc840136ba216d67f82802883/third_party/WebKit/LayoutTests/shadow-dom/fullscreen-element-in-shadow-complex.html
[modify] https://crrev.com/bf66552a405a371dc840136ba216d67f82802883/third_party/WebKit/LayoutTests/shadow-dom/fullscreen-element-in-shadow-simple.html
[modify] https://crrev.com/bf66552a405a371dc840136ba216d67f82802883/third_party/WebKit/LayoutTests/shadow-dom/v0/fullscreen-element-in-v0.html
[modify] https://crrev.com/bf66552a405a371dc840136ba216d67f82802883/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in

Comment 6 by kochi@chromium.org, Nov 18 2016

Summary: Support Shadow DOM in fullscreen API (was: Split fullscreenElement to Document/ShadowRoot)
Until fullscreen API is unprefixed, this bug cannot be really closed,
but to comply with the change made to the fullscreen API spec:
https://github.com/whatwg/fullscreen/commit/611a4046b0569752d198093e36edd736851877a6
remaining task is to change :fullscreen (with prefix, :-webkit-full-screen)
matching.

I plan to fix the pseudo class matching in this quarter (but with low-priority).

Comment 7 by kochi@chromium.org, Apr 12 2017

Status: Assigned (was: Started)
I haven't been active on this recently: if someone can take this, feel free
to do it.
Components: -Blink>DOM>ShadowDOM Blink>Fullscreen
Owner: ----
Status: Available (was: Assigned)
Unassigning myself

Sign in to add a comment