New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 622582 link

Starred by 2 users
Status: Fixed
Owner:
█ tsergeant@chromium.org
Not on Chrome
Closed: Jun 2016
Cc:
nyerramilli@chromium.org
█ tkonch...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Blank list is seen after clicking on bookmarks icon present on PDF page.

Reported by rk...@etouch.net, Jun 23 2016 
Chrome Version: 53.0.2776.0 07025e9df358bb0249550d6124b9817333421fc0-refs/heads/master@{#401299} (32/64 bit)
OS: Windows (7,8,8.1,10),Mac OS X(10.10.5, 10.11.4)
 
URL:https://www.ets.org/Media/Tests/GRE/pdf/gre_research_validity_data.pdf

What steps will reproduce the problem?
(1) Launch chrome, navigate to above url
(2) Click on 'Bookmarks' icon and observe.

Blank list is seen after clicking on bookmarks icon.

Blank list should not seen after clicking on bookmarks icon or the bookmarks icon should not seen.

This is a regression issue, broken in 'M-53', will soon update the info

Comment 1 by rk...@etouch.net, Jun 23 2016

Labels: hasbisect OS-Linux
Owner: tsergeant@chromium.org
Status: Assigned (was: Unconfirmed)
Good Build: 53.0.2774.3
Bad Build: 53.0.2776.0

Narrow Bisect:
https://chromium.googlesource.com/chromium/src/+log/0bed5daf713fa68745ba91035e90af00beb6082f..9882d61c25bbebe84e82a7d559cae6f0807a4775?pretty=fuller&n=100

Suspecting: r401161
Actual_PDF.mp4
328 KB View Download

Comment 2 by tkonch...@chromium.org, Jun 23 2016

Labels: ReleaseBlock-Stable
Adding RB label as this is a recent regression
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/930c85305671e9a24a3ac4eb9ea1de0cd447f961

commit 930c85305671e9a24a3ac4eb9ea1de0cd447f961
Author: tsergeant <tsergeant@chromium.org>
Date: Mon Jun 27 04:57:46 2016

PDF: Fix layout issues caused by removing iron-flex-layout

In crrev.com/401161, the deprecated version of iron-flex-layout was removed
from the PDF viewer. This version added styles to the page which were seen
by every element, regardless of whether they expected it. Thus, removing
it from the page had some unexpected side effects:

* The bookmarks menu in the toolbar would always show, due to a change
  in how [hidden] was defined.
* The password field was laid out incorrectly due to not importing the
  new version of iron-flex-layout correctly.

This CL fixes both of these regressions.

BUG= 622582 , 621736 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2092023002
Cr-Commit-Position: refs/heads/master@{#402112}

[modify] https://crrev.com/930c85305671e9a24a3ac4eb9ea1de0cd447f961/chrome/browser/resources/pdf/elements/viewer-password-screen/viewer-password-screen.html
[modify] https://crrev.com/930c85305671e9a24a3ac4eb9ea1de0cd447f961/chrome/browser/resources/pdf/elements/viewer-toolbar-dropdown/viewer-toolbar-dropdown.css

Comment 4 by tsergeant@chromium.org, Jun 27 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment