New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 622575 link

Starred by 1 user
Status: Fixed
Owner:
█ e...@chromium.org
Last visit > 30 days ago
Closed: Jul 2016
Cc:
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

NativeWidgetMus not triggering WidgetObserver::OnWidgetBoundsChanged for a window move with no resize

Project Member Reported by tapted@chromium.org, Jun 23 2016 
Chrome Version       : 53.0.2774.3

I tried updating WidgetObserverTest.WidgetBoundsChangedNative with a test case for this, and it failed in views_mus_unittests

Adding before widget->CloseNow(), the code

  // Move, but don't change the size.
  widget->SetBounds(gfx::Rect(110, 110, 170, 100));
  EXPECT_TRUE(widget_bounds_changed());
  reset();

in https://codereview.chromium.org/2083923002

does

https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/249495


WidgetObserverTest.WidgetBoundsChangedNative (run #1):
[ RUN      ] WidgetObserverTest.WidgetBoundsChangedNative
[0620/222146:ERROR:gpu_state.cc(66)] Collect basic graphics info failed!
Xlib:  extension "RANDR" missing on display ":9".
../../ui/views/widget/widget_unittest.cc:928: Failure
Value of: widget_bounds_changed()
  Actual: false
Expected: true
[  FAILED  ] WidgetObserverTest.WidgetBoundsChangedNative (263 ms)

Comment 1 by e...@chromium.org, Jun 29 2016

Owner: e...@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 8 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ed29f61913c5429093ff5b22667a15c425914b4

commit 6ed29f61913c5429093ff5b22667a15c425914b4
Author: erg <erg@chromium.org>
Date: Fri Jul 08 20:10:40 2016

mus: Use the new drag API to implement tab dragging in chrome.

BUG= 622900 , 622575 

Review-Url: https://codereview.chromium.org/2099513003
Cr-Commit-Position: refs/heads/master@{#404473}

[modify] https://crrev.com/6ed29f61913c5429093ff5b22667a15c425914b4/ash/mus/frame/move_event_handler.cc
[modify] https://crrev.com/6ed29f61913c5429093ff5b22667a15c425914b4/ash/mus/frame/move_event_handler.h
[modify] https://crrev.com/6ed29f61913c5429093ff5b22667a15c425914b4/ash/mus/window_manager.cc
[modify] https://crrev.com/6ed29f61913c5429093ff5b22667a15c425914b4/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/6ed29f61913c5429093ff5b22667a15c425914b4/chrome/browser/ui/views/tabs/tab_drag_controller.cc
[modify] https://crrev.com/6ed29f61913c5429093ff5b22667a15c425914b4/chrome/browser/ui/views/tabs/window_finder.h
[add] https://crrev.com/6ed29f61913c5429093ff5b22667a15c425914b4/chrome/browser/ui/views/tabs/window_finder_mus.cc
[add] https://crrev.com/6ed29f61913c5429093ff5b22667a15c425914b4/chrome/browser/ui/views/tabs/window_finder_mus.h
[modify] https://crrev.com/6ed29f61913c5429093ff5b22667a15c425914b4/ui/views/mus/native_widget_mus.cc
[modify] https://crrev.com/6ed29f61913c5429093ff5b22667a15c425914b4/ui/views/mus/native_widget_mus.h
[modify] https://crrev.com/6ed29f61913c5429093ff5b22667a15c425914b4/ui/views/mus/window_manager_connection.cc
[modify] https://crrev.com/6ed29f61913c5429093ff5b22667a15c425914b4/ui/views/mus/window_manager_connection.h
[modify] https://crrev.com/6ed29f61913c5429093ff5b22667a15c425914b4/ui/views/widget/widget_unittest.cc

Comment 3 by e...@chromium.org, Jul 8 2016

Status: Fixed (was: Assigned)

Comment 4 by lafo...@chromium.org, Feb 26 2018

Components: -MUS Internals>Services>WindowService
►

Sign in to add a comment