New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 622569 link

Starred by 3 users
Status: Fixed
Owner:
█ roc...@chromium.org
please use my google.com address
Closed: Jun 2016
Cc:
amistry@chromium.org
dcheng@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

IPC security OWNERS check false positives on deleted files

Project Member Reported by roc...@chromium.org, Jun 23 2016 
Suppose you have a directory with a mojom file and an OWNERS file. Deleting the directory will lead to presubmit failure, because the mojom file change triggers a check of the OWNERS file, and the OWNERS file (now "empty") will be detected as missing necessary security lines.

Comment 1 by amistry@chromium.org, Jun 23 2016 

 Issue 622567  has been merged into this issue.
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 23 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5124933c736ff0ac907a1b051e8dac83d3f9bc06

commit 5124933c736ff0ac907a1b051e8dac83d3f9bc06
Author: rockot <rockot@chromium.org>
Date: Thu Jun 23 16:32:25 2016

Ignore IPC security check on deleted files

If a file has been deleted, don't bother adding its
OWNERS file to the set of files to be checked for correct
security lines.

BUG= 622569 

Review-Url: https://codereview.chromium.org/2090653003
Cr-Commit-Position: refs/heads/master@{#401625}

[modify] https://crrev.com/5124933c736ff0ac907a1b051e8dac83d3f9bc06/PRESUBMIT.py

Comment 3 by roc...@chromium.org, Jun 23 2016

Status: Fixed (was: Started)
►

Sign in to add a comment