New issue
Advanced search Search tips

Issue 622567 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 622569
Owner: ----
Closed: Jun 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

IPC security presubmit check fails with deleted directories.

Project Member Reported by amistry@chromium.org, Jun 23 2016

Issue description

In https://codereview.chromium.org/2069803003/, the entire //ipc/mojo directory is deleted. However, the presubmit check fails with:

** Presubmit ERRORS **
Found changes to IPC files without a security OWNER!

***************
ipc/mojo/OWNERS is missing the following lines:

per-file *.mojom=set noparent
per-file *.mojom=file://ipc/SECURITY_OWNERS
per-file *_param_traits*.*=set noparent
per-file *_param_traits*.*=file://ipc/SECURITY_OWNERS

for changed files:
  ipc/mojo/ipc.mojom
  ipc/mojo/ipc_mojo_param_traits.cc
  ipc/mojo/ipc_mojo_param_traits.h
***************
 
Mergedinto: 622569
Status: Duplicate (was: Untriaged)

Sign in to add a comment