New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 622555 link

Starred by 24 users

Issue metadata

Status: Archived
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocked on:
issue 699472



Sign in to add a comment

Automatic time zone detection is forced when no user is logged on

Reported by yurock.t...@gmail.com, Jun 23 2016

Issue description

UserAgent: Mozilla/5.0 (X11; CrOS x86_64 8172.57.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.103 Safari/537.36
Platform: 8172.57.0 (Official Build) stable-channel clapper

Steps to reproduce the problem:
1. Disable "Set time zone automatically using your location".
2. Set time zone to some other (incorrect) value.
3. Observe that the clock shows the time for the specified time zone.
4. Log out.
5. Wait few minutes.

What is the expected behavior?
The clock uses manually set time zone.

What went wrong?
The clock changes to auto-detected time zone.

Did this work before? N/A 

Chrome version: 51.0.2704.103  Channel: stable
OS Version: 8172.57.0
Flash Version: Shockwave Flash 22.0 r0

When the device is turned on, the forced auto-detection is triggered before the user has a chance to log in. This gets really annoying if there is a geolocation error for any reason.
 
I am experiencing a very similar issue since upgrading to M51.
For some reason my timezone is no longer detected correctly since upgrading to M51, but setting it manually does not help either since it always resets itself to Chicago time.

Version 51.0.2704.103
Platform 8172.56.0 (Official Build) stable-channel nyan_big
Firmware Google_Nyan_Big.5771.63.0

Mozilla/5.0 (X11; CrOS armv7l 8172.56.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.103 Safari/537.36
Components: UI>Localization Blink>Location
Cc: dhadd...@chromium.org
Components: Blink>JavaScript>Internationalization
Owner: js...@chromium.org
Status: Assigned (was: Unconfirmed)
Reproducible the issue on Chrome 8350.44.0/52.0.2743.57 - Minnie.
Will check it on Ubuntu. 

Cc: littledan@chromium.org mukai@chromium.org abodenha@chromium.org u...@chromium.org alemate@chromium.org cira@chromium.org js...@chromium.org
 Issue 466014  has been merged into this issue.
#CBC-RS/TC-watchlist
By the way, what should be the correct behavior when different users on the same device set different time zone settings?

Consider the following scenario:
1. Owner sets time zone manually.
2. User 2 adds her account to the device and turns auto-detection on.
3. User 3 adds her account to the device and sets time zone manually, different from that of the owner.

What time zone should be used when -
- device is turned on (login screen)?
- user logs in?
- user logs out?
The current owner is on vacation. Is there anyone else who we could assign this to?
Owner: alemate@chromium.org
Any update?

Comment 11 by js...@chromium.org, Jul 25 2016

I need to experiment, but my gut feeling is that it has little to do with v8 and it's more to do with the way CrOS sets the timezone (manually or automatically).
Re #10
I'll look at this this week.
We are still seeing numerous complaints in CBC regarding this problem.

Comment 14 by lib...@gmail.com, Aug 24 2016

Version 53.0.2785.70 beta
Platform 8530.62.0 (Official Build) beta-channel veyron_minnie
ARC Version 3152187
Firmware Google_Veyron_Minnie.6588.197.0

Jumped from EDT to CDT on startup this morning, and when I checked, I saw that the automatic time zone box was checked. Since I've been experimenting with this feature, I can't remember if I checked it or not. Unchecked, set time zone manually, restarted, and it jumped to CDT again. I checked the setting, which was still set for manual, then unchecked 24-hour, and restarted, and it's now showing my selected time zone.

Using StraightTalk hot spot, which connects through Verizon cellular network. http://whatismyipaddress.com/ shows

General IP Information

IP:	174.218.138.81
Decimal:	2933557841
Hostname:	81.sub-174-218-138.myvzw.com
ASN:	6167
ISP:	Verizon Wireless
Organization:	Verizon Wireless
Services:	None detected
Type:	Wireless Broadband
Assignment:	Static IP
Blacklist:	Blacklist Check
Geolocation Information

Continent:	North America
Country:	United States us flag
Latitude:	37.751  (37° 45′ 3.60″ N)
Longitude:	-97.822  (97° 49′ 19.20″ W)

This location corresponds with known internet mapping issues: http://fusion.net/story/287592/internet-mapping-glitch-kansas-farm/

Comment 16 by dymp...@gmail.com, Aug 25 2016

Related issue?
Chromebook does not update timezone back to US
https://bugs.chromium.org/p/chromium/issues/detail?id=640660

Comment 17 by pgr...@gmail.com, Sep 24 2016

I just upgraded to the latest release:

Version 53.0.2785.103 (64-bit)
Platform 8530.81.0 (Official Build) stable-channel swanky
Firmware Google_Swanky.5216.238.5

After restarting the chromebook it thought I was on mountain time, but I am on central. The clock indicated mountain time, but when I went to google.com and typed what time is it, google told me my correct city and correct time. 

I unchecked automatic time and forced to central, restarted and I was back on mountain time. Went to google again and got the correct time. 

I rechecked automatic time and it updated to central time where it has stayed. 

I confirmed google dns servers were being used. 
I keep setting correct time zone, Eastern, but chromebook keeps reverting to Pacific time zone.

I sent feedback at 2:27pm with time zone using  Issue 622555 . I set correct time zone in settings and calendar but Chromebook insists on reverting to Central Standard time. Thank you.

Comment 20 by a...@apkweb.com, Mar 4 2017

Regarding comment 6 above, the behavior before login would be irrelevent to this issue IF the user's setting was applied when they logged in, but it isn't.
Im not sure if this bug should be characterized by the fact the system uses the network time before login, but rather that it fails to change to the user's time zone setting after login.
But for the record, I'd think the owner's settings would be the pre login default.  

Comment 21 by j...@nnbfn.net, Mar 6 2017

Asus C302A Same problem here and it is annoying as hell.  No matter what variation of reboot, user status, timezone setting.. everytime I power on, timezone is set to PST/PDT, even to the point of overriding my manual setting.  How the hell this is still an issue after this many months.
Labels: -Pri-2 M-59 Pri-1
Owner: r...@chromium.org
alemate@ is slammed with other issues. rkc@ can you find someone else to dig into this?
Blockedon: 699472
Owner: alemate@chromium.org
Components: -Blink>Location -Blink>JavaScript>Internationalization
Removing irrelevant components. This is a Chrome OS issue, not related to the Geolocation API or JavaScript internationalization.
Cc: marchuk@chromium.org
Labels: Hotlist-Enterprise
Just got an escalation, 
Successfully reproduced on Candy, Minnie, Kefka, etc on 56.0.2942.110
Alex/eng team, can you please take a look.
Thanks for this escalation. The issue is definitely hurting CrOS adoption within our organization. We use Cisco AnyConnect, and upon connecting to VPN, time eventually IP-locks to the wrong time zone. This happens off VPN with timezone detection disabled upon reboot based on IP/egress locations. I'm not sure if it's one issue (time zone detection only look at your IP instead of other vectors) or two manifestations - the former, plus auto-detect-disablement being disabled upon reboot.
Labels: ReleaseBlock-Stable
Re #27: It's 2 issues.  By default it only uses IP based geolocation and that's being broken by VPN.  If your devices are enterprise enrolled there's a feature you can turn on in the admin console to allow wifi based geo to be used for timezone.

The other issue is that turning auto-timezone off is sometimes not working.  

The second one is what's tracked here. alemate@ any update to share?
Albert, could you comment on the blocking issue 699472 ?
Labels: -M-59 M-60
Moving to M60 per issue 699472.
Project Member

Comment 31 by bugdroid1@chromium.org, May 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad7d3bec4dd219a4675fcb5473186e96039c2b0a

commit ad7d3bec4dd219a4675fcb5473186e96039c2b0a
Author: alemate <alemate@chromium.org>
Date: Mon May 01 23:47:08 2017

ChromeOS: Correctly handle settings.resolve_device_timezone_by_geolocation.

This CL fixes a problem when checking for if timezone autodetection should
startfor signin screen, when unset preference was treated as "false".

BUG= 622555 

Review-Url: https://codereview.chromium.org/2855433002
Cr-Commit-Position: refs/heads/master@{#468491}

[modify] https://crrev.com/ad7d3bec4dd219a4675fcb5473186e96039c2b0a/chrome/browser/chromeos/system/timezone_resolver_manager.cc

Status: Fixed (was: Assigned)
Labels: -M-60 Merge-Request-59 M-59
Labels: Merge-Approved-59
Project Member

Comment 35 by bugdroid1@chromium.org, May 2 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/156d9dfa385488b1b044122278d1d7764c95e0b7

commit 156d9dfa385488b1b044122278d1d7764c95e0b7
Author: Alexander Alekseev <alemate@chromium.org>
Date: Tue May 02 20:51:31 2017

ChromeOS: Correctly handle settings.resolve_device_timezone_by_geolocation.

This CL fixes a problem when checking for if timezone autodetection should
startfor signin screen, when unset preference was treated as "false".

BUG= 622555 

Review-Url: https://codereview.chromium.org/2855433002
Cr-Commit-Position: refs/heads/master@{#468491}
(cherry picked from commit ad7d3bec4dd219a4675fcb5473186e96039c2b0a)

Review-Url: https://codereview.chromium.org/2857583004 .
Cr-Commit-Position: refs/branch-heads/3071@{#361}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/156d9dfa385488b1b044122278d1d7764c95e0b7/chrome/browser/chromeos/system/timezone_resolver_manager.cc

Project Member

Comment 36 by sheriffbot@chromium.org, May 3 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-59
This has already merged.
Status: Assigned (was: Fixed)
I tried to verify this issue on M60 - 9534.0.0 and see that cfm still auto detects time zone by geolocation. 
Similar bug@ https://bugs.chromium.org/p/chromium/issues/detail?id=612515
I verified this bug on croste.tv domain and the settings are as per the attached. 

Please let me know in case more details are needed. 
timezone_settings.png
12.8 KB View Download
Status: Fixed (was: Assigned)
Project Member

Comment 40 by bugdroid1@chromium.org, Jun 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/410dbeb8df3d4ab140390d7d1e603163885c8c9c

commit 410dbeb8df3d4ab140390d7d1e603163885c8c9c
Author: alemate <alemate@chromium.org>
Date: Thu Jun 01 23:17:12 2017

ChromeOS: Per-user time zone: refactor tests first.

This Cl prepares tests to support per-user timezone implementation.

BUG= 622555 , 699472

TBR=bauerb@chromium.org,rdevlin.cronin@chromium.org,reillyg@chromium.org

Review-Url: https://codereview.chromium.org/2907493002
Cr-Commit-Position: refs/heads/master@{#476478}

[modify] https://crrev.com/410dbeb8df3d4ab140390d7d1e603163885c8c9c/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc
[modify] https://crrev.com/410dbeb8df3d4ab140390d7d1e603163885c8c9c/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/410dbeb8df3d4ab140390d7d1e603163885c8c9c/chrome/browser/chromeos/customization/customization_document_unittest.cc
[modify] https://crrev.com/410dbeb8df3d4ab140390d7d1e603163885c8c9c/chrome/browser/chromeos/extensions/active_tab_permission_granter_delegate_chromeos_unittest.cc
[modify] https://crrev.com/410dbeb8df3d4ab140390d7d1e603163885c8c9c/chrome/browser/chromeos/extensions/public_session_permission_helper_unittest.cc
[modify] https://crrev.com/410dbeb8df3d4ab140390d7d1e603163885c8c9c/chrome/browser/chromeos/file_manager/path_util_unittest.cc
[modify] https://crrev.com/410dbeb8df3d4ab140390d7d1e603163885c8c9c/chrome/browser/chromeos/login/auth/cryptohome_authenticator_unittest.cc
[modify] https://crrev.com/410dbeb8df3d4ab140390d7d1e603163885c8c9c/chrome/browser/chromeos/login/hwid_checker_unittest.cc
[modify] https://crrev.com/410dbeb8df3d4ab140390d7d1e603163885c8c9c/chrome/browser/chromeos/login/signin/merge_session_load_page_unittest.cc
[modify] https://crrev.com/410dbeb8df3d4ab140390d7d1e603163885c8c9c/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc
[modify] https://crrev.com/410dbeb8df3d4ab140390d7d1e603163885c8c9c/chrome/browser/chromeos/login/users/supervised_user_manager_impl.cc
[modify] https://crrev.com/410dbeb8df3d4ab140390d7d1e603163885c8c9c/chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc
[add] https://crrev.com/410dbeb8df3d4ab140390d7d1e603163885c8c9c/chrome/browser/chromeos/scoped_set_running_on_chromeos_for_testing.cc
[add] https://crrev.com/410dbeb8df3d4ab140390d7d1e603163885c8c9c/chrome/browser/chromeos/scoped_set_running_on_chromeos_for_testing.h
[modify] https://crrev.com/410dbeb8df3d4ab140390d7d1e603163885c8c9c/chrome/browser/extensions/active_tab_unittest.cc
[modify] https://crrev.com/410dbeb8df3d4ab140390d7d1e603163885c8c9c/chrome/browser/extensions/activity_log/activity_database_unittest.cc
[modify] https://crrev.com/410dbeb8df3d4ab140390d7d1e603163885c8c9c/chrome/browser/extensions/activity_log/activity_log_enabled_unittest.cc
[modify] https://crrev.com/410dbeb8df3d4ab140390d7d1e603163885c8c9c/chrome/browser/extensions/activity_log/activity_log_unittest.cc
[modify] https://crrev.com/410dbeb8df3d4ab140390d7d1e603163885c8c9c/chrome/browser/extensions/api/image_writer_private/operation_manager_unittest.cc
[modify] https://crrev.com/410dbeb8df3d4ab140390d7d1e603163885c8c9c/chrome/browser/extensions/extension_service_unittest.cc
[modify] https://crrev.com/410dbeb8df3d4ab140390d7d1e603163885c8c9c/chrome/browser/extensions/test_extension_system.cc
[modify] https://crrev.com/410dbeb8df3d4ab140390d7d1e603163885c8c9c/chrome/browser/extensions/test_extension_system.h
[modify] https://crrev.com/410dbeb8df3d4ab140390d7d1e603163885c8c9c/chrome/browser/media_galleries/media_file_system_registry_unittest.cc
[modify] https://crrev.com/410dbeb8df3d4ab140390d7d1e603163885c8c9c/chrome/browser/notifications/extension_welcome_notification_unittest.cc
[modify] https://crrev.com/410dbeb8df3d4ab140390d7d1e603163885c8c9c/chrome/browser/notifications/platform_notification_service_unittest.cc
[modify] https://crrev.com/410dbeb8df3d4ab140390d7d1e603163885c8c9c/chrome/test/BUILD.gn
[modify] https://crrev.com/410dbeb8df3d4ab140390d7d1e603163885c8c9c/chrome/test/base/testing_profile.cc
[modify] https://crrev.com/410dbeb8df3d4ab140390d7d1e603163885c8c9c/chrome/test/base/testing_profile.h
[modify] https://crrev.com/410dbeb8df3d4ab140390d7d1e603163885c8c9c/components/user_manager/user_manager_base.cc

Project Member

Comment 41 by bugdroid1@chromium.org, Jun 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4b98df10877a69266bcddca89cd042ba8191748

commit a4b98df10877a69266bcddca89cd042ba8191748
Author: pkasting <pkasting@chromium.org>
Date: Fri Jun 02 00:27:18 2017

Revert of ChromeOS: Per-user time zone: refactor tests first. (patchset #10 id:180001 of https://codereview.chromium.org/2907493002/ )

Reason for revert:
Looks to have caused Linux CrOS link failure:

https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder%20%28dbg%29/builds/87898

Original issue's description:
> ChromeOS: Per-user time zone: refactor tests first.
>
> This Cl prepares tests to support per-user timezone implementation.
>
> BUG= 622555 , 699472
>
> TBR=bauerb@chromium.org,rdevlin.cronin@chromium.org,reillyg@chromium.org
>
> Review-Url: https://codereview.chromium.org/2907493002
> Cr-Commit-Position: refs/heads/master@{#476478}
> Committed: https://chromium.googlesource.com/chromium/src/+/410dbeb8df3d4ab140390d7d1e603163885c8c9c

TBR=stevenjb@chromium.org,phajdan.jr@chromium.org,xiyuan@chromium.org,alemate@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 622555 , 699472

Review-Url: https://codereview.chromium.org/2919933002
Cr-Commit-Position: refs/heads/master@{#476496}

[modify] https://crrev.com/a4b98df10877a69266bcddca89cd042ba8191748/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc
[modify] https://crrev.com/a4b98df10877a69266bcddca89cd042ba8191748/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/a4b98df10877a69266bcddca89cd042ba8191748/chrome/browser/chromeos/customization/customization_document_unittest.cc
[modify] https://crrev.com/a4b98df10877a69266bcddca89cd042ba8191748/chrome/browser/chromeos/extensions/active_tab_permission_granter_delegate_chromeos_unittest.cc
[modify] https://crrev.com/a4b98df10877a69266bcddca89cd042ba8191748/chrome/browser/chromeos/extensions/public_session_permission_helper_unittest.cc
[modify] https://crrev.com/a4b98df10877a69266bcddca89cd042ba8191748/chrome/browser/chromeos/file_manager/path_util_unittest.cc
[modify] https://crrev.com/a4b98df10877a69266bcddca89cd042ba8191748/chrome/browser/chromeos/login/auth/cryptohome_authenticator_unittest.cc
[modify] https://crrev.com/a4b98df10877a69266bcddca89cd042ba8191748/chrome/browser/chromeos/login/hwid_checker_unittest.cc
[modify] https://crrev.com/a4b98df10877a69266bcddca89cd042ba8191748/chrome/browser/chromeos/login/signin/merge_session_load_page_unittest.cc
[modify] https://crrev.com/a4b98df10877a69266bcddca89cd042ba8191748/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc
[modify] https://crrev.com/a4b98df10877a69266bcddca89cd042ba8191748/chrome/browser/chromeos/login/users/supervised_user_manager_impl.cc
[modify] https://crrev.com/a4b98df10877a69266bcddca89cd042ba8191748/chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc
[delete] https://crrev.com/968db9c86d7b8d6a949edecb4548ce33091b0a97/chrome/browser/chromeos/scoped_set_running_on_chromeos_for_testing.cc
[delete] https://crrev.com/968db9c86d7b8d6a949edecb4548ce33091b0a97/chrome/browser/chromeos/scoped_set_running_on_chromeos_for_testing.h
[modify] https://crrev.com/a4b98df10877a69266bcddca89cd042ba8191748/chrome/browser/extensions/active_tab_unittest.cc
[modify] https://crrev.com/a4b98df10877a69266bcddca89cd042ba8191748/chrome/browser/extensions/activity_log/activity_database_unittest.cc
[modify] https://crrev.com/a4b98df10877a69266bcddca89cd042ba8191748/chrome/browser/extensions/activity_log/activity_log_enabled_unittest.cc
[modify] https://crrev.com/a4b98df10877a69266bcddca89cd042ba8191748/chrome/browser/extensions/activity_log/activity_log_unittest.cc
[modify] https://crrev.com/a4b98df10877a69266bcddca89cd042ba8191748/chrome/browser/extensions/api/image_writer_private/operation_manager_unittest.cc
[modify] https://crrev.com/a4b98df10877a69266bcddca89cd042ba8191748/chrome/browser/extensions/extension_service_unittest.cc
[modify] https://crrev.com/a4b98df10877a69266bcddca89cd042ba8191748/chrome/browser/extensions/test_extension_system.cc
[modify] https://crrev.com/a4b98df10877a69266bcddca89cd042ba8191748/chrome/browser/extensions/test_extension_system.h
[modify] https://crrev.com/a4b98df10877a69266bcddca89cd042ba8191748/chrome/browser/media_galleries/media_file_system_registry_unittest.cc
[modify] https://crrev.com/a4b98df10877a69266bcddca89cd042ba8191748/chrome/browser/notifications/extension_welcome_notification_unittest.cc
[modify] https://crrev.com/a4b98df10877a69266bcddca89cd042ba8191748/chrome/browser/notifications/platform_notification_service_unittest.cc
[modify] https://crrev.com/a4b98df10877a69266bcddca89cd042ba8191748/chrome/test/BUILD.gn
[modify] https://crrev.com/a4b98df10877a69266bcddca89cd042ba8191748/chrome/test/base/testing_profile.cc
[modify] https://crrev.com/a4b98df10877a69266bcddca89cd042ba8191748/chrome/test/base/testing_profile.h
[modify] https://crrev.com/a4b98df10877a69266bcddca89cd042ba8191748/components/user_manager/user_manager_base.cc

Project Member

Comment 42 by bugdroid1@chromium.org, Jun 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f96a4f208edf90610e14cfb146b71bbc344da05

commit 5f96a4f208edf90610e14cfb146b71bbc344da05
Author: alemate <alemate@chromium.org>
Date: Fri Jun 02 21:09:40 2017

ChromeOS: Per-user time zone: refactor tests first.

This Cl prepares tests to support per-user timezone implementation.

BUG= 622555 , 699472

TBR=bauerb@chromium.org,rdevlin.cronin@chromium.org,reillyg@chromium.org

Review-Url: https://codereview.chromium.org/2907493002
Cr-Original-Commit-Position: refs/heads/master@{#476478}
Committed: https://chromium.googlesource.com/chromium/src/+/410dbeb8df3d4ab140390d7d1e603163885c8c9c
Review-Url: https://codereview.chromium.org/2907493002
Cr-Commit-Position: refs/heads/master@{#476787}

[modify] https://crrev.com/5f96a4f208edf90610e14cfb146b71bbc344da05/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc
[modify] https://crrev.com/5f96a4f208edf90610e14cfb146b71bbc344da05/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/5f96a4f208edf90610e14cfb146b71bbc344da05/chrome/browser/chromeos/customization/customization_document_unittest.cc
[modify] https://crrev.com/5f96a4f208edf90610e14cfb146b71bbc344da05/chrome/browser/chromeos/extensions/active_tab_permission_granter_delegate_chromeos_unittest.cc
[modify] https://crrev.com/5f96a4f208edf90610e14cfb146b71bbc344da05/chrome/browser/chromeos/extensions/public_session_permission_helper_unittest.cc
[modify] https://crrev.com/5f96a4f208edf90610e14cfb146b71bbc344da05/chrome/browser/chromeos/file_manager/path_util_unittest.cc
[modify] https://crrev.com/5f96a4f208edf90610e14cfb146b71bbc344da05/chrome/browser/chromeos/login/auth/cryptohome_authenticator_unittest.cc
[modify] https://crrev.com/5f96a4f208edf90610e14cfb146b71bbc344da05/chrome/browser/chromeos/login/hwid_checker_unittest.cc
[modify] https://crrev.com/5f96a4f208edf90610e14cfb146b71bbc344da05/chrome/browser/chromeos/login/signin/merge_session_load_page_unittest.cc
[modify] https://crrev.com/5f96a4f208edf90610e14cfb146b71bbc344da05/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc
[modify] https://crrev.com/5f96a4f208edf90610e14cfb146b71bbc344da05/chrome/browser/chromeos/login/users/supervised_user_manager_impl.cc
[modify] https://crrev.com/5f96a4f208edf90610e14cfb146b71bbc344da05/chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc
[add] https://crrev.com/5f96a4f208edf90610e14cfb146b71bbc344da05/chrome/browser/chromeos/scoped_set_running_on_chromeos_for_testing.cc
[add] https://crrev.com/5f96a4f208edf90610e14cfb146b71bbc344da05/chrome/browser/chromeos/scoped_set_running_on_chromeos_for_testing.h
[modify] https://crrev.com/5f96a4f208edf90610e14cfb146b71bbc344da05/chrome/browser/extensions/active_tab_unittest.cc
[modify] https://crrev.com/5f96a4f208edf90610e14cfb146b71bbc344da05/chrome/browser/extensions/activity_log/activity_database_unittest.cc
[modify] https://crrev.com/5f96a4f208edf90610e14cfb146b71bbc344da05/chrome/browser/extensions/activity_log/activity_log_enabled_unittest.cc
[modify] https://crrev.com/5f96a4f208edf90610e14cfb146b71bbc344da05/chrome/browser/extensions/activity_log/activity_log_unittest.cc
[modify] https://crrev.com/5f96a4f208edf90610e14cfb146b71bbc344da05/chrome/browser/extensions/api/image_writer_private/operation_manager_unittest.cc
[modify] https://crrev.com/5f96a4f208edf90610e14cfb146b71bbc344da05/chrome/browser/extensions/extension_service_unittest.cc
[modify] https://crrev.com/5f96a4f208edf90610e14cfb146b71bbc344da05/chrome/browser/extensions/test_extension_system.cc
[modify] https://crrev.com/5f96a4f208edf90610e14cfb146b71bbc344da05/chrome/browser/extensions/test_extension_system.h
[modify] https://crrev.com/5f96a4f208edf90610e14cfb146b71bbc344da05/chrome/browser/media_galleries/media_file_system_registry_unittest.cc
[modify] https://crrev.com/5f96a4f208edf90610e14cfb146b71bbc344da05/chrome/browser/notifications/extension_welcome_notification_unittest.cc
[modify] https://crrev.com/5f96a4f208edf90610e14cfb146b71bbc344da05/chrome/browser/notifications/platform_notification_service_unittest.cc
[modify] https://crrev.com/5f96a4f208edf90610e14cfb146b71bbc344da05/chrome/test/BUILD.gn
[modify] https://crrev.com/5f96a4f208edf90610e14cfb146b71bbc344da05/chrome/test/base/testing_profile.cc
[modify] https://crrev.com/5f96a4f208edf90610e14cfb146b71bbc344da05/chrome/test/base/testing_profile.h
[modify] https://crrev.com/5f96a4f208edf90610e14cfb146b71bbc344da05/components/user_manager/user_manager_base.cc

This is marked fixed for M60 on 5/22/17 but on latest betas this is still definitely happening. 
Project Member

Comment 44 by bugdroid1@chromium.org, Aug 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2cb0d75387b3fbf61e1d37a7e9b902a87842b363

commit 2cb0d75387b3fbf61e1d37a7e9b902a87842b363
Author: alemate <alemate@chromium.org>
Date: Fri Aug 11 05:22:16 2017

ChromeOS: implement per-user time zone preferences.

Historically ChromeOS had only one global time zone preference. But now time
settings become complicate and we need to support per-user time zone
preferences.

TBR=phajdan.jr@chromium.org

BUG= 622555 ,699472
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2849823003
Cr-Commit-Position: refs/heads/master@{#493673}

[modify] https://crrev.com/2cb0d75387b3fbf61e1d37a7e9b902a87842b363/chrome/browser/about_flags.cc
[modify] https://crrev.com/2cb0d75387b3fbf61e1d37a7e9b902a87842b363/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/2cb0d75387b3fbf61e1d37a7e9b902a87842b363/chrome/browser/chromeos/extensions/info_private_api.cc
[modify] https://crrev.com/2cb0d75387b3fbf61e1d37a7e9b902a87842b363/chrome/browser/chromeos/extensions/info_private_apitest.cc
[modify] https://crrev.com/2cb0d75387b3fbf61e1d37a7e9b902a87842b363/chrome/browser/chromeos/login/screens/network_screen.cc
[modify] https://crrev.com/2cb0d75387b3fbf61e1d37a7e9b902a87842b363/chrome/browser/chromeos/login/ui/login_display_host_impl.cc
[modify] https://crrev.com/2cb0d75387b3fbf61e1d37a7e9b902a87842b363/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc
[modify] https://crrev.com/2cb0d75387b3fbf61e1d37a7e9b902a87842b363/chrome/browser/chromeos/login/wizard_controller.cc
[modify] https://crrev.com/2cb0d75387b3fbf61e1d37a7e9b902a87842b363/chrome/browser/chromeos/policy/browser_policy_connector_chromeos.cc
[modify] https://crrev.com/2cb0d75387b3fbf61e1d37a7e9b902a87842b363/chrome/browser/chromeos/preferences.cc
[modify] https://crrev.com/2cb0d75387b3fbf61e1d37a7e9b902a87842b363/chrome/browser/chromeos/settings/system_settings_provider.cc
[modify] https://crrev.com/2cb0d75387b3fbf61e1d37a7e9b902a87842b363/chrome/browser/chromeos/settings/system_settings_provider.h
[modify] https://crrev.com/2cb0d75387b3fbf61e1d37a7e9b902a87842b363/chrome/browser/chromeos/system/timezone_util.cc
[modify] https://crrev.com/2cb0d75387b3fbf61e1d37a7e9b902a87842b363/chrome/browser/chromeos/system/timezone_util.h
[modify] https://crrev.com/2cb0d75387b3fbf61e1d37a7e9b902a87842b363/chrome/browser/extensions/api/settings_private/prefs_util.cc
[modify] https://crrev.com/2cb0d75387b3fbf61e1d37a7e9b902a87842b363/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/2cb0d75387b3fbf61e1d37a7e9b902a87842b363/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/2cb0d75387b3fbf61e1d37a7e9b902a87842b363/chrome/browser/resources/options/browser_options.html
[modify] https://crrev.com/2cb0d75387b3fbf61e1d37a7e9b902a87842b363/chrome/browser/resources/settings/date_time_page/date_time_page.html
[modify] https://crrev.com/2cb0d75387b3fbf61e1d37a7e9b902a87842b363/chrome/browser/resources/settings/date_time_page/date_time_page.js
[modify] https://crrev.com/2cb0d75387b3fbf61e1d37a7e9b902a87842b363/chrome/browser/ui/webui/chromeos/set_time_ui.cc
[modify] https://crrev.com/2cb0d75387b3fbf61e1d37a7e9b902a87842b363/chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc
[modify] https://crrev.com/2cb0d75387b3fbf61e1d37a7e9b902a87842b363/chrome/common/pref_names.cc
[modify] https://crrev.com/2cb0d75387b3fbf61e1d37a7e9b902a87842b363/chrome/common/pref_names.h
[modify] https://crrev.com/2cb0d75387b3fbf61e1d37a7e9b902a87842b363/chrome/test/data/webui/settings/date_time_page_tests.js
[modify] https://crrev.com/2cb0d75387b3fbf61e1d37a7e9b902a87842b363/chromeos/chromeos_switches.cc
[modify] https://crrev.com/2cb0d75387b3fbf61e1d37a7e9b902a87842b363/chromeos/chromeos_switches.h
[modify] https://crrev.com/2cb0d75387b3fbf61e1d37a7e9b902a87842b363/chromeos/settings/cros_settings_names.cc
[modify] https://crrev.com/2cb0d75387b3fbf61e1d37a7e9b902a87842b363/chromeos/settings/cros_settings_names.h
[modify] https://crrev.com/2cb0d75387b3fbf61e1d37a7e9b902a87842b363/tools/metrics/histograms/enums.xml

Comment 45 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment