[Cast Channel] Improve cast_channel_unittest.cc |
||||
Issue descriptionCurrently some of the methods in CastSocketImpl (e.g., CreateSSLSocket) are mocked out in the tests, resulting in critical code path that isn't tested and issues like https://bugs.chromium.org/p/chromium/issues/detail?id=620810. We should mock out the underlying components used by CastSocketImpl instead, so that the core logic itself can be tested.
,
May 10 2017
,
May 10 2017
,
Jul 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/25ff9b7cb09ab7db6dd453c5d5c43779a58c8159 commit 25ff9b7cb09ab7db6dd453c5d5c43779a58c8159 Author: btolsch <btolsch@chromium.org> Date: Fri Jul 07 03:31:55 2017 [Cast Channel] Add real SSL tests to CastSocketTest CastSocket is tested using a mocked transport which does not use SSL. This can and did lead to integration problems when SSL code is changed ( https://crbug.com/622098 ). This change adds two tests to CastSocketTest which use an SSL socket for their transport instead of the mocked TCP socket. BUG= 622554 Review-Url: https://codereview.chromium.org/2093923004 Cr-Commit-Position: refs/heads/master@{#484819} [modify] https://crrev.com/25ff9b7cb09ab7db6dd453c5d5c43779a58c8159/components/cast_channel/cast_socket.h [modify] https://crrev.com/25ff9b7cb09ab7db6dd453c5d5c43779a58c8159/components/cast_channel/cast_socket_unittest.cc [add] https://crrev.com/25ff9b7cb09ab7db6dd453c5d5c43779a58c8159/components/test/data/cast_channel/self_signed.pem
,
Jul 7 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by btolsch@chromium.org
, Jun 27 2016