New issue
Advanced search Search tips

Issue 622551 link

Starred by 12 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug


Sign in to add a comment

Move //third_party/WebKit to //third_party/blink

Project Member Reported by tkent@chromium.org, Jun 23 2016

Issue description

Comment 1 by tkent@chromium.org, Jul 11 2016

Blockedon: 431177 563793

Comment 2 by tkent@chromium.org, Jul 11 2016

Blockedon: -431177 623685

Comment 3 by tkent@chromium.org, Jul 11 2016

Blockedon: -623685 432967

Comment 4 by tkent@chromium.org, Oct 2 2016

Blocking: 652114
Blockedon: 578344 578345 578346
Blockedon: 584560

Comment 7 by loyso@chromium.org, Oct 6 2016

Cc: loyso@chromium.org

Comment 8 by tkent@chromium.org, Mar 14 2017

Summary: Move third_party/WebKit/ to web/ (was: Move third_party/WebKit/ to blink/)
Project document: https://docs.google.com/document/d/1l3aPv1Wx__SpRkdOhvJz8ciEGigNT3wFKv78XiuW0Tw/edit#heading=h.xgjl2srtytjt

Discussion thread: https://groups.google.com/a/chromium.org/forum/#!topic/platform-architecture-dev/DKQn-SILZzo
Cc: qyears...@chromium.org jeffcarp@chromium.org
Components: Blink>Infra
Blockedon: 710535
Project Member

Comment 11 by bugdroid1@chromium.org, Apr 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9774e4bbc3820cff53edeb95f5562ae69dc391a

commit f9774e4bbc3820cff53edeb95f5562ae69dc391a
Author: tkent <tkent@chromium.org>
Date: Tue Apr 18 08:22:19 2017

Clang plugin: Detect Blink code by "blink" or "WTF" namespace

We used to detect Blink code by paths including third_party/WebKit, and it won't
work if we move the Blink code to elsewhere. This CL removes the patch check for
third_party/WebKit, and adds namespace checks instead.

BUG=622551

Review-Url: https://codereview.chromium.org/2749043004
Cr-Commit-Position: refs/heads/master@{#465175}

[modify] https://crrev.com/f9774e4bbc3820cff53edeb95f5562ae69dc391a/tools/clang/plugins/ChromeClassTester.cpp
[modify] https://crrev.com/f9774e4bbc3820cff53edeb95f5562ae69dc391a/tools/clang/plugins/ChromeClassTester.h
[modify] https://crrev.com/f9774e4bbc3820cff53edeb95f5562ae69dc391a/tools/clang/plugins/FindBadConstructsConsumer.cpp
[modify] https://crrev.com/f9774e4bbc3820cff53edeb95f5562ae69dc391a/tools/clang/plugins/FindBadConstructsConsumer.h

Comment 12 by e...@chromium.org, Apr 20 2017

Cc: e...@chromium.org

Comment 13 by tkent@chromium.org, Aug 25 2017

Summary: Move //third_party/WebKit to //third_party/blink (was: Move third_party/WebKit/ to web/)
Project Member

Comment 14 by bugdroid1@chromium.org, Aug 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/099ede7736b5b7c11aaaabdefb02bb6ab2faf187

commit 099ede7736b5b7c11aaaabdefb02bb6ab2faf187
Author: Kent Tamura <tkent@chromium.org>
Date: Mon Aug 28 23:23:31 2017

Make //third_party/blink and tools/.

NOTRY=true

Bug: 622551
Change-Id: Ic9497d10d45eee96063be9a5a8481a30e693e018
Reviewed-on: https://chromium-review.googlesource.com/633261
Reviewed-by: Dimitri Glazkov <dglazkov@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497928}
[add] https://crrev.com/099ede7736b5b7c11aaaabdefb02bb6ab2faf187/third_party/blink/OWNERS
[add] https://crrev.com/099ede7736b5b7c11aaaabdefb02bb6ab2faf187/third_party/blink/tools/OWNERS

Comment 15 by tkent@chromium.org, Aug 30 2017

Blockedon: 760459

Comment 16 by tkent@chromium.org, Aug 30 2017

Blockedon: 760462
Project Member

Comment 17 by bugdroid1@chromium.org, Aug 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9b3a9ec3ec6f214423823e3ae744e7227320c7b

commit e9b3a9ec3ec6f214423823e3ae744e7227320c7b
Author: Kent Tamura <tkent@chromium.org>
Date: Thu Aug 31 02:20:19 2017

Treat //third_party/blink same as //third_party/WebKit in //PRESUBMIT.py, //WATCHLIST, and //third_party/PRESUBMIT.py.

Bug: 622551
Change-Id: I7610cd223c4c9d1223d0ccf582897bff13355138
Reviewed-on: https://chromium-review.googlesource.com/642433
Reviewed-by: Dimitri Glazkov <dglazkov@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498729}
[modify] https://crrev.com/e9b3a9ec3ec6f214423823e3ae744e7227320c7b/PRESUBMIT.py
[modify] https://crrev.com/e9b3a9ec3ec6f214423823e3ae744e7227320c7b/WATCHLISTS
[modify] https://crrev.com/e9b3a9ec3ec6f214423823e3ae744e7227320c7b/third_party/PRESUBMIT.py

Project Member

Comment 18 by bugdroid1@chromium.org, Aug 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22e444176a93754a233f1942bd48dedff9b13ba7

commit 22e444176a93754a233f1942bd48dedff9b13ba7
Author: Kent Tamura <tkent@chromium.org>
Date: Thu Aug 31 23:01:13 2017

Add a wrapper of devtools/scripts/compile_frontend.py

This is a preparation to remove third_party/WebKit dependency from
DevTools bot.

NOTRY=true

Bug: 622551
Change-Id: Id5a8906db02ef47aa9afb222fc3c4391bb4e4160
Reviewed-on: https://chromium-review.googlesource.com/644833
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499061}
[add] https://crrev.com/22e444176a93754a233f1942bd48dedff9b13ba7/third_party/blink/tools/compile_devtools_frontend.py

Project Member

Comment 19 by bugdroid1@chromium.org, Sep 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/c5de8b86fc08b131034051e9a0b298be8d189914

commit c5de8b86fc08b131034051e9a0b298be8d189914
Author: Kent Tamura <tkent@chromium.org>
Date: Fri Sep 01 02:59:58 2017

Analyze step: changes in third_party/blink should trigger Blink layout tests.

Bug: chromium:622551
Change-Id: I7f41c1f8d6a8ca4c4c401a65163b98d52cfa7709
Reviewed-on: https://chromium-review.googlesource.com/644656
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>

[modify] https://crrev.com/c5de8b86fc08b131034051e9a0b298be8d189914/scripts/slave/README.recipes.md
[modify] https://crrev.com/c5de8b86fc08b131034051e9a0b298be8d189914/scripts/slave/recipe_modules/chromium_tests/api.py

Cc: dcheng@chromium.org
I wanted to say thanks to tkent@ for doing so much work with the move plan script recently ( bug 578345 ).

So I expect that when the actual rename happens, the issues that we hit will be similar to those hit with the Blink Rename.

What is required of the "rebase tool" for this? What is the rebase tool for the Blink Rename like?

Also, without tkent@ driving this in Q4, if nobody else volunteers, I'm assuming this will wait until 2018? But it might still be possible to move Tools/Scripts before Source/.

PS Great lightning talks about both the Blink Rename retrospective as well as this plan!

Comment 22 by tkent@chromium.org, Sep 22 2017

Blockedon: 767672

Comment 23 by tkent@chromium.org, Sep 22 2017

The Great Blink mv slide:
https://docs.google.com/presentation/d/1hx_uCEhi24kYZhsI503e4799Z2Fz4Qm-8k_Ghu-V4Fo/edit?usp=sharing

Retrospective slide:
https://docs.google.com/presentation/d/14ztbadQ9tUpAhCfEvC6c1Jq9AC8hzHPNBnZ8OYI0U7U/edit?usp=sharing

> What is required of the "rebase tool" for this? What is the rebase tool for the Blink Rename like?

I have filed  Issue 767672 . Let's discuss the rebase tool in it.

> if nobody else volunteers, I'm assuming this will wait until 2018?

Right.

> But it might still be possible to move Tools/Scripts before Source/.

Right. We can move tests and tools before source files.

Comment 24 by tkent@chromium.org, Sep 25 2017

Blockedon: 768274

Comment 25 by tkent@chromium.org, Sep 26 2017

Blockedon: 768828

Comment 26 by tkent@chromium.org, Sep 26 2017

Blockedon: -578345

Comment 27 by tkent@chromium.org, Sep 26 2017

Blockedon: -760462

Comment 28 by tkent@chromium.org, Sep 26 2017

Blockedon: -768274
Related to tools/scripts moving: another thing to potentially rename at some point (not necessary for the main move) is "run-webkit-tests". If LayoutTests is being renamed to web_tests (announced at BlinkOn lightning talk) then one possible name would be run-web-tests.
Re comment 22: Since this is a lot more automatable than the Rename, I hope this will be more similar to the Great Reformat, not the Great Rename. In particular, rebasing should be hopefully be completely transparent like it was with the Reformat.

What issues in particular are you thinking of?
Re #30: I'm not sure myself what issues there may be ... I added that comment after tkent's status update at BlinkOn which noted that building Chrome now works after moving with the move script that tkent wrote (https://chromium.googlesource.com/chromium/src.git/+/master/third_party/blink/tools/move_blink_source.py), but there's no rebase tool.

I was hoping that people who know better (e.g. you, dcheng) could advise about potential pitfalls based on past experience.
Blockedon: 530257
Project Member

Comment 33 by bugdroid1@chromium.org, Mar 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1adafeeca94db914d1b82d2ee96c2a852b62ddaa

commit 1adafeeca94db914d1b82d2ee96c2a852b62ddaa
Author: Kent Tamura <tkent@chromium.org>
Date: Wed Mar 07 10:12:08 2018

licenses.py: Add third_party/blink to KNOWN_NON_IOS_LIBRARIES.

We'll move third_party/WebKit/Source to third_party/blink soon. We don't
need to update SPECIAL_CASES yet.

Change-Id: I7ecae51fdd89c25e92873ed8894ab579d12f6692
Bug: 622551
Reviewed-on: https://chromium-review.googlesource.com/952376
Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541399}
[modify] https://crrev.com/1adafeeca94db914d1b82d2ee96c2a852b62ddaa/tools/licenses.py

Project Member

Comment 34 by bugdroid1@chromium.org, Mar 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eaca74262314335fe003c1198b03f4d2d82e9a2e

commit eaca74262314335fe003c1198b03f4d2d82e9a2e
Author: Kent Tamura <tkent@chromium.org>
Date: Mon Mar 12 00:13:37 2018

check-webkit-style: Check snake_case.{cc,h} files.

This is a preparation for the Great Blink mv.

* PRESUBMIT.py doesn't exclude snake_case.{cc,h} files.
* check-webkit-style assumes *.cc as a C++ source.
* check-webkit-style suggests the standard include guard macro for
  snake_case files.

Bug: 622551
Change-Id: I7c94f07c67718033d89714417a4f797e87090e39
Reviewed-on: https://chromium-review.googlesource.com/954622
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542410}
[modify] https://crrev.com/eaca74262314335fe003c1198b03f4d2d82e9a2e/third_party/WebKit/PRESUBMIT.py
[modify] https://crrev.com/eaca74262314335fe003c1198b03f4d2d82e9a2e/third_party/WebKit/Tools/Scripts/webkitpy/style/checker.py
[modify] https://crrev.com/eaca74262314335fe003c1198b03f4d2d82e9a2e/third_party/WebKit/Tools/Scripts/webkitpy/style/checker_unittest.py
[modify] https://crrev.com/eaca74262314335fe003c1198b03f4d2d82e9a2e/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py
[modify] https://crrev.com/eaca74262314335fe003c1198b03f4d2d82e9a2e/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py

Project Member

Comment 35 by bugdroid1@chromium.org, Mar 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6eaf64fc5dfff9b820ed79cfb664487aff9cf7b1

commit 6eaf64fc5dfff9b820ed79cfb664487aff9cf7b1
Author: Kent Tamura <tkent@chromium.org>
Date: Thu Mar 22 07:05:07 2018

checklicenses.py: Add "UNKNOWN" entry for third_party/blink

as well as third_party/WebKit because we'll move
third_party/WebKit/{Source,common,public} to third_party/blink soon.

Bug: 622551
Change-Id: Ib916a70651318dadc333416d8ca49927bceba1cb
Reviewed-on: https://chromium-review.googlesource.com/952946
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544995}
[modify] https://crrev.com/6eaf64fc5dfff9b820ed79cfb664487aff9cf7b1/tools/checklicenses/checklicenses.py

Project Member

Comment 36 by bugdroid1@chromium.org, Apr 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48d81b7b3ce9e22fd05bb10f4e6dd7b739ef79ec

commit 48d81b7b3ce9e22fd05bb10f4e6dd7b739ef79ec
Author: Kent Tamura <tkent@chromium.org>
Date: Mon Apr 02 06:24:28 2018

PrettyPatch.rb: Allow to linkify any files.

We have no reason to restrict links to specific WebKit sub-directories.

Bug: 622551
Change-Id: If0ebcb1b1241cb99e80d4bfffac2a24300fd3a02
Reviewed-on: https://chromium-review.googlesource.com/989812
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547418}
[modify] https://crrev.com/48d81b7b3ce9e22fd05bb10f4e6dd7b739ef79ec/third_party/WebKit/Tools/Scripts/webkitruby/PrettyPatch/PrettyPatch.rb

Blockedon: 829695
Blockedon: 829697
Project Member

Comment 39 by bugdroid1@chromium.org, Apr 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b59a47b5b311acb51e3aa6d19d5fe5be0593ae48

commit b59a47b5b311acb51e3aa6d19d5fe5be0593ae48
Author: Kent Tamura <tkent@chromium.org>
Date: Thu Apr 26 08:27:41 2018

Move third_party/WebKit/API_OWNERS to third_party/blink/

Bug: 622551
Change-Id: Ib31bd4189957bad107090db694a6857211e581d1
Reviewed-on: https://chromium-review.googlesource.com/1029930
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553954}
[modify] https://crrev.com/b59a47b5b311acb51e3aa6d19d5fe5be0593ae48/blink/OWNERS
[modify] https://crrev.com/b59a47b5b311acb51e3aa6d19d5fe5be0593ae48/third_party/WebKit/LayoutTests/platform/linux/virtual/stable/webexposed/OWNERS
[modify] https://crrev.com/b59a47b5b311acb51e3aa6d19d5fe5be0593ae48/third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/OWNERS
[modify] https://crrev.com/b59a47b5b311acb51e3aa6d19d5fe5be0593ae48/third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/OWNERS
[modify] https://crrev.com/b59a47b5b311acb51e3aa6d19d5fe5be0593ae48/third_party/WebKit/LayoutTests/virtual/stable/http/tests/serviceworker/webexposed/OWNERS
[modify] https://crrev.com/b59a47b5b311acb51e3aa6d19d5fe5be0593ae48/third_party/WebKit/LayoutTests/virtual/stable/webexposed/OWNERS
[rename] https://crrev.com/b59a47b5b311acb51e3aa6d19d5fe5be0593ae48/third_party/blink/API_OWNERS
[modify] https://crrev.com/b59a47b5b311acb51e3aa6d19d5fe5be0593ae48/third_party/blink/renderer/platform/OWNERS

Project Member

Comment 40 by bugdroid1@chromium.org, Apr 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/25be427c7323ce7eb7cf809070f4745548d45194

commit 25be427c7323ce7eb7cf809070f4745548d45194
Author: Daniel Cheng <dcheng@chromium.org>
Date: Thu Apr 26 20:44:44 2018

Chrome style plugin: always enable checks for Blink and Enum::kMaxValue.

These options are always on now, so default them to on in the plugin so
they can be removed in a followup.

Also cleans up a conditional check for Blink code in the legacy
//third_party/WebKit directory.

Bug:  482580 , 622551, 706466
Change-Id: I6d53d53cac11831b3bd10a4086c8daae0e67ddfc
Reviewed-on: https://chromium-review.googlesource.com/1030973
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554140}
[modify] https://crrev.com/25be427c7323ce7eb7cf809070f4745548d45194/tools/clang/plugins/ChromeClassTester.cpp
[modify] https://crrev.com/25be427c7323ce7eb7cf809070f4745548d45194/tools/clang/plugins/FindBadConstructsAction.cpp
[modify] https://crrev.com/25be427c7323ce7eb7cf809070f4745548d45194/tools/clang/plugins/FindBadConstructsConsumer.cpp
[modify] https://crrev.com/25be427c7323ce7eb7cf809070f4745548d45194/tools/clang/plugins/Options.h

Project Member

Comment 41 by bugdroid1@chromium.org, Apr 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/861a385a090d14b4b5dbb91bf17343d2eb17708c

commit 861a385a090d14b4b5dbb91bf17343d2eb17708c
Author: Kent Tamura <tkent@chromium.org>
Date: Fri Apr 27 01:18:32 2018

Remove .gitattributes and .gitignore in //third_party/WebKit

- .gitattributes is empty.
- .gitignore doesn't include any WebKit-specific files except for
  make_core_generated.xml. It isn't generated now AFAIK.
  //.gitignore should be enough.

Bug: 622551
Change-Id: I5ea1b7029ffbbeb157ba5b9e951017a1db52e048
Reviewed-on: https://chromium-review.googlesource.com/1029391
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554251}
[delete] https://crrev.com/f7f98818ff430a993be9d153edd9e93daed00335/third_party/WebKit/.gitattributes
[delete] https://crrev.com/f7f98818ff430a993be9d153edd9e93daed00335/third_party/WebKit/.gitignore

Project Member

Comment 42 by bugdroid1@chromium.org, Nov 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6da357292322df39430604b19507e7db39a5351a

commit 6da357292322df39430604b19507e7db39a5351a
Author: Kent Tamura <tkent@chromium.org>
Date: Fri Nov 16 00:27:56 2018

Swap WebKit/OWNERS and blink/OWNERS, WebKit/Tools/OWNERS and blink/tools/OWNERS

Bug: 622551,  829697 
Change-Id: I38cf0ac24b1d22c27feec6117cc44f909f50d006
Reviewed-on: https://chromium-review.googlesource.com/c/1337228
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608598}
[modify] https://crrev.com/6da357292322df39430604b19507e7db39a5351a/third_party/WebKit/OWNERS
[modify] https://crrev.com/6da357292322df39430604b19507e7db39a5351a/third_party/WebKit/Tools/OWNERS
[modify] https://crrev.com/6da357292322df39430604b19507e7db39a5351a/third_party/blink/OWNERS
[modify] https://crrev.com/6da357292322df39430604b19507e7db39a5351a/third_party/blink/tools/OWNERS

Project Member

Comment 43 by bugdroid1@chromium.org, Nov 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2cf14c734153d203ada718fe486cc85e575dc6a9

commit 2cf14c734153d203ada718fe486cc85e575dc6a9
Author: Kent Tamura <tkent@chromium.org>
Date: Tue Nov 27 03:29:26 2018

Remove third_party/WebKit/PRESUBMIT*.py

PRESUBMIT.py existed just for linting LayoutTest/TestExpectations.
It's unnecessary now.

No-Try: true
Bug: 622551
Change-Id: I4e3d801ecfa829f3a99e187eb2058fa326aa7c67
Reviewed-on: https://chromium-review.googlesource.com/c/1350430
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611016}
[delete] https://crrev.com/d4d9ad5528c9df3f0c53c919c91239a3bf21cf8f/third_party/WebKit/PRESUBMIT.py
[delete] https://crrev.com/d4d9ad5528c9df3f0c53c919c91239a3bf21cf8f/third_party/WebKit/PRESUBMIT_test.py

Project Member

Comment 44 by bugdroid1@chromium.org, Nov 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65f56d355da883a854b9c5996af5cd6cbb8a0cc4

commit 65f56d355da883a854b9c5996af5cd6cbb8a0cc4
Author: Kent Tamura <tkent@chromium.org>
Date: Tue Nov 27 05:20:49 2018

Update licenses.py for WebKit and Blink.

third_party/blink was forked from WebKit, so we should credit for WebKit.
Move third_party/WebKit/LICENSE_FOR_ABOUT_CREDITS to third_party/blink.

Remove third_party/WebKit/OWNERS because third_party/WebKit doesn't have
files any longer.

No-Try: true
Bug: 622551
Change-Id: Icdf9b5a08e78848925cd4a7db48d076c1baa328a
Reviewed-on: https://chromium-review.googlesource.com/c/1350011
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611022}
[delete] https://crrev.com/8c1c9ca81fd568bc263ce3a834be9430731c4b9a/third_party/WebKit/OWNERS
[rename] https://crrev.com/65f56d355da883a854b9c5996af5cd6cbb8a0cc4/third_party/blink/LICENSE_FOR_ABOUT_CREDITS
[modify] https://crrev.com/65f56d355da883a854b9c5996af5cd6cbb8a0cc4/tools/licenses.py

Project Member

Comment 45 by bugdroid1@chromium.org, Nov 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00ef3e476048edeb1b99538e42721302e29a3af5

commit 00ef3e476048edeb1b99538e42721302e29a3af5
Author: Kent Tamura <tkent@chromium.org>
Date: Fri Nov 30 04:32:29 2018

Remove some third_party/WebKit instances in third_party/blink/

Bug: 622551
Change-Id: I2d1911ef91081777978ea1a0fb45280434b2a5f5
Reviewed-on: https://chromium-review.googlesource.com/c/1351983
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612562}
[modify] https://crrev.com/00ef3e476048edeb1b99538e42721302e29a3af5/third_party/blink/public/platform/web_resource_timing_info.h
[modify] https://crrev.com/00ef3e476048edeb1b99538e42721302e29a3af5/third_party/blink/public/platform/web_url_load_timing.h
[modify] https://crrev.com/00ef3e476048edeb1b99538e42721302e29a3af5/third_party/blink/web_tests/NeverFixTests
[modify] https://crrev.com/00ef3e476048edeb1b99538e42721302e29a3af5/third_party/blink/web_tests/TestExpectations
[modify] https://crrev.com/00ef3e476048edeb1b99538e42721302e29a3af5/third_party/blink/web_tests/W3CImportExpectations
[modify] https://crrev.com/00ef3e476048edeb1b99538e42721302e29a3af5/third_party/blink/web_tests/animations/animationworklet/animator-registration.html
[modify] https://crrev.com/00ef3e476048edeb1b99538e42721302e29a3af5/third_party/blink/web_tests/http/tests/devtools/network/resources/gc.js
[modify] https://crrev.com/00ef3e476048edeb1b99538e42721302e29a3af5/third_party/blink/web_tests/webaudio/tools/README.md

Project Member

Comment 46 by bugdroid1@chromium.org, Nov 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32dbbcb752598136a3e30f6288c30c054d026dd8

commit 32dbbcb752598136a3e30f6288c30c054d026dd8
Author: Kent Tamura <tkent@chromium.org>
Date: Fri Nov 30 12:28:49 2018

Remove references to thrid_party/WebKit in various code

This CL enables _CheckForRelativeIncludes presubmit check for
third_party/blink.

Change-Id: Ida579dad3adb3d156b3ab6f800fdfd7e4c0559a2
Bug: 622551
Reviewed-on: https://chromium-review.googlesource.com/c/1356719
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612622}
[modify] https://crrev.com/32dbbcb752598136a3e30f6288c30c054d026dd8/.gn
[modify] https://crrev.com/32dbbcb752598136a3e30f6288c30c054d026dd8/DEPS
[modify] https://crrev.com/32dbbcb752598136a3e30f6288c30c054d026dd8/PRESUBMIT.py
[modify] https://crrev.com/32dbbcb752598136a3e30f6288c30c054d026dd8/PRESUBMIT_test.py
[modify] https://crrev.com/32dbbcb752598136a3e30f6288c30c054d026dd8/ios/build/config.gni
[modify] https://crrev.com/32dbbcb752598136a3e30f6288c30c054d026dd8/mojo/public/cpp/bindings/tests/BUILD.gn
[modify] https://crrev.com/32dbbcb752598136a3e30f6288c30c054d026dd8/ppapi/native_client/BUILD.gn
[modify] https://crrev.com/32dbbcb752598136a3e30f6288c30c054d026dd8/tools/android/native_lib_memory/visualize.js
[modify] https://crrev.com/32dbbcb752598136a3e30f6288c30c054d026dd8/tools/checklicenses/checklicenses.py

Sign in to add a comment