Issue metadata
Sign in to add a comment
|
Compile error in mojo_renderer_service.cc |
||||||||||||||||||||||
Issue descriptionOS: Win10, not sure if repros on other platforms When building I get the following error: D:\src\chromium\src>ninja -C out\dbg ninja: Entering directory `out\dbg' [1/1] Regenerating ninja files [3424/20480] CXX obj/media/mojo/services/services/mojo_renderer_service.obj FAILED: obj/media/mojo/services/services/mojo_renderer_service.obj ninja -t msvc -e environment.x64 -- "d:\src\depot_tools\win_toolchain\vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\VC\bin\amd64/cl.exe" /nologo /showIncludes /FC @obj/media/mojo/services/services/mojo_renderer_service.obj.rsp /c ../../media/mojo/services/mojo_renderer_service.cc /Foobj/media/mojo/services/services/mojo_renderer_service.obj /Fd"obj/media/mojo/services/services_cc.pdb" d:\src\chromium\src\media\mojo\services\mojo_renderer_service.h(33): error C2220: warning treated as error - no 'object' file generated d:\src\chromium\src\media\mojo\services\mojo_renderer_service.h(33): warning C4275: non dll-interface class 'media::mojom::Renderer' used as base for dll-interface class 'media::MojoRendererService' d:\src\chromium\src\out\dbg\gen\media\mojo\interfaces\renderer.mojom.h(78): note: see declaration of 'media::mojom::Renderer' d:\src\chromium\src\media\mojo\services\mojo_renderer_service.h(33): note: see declaration of 'media::MojoRendererService' [3473/20480] CXX obj/media/test/mojo_pipeline_integration_tests/pipeline_integration_test.obj ninja: build stopped: subcommand failed.
,
Jun 23 2016
+rockot@ - can you help direct this to the right person?
,
Jun 23 2016
+xhwang@ could you take a look or reassign?
,
Jun 23 2016
I'll fix it.
,
Jun 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8a0ec0c622ce52013094d7c8b4ce558eb362ae61 commit 8a0ec0c622ce52013094d7c8b4ce558eb362ae61 Author: xhwang <xhwang@chromium.org> Date: Thu Jun 23 07:33:40 2016 media: Use NON_EXPORTED_BASE for MojoRendererService TBR=sandersd@chromium.org BUG= 622541 Review-Url: https://codereview.chromium.org/2087373003 Cr-Commit-Position: refs/heads/master@{#401557} [modify] https://crrev.com/8a0ec0c622ce52013094d7c8b4ce558eb362ae61/media/mojo/services/mojo_renderer_service.h
,
Jun 23 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by kulshin@chromium.org
, Jun 23 2016