New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 622537 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

QUIC treats RST_STREAM as normal stream termination

Project Member Reported by rch@chromium.org, Jun 23 2016

Issue description

When a RST_STREAM is received before the full response body has been downloaded, the truncated response body is treated as if it were the complete response body.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd5f1c60daa702f416e719edf13358571e0bf084

commit cd5f1c60daa702f416e719edf13358571e0bf084
Author: rch <rch@chromium.org>
Date: Thu Jun 23 02:43:48 2016

Change QuicHttpStream::OnError to look at both stream and connection errors.

BUG= 622537 

Review-Url: https://codereview.chromium.org/2090703003
Cr-Commit-Position: refs/heads/master@{#401526}

[modify] https://crrev.com/cd5f1c60daa702f416e719edf13358571e0bf084/net/quic/quic_http_stream.cc
[modify] https://crrev.com/cd5f1c60daa702f416e719edf13358571e0bf084/net/quic/quic_network_transaction_unittest.cc

Comment 2 by rch@chromium.org, Jul 1 2016

Labels: Merge-Request-52

Comment 3 by dimu@google.com, Jul 1 2016

Labels: -Merge-Request-52 Merge-Approved-52 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M52 (branch: 2743)
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 1 2016

Labels: -merge-approved-52 merge-merged-2743
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/268e5e7c0ea9a4c19eea4597e382ed6756840e2d

commit 268e5e7c0ea9a4c19eea4597e382ed6756840e2d
Author: Ryan Hamilton <rch@chromium.org>
Date: Fri Jul 01 16:56:21 2016

[m52] Change QuicHttpStream::OnError to look at both stream and connection errors.

BUG= 622537 

Review-Url: https://codereview.chromium.org/2090703003
Cr-Commit-Position: refs/heads/master@{#401526}
(cherry picked from commit cd5f1c60daa702f416e719edf13358571e0bf084)

Review URL: https://codereview.chromium.org/2114033002 .

Cr-Commit-Position: refs/branch-heads/2743@{#567}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/268e5e7c0ea9a4c19eea4597e382ed6756840e2d/net/quic/quic_http_stream.cc
[modify] https://crrev.com/268e5e7c0ea9a4c19eea4597e382ed6756840e2d/net/quic/quic_network_transaction_unittest.cc

Cc: ranjitkan@chromium.org
Labels: Needs-Feedback
Could some one please help us with the steps so that test team can verify the issue if required.

Thanks.!

Comment 6 by mattm@chromium.org, Aug 3 2016

Should this issue be closed?

Comment 7 by rch@chromium.org, Aug 16 2016

Status: Fixed (was: Started)

Sign in to add a comment