New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 622529 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Feature
Team-Security-UX



Sign in to add a comment

Implement verbose state chip animations for Mac

Project Member Reported by emilyschechter@chromium.org, Jun 23 2016

Issue description

Labels: -OS-Windows -OS-Chrome OS-Mac
Labels: -OS-Linux
Status: Assigned (was: Untriaged)
By the way Sarah, I think it is a great first step to implement this on navigation without animations:

(1) Verbose state chip (very similar to EV cert chip): show/remove verbose states on navigation per spec
(2) Animations: animate in and out

Ideally we will ship both together, but if necessary, we could potentially ship (1) without (2).

Let us know if you need anything else!
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0afe4deba4f93d82430e90d789ab39e3c788c891

commit 0afe4deba4f93d82430e90d789ab39e3c788c891
Author: spqchan <spqchan@chromium.org>
Date: Thu Sep 01 23:30:25 2016

[Material][Mac] Implement Omnibox Verbose State Chips

Replaced EVBubbleDecoration with VerboseStateDecoration.
VerboseStateDecoration displays both the security state and the
EV Cert by animating in and out.

Animations only occur when the security level has changed or if the
omnibox becomes narrow or wide.

Verbose states animates in when the security level changes to
HTTPS or an invalid HTTPS. It animates outs if the security level
changes to something else.

If there's not enough room on the omnibox, the security state should
not appear, and will animate out if it's already displayed. It will
animate back in if the user resize the window so that there's enough
room.

BUG= 622529 

Review-Url: https://codereview.chromium.org/2119033002
Cr-Commit-Position: refs/heads/master@{#416119}

[modify] https://crrev.com/0afe4deba4f93d82430e90d789ab39e3c788c891/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/0afe4deba4f93d82430e90d789ab39e3c788c891/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell_unittest.mm
[modify] https://crrev.com/0afe4deba4f93d82430e90d789ab39e3c788c891/chrome/browser/ui/cocoa/location_bar/bubble_decoration.h
[modify] https://crrev.com/0afe4deba4f93d82430e90d789ab39e3c788c891/chrome/browser/ui/cocoa/location_bar/bubble_decoration.mm
[delete] https://crrev.com/86fc67cca4eaad94ec7bf3daebf905939abdd03c/chrome/browser/ui/cocoa/location_bar/ev_bubble_decoration.h
[delete] https://crrev.com/86fc67cca4eaad94ec7bf3daebf905939abdd03c/chrome/browser/ui/cocoa/location_bar/ev_bubble_decoration.mm
[modify] https://crrev.com/0afe4deba4f93d82430e90d789ab39e3c788c891/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h
[modify] https://crrev.com/0afe4deba4f93d82430e90d789ab39e3c788c891/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
[add] https://crrev.com/0afe4deba4f93d82430e90d789ab39e3c788c891/chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.h
[add] https://crrev.com/0afe4deba4f93d82430e90d789ab39e3c788c891/chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.mm
[rename] https://crrev.com/0afe4deba4f93d82430e90d789ab39e3c788c891/chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration_unittest.mm
[add] https://crrev.com/0afe4deba4f93d82430e90d789ab39e3c788c891/chrome/chrome_browser_ui.gypi
[modify] https://crrev.com/0afe4deba4f93d82430e90d789ab39e3c788c891/chrome/chrome_tests_unit.gypi

Project Member

Comment 7 by bugdroid1@chromium.org, Sep 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0afe4deba4f93d82430e90d789ab39e3c788c891

commit 0afe4deba4f93d82430e90d789ab39e3c788c891
Author: spqchan <spqchan@chromium.org>
Date: Thu Sep 01 23:30:25 2016

[Material][Mac] Implement Omnibox Verbose State Chips

Replaced EVBubbleDecoration with VerboseStateDecoration.
VerboseStateDecoration displays both the security state and the
EV Cert by animating in and out.

Animations only occur when the security level has changed or if the
omnibox becomes narrow or wide.

Verbose states animates in when the security level changes to
HTTPS or an invalid HTTPS. It animates outs if the security level
changes to something else.

If there's not enough room on the omnibox, the security state should
not appear, and will animate out if it's already displayed. It will
animate back in if the user resize the window so that there's enough
room.

BUG= 622529 

Review-Url: https://codereview.chromium.org/2119033002
Cr-Commit-Position: refs/heads/master@{#416119}

[modify] https://crrev.com/0afe4deba4f93d82430e90d789ab39e3c788c891/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/0afe4deba4f93d82430e90d789ab39e3c788c891/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell_unittest.mm
[modify] https://crrev.com/0afe4deba4f93d82430e90d789ab39e3c788c891/chrome/browser/ui/cocoa/location_bar/bubble_decoration.h
[modify] https://crrev.com/0afe4deba4f93d82430e90d789ab39e3c788c891/chrome/browser/ui/cocoa/location_bar/bubble_decoration.mm
[delete] https://crrev.com/86fc67cca4eaad94ec7bf3daebf905939abdd03c/chrome/browser/ui/cocoa/location_bar/ev_bubble_decoration.h
[delete] https://crrev.com/86fc67cca4eaad94ec7bf3daebf905939abdd03c/chrome/browser/ui/cocoa/location_bar/ev_bubble_decoration.mm
[modify] https://crrev.com/0afe4deba4f93d82430e90d789ab39e3c788c891/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h
[modify] https://crrev.com/0afe4deba4f93d82430e90d789ab39e3c788c891/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
[add] https://crrev.com/0afe4deba4f93d82430e90d789ab39e3c788c891/chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.h
[add] https://crrev.com/0afe4deba4f93d82430e90d789ab39e3c788c891/chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.mm
[rename] https://crrev.com/0afe4deba4f93d82430e90d789ab39e3c788c891/chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration_unittest.mm
[add] https://crrev.com/0afe4deba4f93d82430e90d789ab39e3c788c891/chrome/chrome_browser_ui.gypi
[modify] https://crrev.com/0afe4deba4f93d82430e90d789ab39e3c788c891/chrome/chrome_tests_unit.gypi

Components: Security>UX
Labels: Hotlist-SecurityIndicators
I've been playing around with the verbose state, and it's pretty awesome, but I've noticed that the expanded click area of the lock icon aggravates two long-standing bugs. I propose that we should consider the following OSX bugs as blockers from the Enamel side (and look at other platforms to see if there similar issues):

 Issue 588381  Long-pressing/drag-dropping the security indicator on OSX causes a navigation
This one is likely to cause lots of unintended refreshes if people click on the verbose state.

 Issue 588377  Desktop security indicator should have a hover affordance to indicate clickability
Since we *do* want people to click on the verbose state, I think it's important to make sure we indicate this upon hover in the first release that the verbose state goes out on. I'm not a designer, but I judge this as details as very important for the success of the verbose state.

spqchan@, if you are able to take on either as part of the project, that would be awesome. If not, let me know and I'm interested figure out how to get them done (but I'll probably need guidance).
Components: UI>Browser>Omnibox>SecurityIndicators
Components: -Security>UX
Status: Fixed (was: Assigned)

Sign in to add a comment