Issue 622520 link

Starred by 2 users

Issue metadata

Status:	Fixed
Owner:	wangxianzhu@chromium.org
Closed:	Jun 2016
Cc:	ajha@chromium.org █ kavvaru@chromium.org wangxianzhu@chromium.org rohi...@chromium.org █ durga.behera@chromium.org abod...@chromium.org avkodipelli@chromium.org vmp...@chromium.org
Components:	Blink>Paint
EstimatedDays:	----
NextAction:	----
OS:	Linux
Pri:	0
Type:	Bug
ReleaseBlock-Dev Fracas Fracas-Wrong FoundIn-M-53

Blocking:
issue 609218

Crash in PaintController::copyCachedSubsequence()

Project Member Reported by wangxianzhu@chromium.org, Jun 22 2016

Issue description

The latest diagnosing code for bug 609218 got some crash reports in PaintController::copyCachedSubsequence().

https://crash.corp.google.com/browse?q=product.name%3D%27Chrome%27%20AND%20custom_data.ChromeCrashProto.ptype%3D%27renderer%27%20AND%20custom_data.ChromeCrashProto.magic_signature_1.name%3D%27blink%3A%3APaintController%3A%3AcopyCachedSubsequence%27%20AND%20product.version%3E%3D%2753.0.2774.3%27&ignore_case=false&enable_rewrite=true&omit_field_name=&omit_field_value=&omit_field_opt=%3D&stbtiq=&reportid=&index=0

I can reproduce the issue constently with some of the URLs in the crash reports, e.g. http://na.leagueoflegends.com/en/news/game-updates/player-behavior/play-games-matter/remake

Project Member

Comment 1 by bugdroid1@chromium.org, Jun 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1d3f1ab77aae4d2aebc67706b615f3fe2944749

commit d1d3f1ab77aae4d2aebc67706b615f3fe2944749
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Thu Jun 23 07:07:19 2016

Partly revert Invalidate as DisplayItemClient when PaintLayer is setNeedsRepaint

Because one DisplayItemClient may be painted on multiple
PaintControllers for spv1, in cached subsequences we should accept
DisplayItemClients whose cache generations don't match the
PaintController's cache generation.

BUG= 622520 
TBR=chrishtr@chromium.org

Review-Url: https://codereview.chromium.org/2088383002
Cr-Commit-Position: refs/heads/master@{#401554}

[modify] https://crrev.com/d1d3f1ab77aae4d2aebc67706b615f3fe2944749/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp

Comment 2 by joh...@chromium.org, Jun 27 2016

Issue 623507 has been merged into this issue.

Project Member

Comment 3 by sheriffbot@chromium.org, Jun 27 2016

Labels: FoundIn-M-53 Fracas OS-Linux

Users experienced this crash on the following builds:

Linux Dev 53.0.2774.3 -  66.13 CPM, 97 reports, 4 clients (signature cc::ProxyMain::BeginMainFrame)

If this update was incorrect, please add "Fracas-Wrong" label to prevent future updates.

- Go/Fracas

Project Member

Comment 4 by sheriffbot@chromium.org, Jun 27 2016

Labels: -Pri-1 ReleaseBlock-Dev Pri-0

This crash has high impact on Chrome's stability.
Signature: cc::ProxyMain::BeginMainFrame.
Channel: dev. Platform: linux.
Labeling  issue 622520  with Pri-0.
Labeling  issue 622520  with ReleaseBlock-Dev.


If this update was incorrect, please add "Fracas-Wrong" label to prevent future updates.

- Go/Fracas

Comment 5 by wangxianzhu@chromium.org, Jun 27 2016

Labels: Fracas-Wrong
Status: Fixed (was: Assigned)

The remaining ones are tracked by bug 609218

Comment 6 by wangxianzhu@chromium.org, Jun 28 2016

Cc: durga.behera@chromium.org abod...@chromium.org avkodipelli@chromium.org wangxianzhu@chromium.org rohi...@chromium.org ajha@chromium.org kavvaru@chromium.org

 Issue 622626  has been merged into this issue.

►

Issue 622520 link

Issue metadata

Crash in PaintController::copyCachedSubsequence()

Issue description

Comment 1 by bugdroid1@chromium.org, Jun 23 2016

Comment 1 Deleted

Comment 2 by joh...@chromium.org, Jun 27 2016

Comment 2 Deleted

Comment 3 by sheriffbot@chromium.org, Jun 27 2016

Comment 3 Deleted

Comment 4 by sheriffbot@chromium.org, Jun 27 2016

Comment 4 Deleted

Comment 5 by wangxianzhu@chromium.org, Jun 27 2016

Comment 5 Deleted

Comment 6 by wangxianzhu@chromium.org, Jun 28 2016

Comment 6 Deleted

Sign in to add a comment