https://luci-milo.appspot.com/swarming/prod/2f92726dac38a710 displays <br/> in step text. It should not.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/828e8a871ea38fe4fe68954d3cdbbbec57f23204 commit 828e8a871ea38fe4fe68954d3cdbbbec57f23204 Author: recipe-roller <recipe-roller@chromium.org> Date: Wed Jun 22 23:25:03 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) recipe_engine: https://crrev.com/98030a88041df67bae71e0bdb0d0f8248c8dd910 do not print <br> in step text (nodir@chromium.org) R=nodir@chromium.org,martiniss@chromium.org,hinoka@chromium.org BUG= 622503 TBR=martiniss@chromium.org,phajdan.jr@chromium.org Review-Url: https://codereview.chromium.org/2091593002 [modify] https://crrev.com/828e8a871ea38fe4fe68954d3cdbbbec57f23204/infra/config/recipes.cfg
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/668eb9f26c043e0d7708fba37faeb7502be8c8c9 commit 668eb9f26c043e0d7708fba37faeb7502be8c8c9 Author: recipe-roller <recipe-roller@chromium.org> Date: Wed Jun 22 23:36:43 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) depot_tools: https://crrev.com/828e8a871ea38fe4fe68954d3cdbbbec57f23204 Roll recipe dependencies (trivial). (recipe-roller@chromium.org) recipe_engine: https://crrev.com/98030a88041df67bae71e0bdb0d0f8248c8dd910 do not print <br> in step text (nodir@chromium.org) R=phajdan.jr@chromium.org,hinoka@chromium.org,nodir@chromium.org,martiniss@chromium.org,recipe-roller@chromium.org BUG= 622503 TBR=martiniss@chromium.org,phajdan.jr@chromium.org Review-Url: https://codereview.chromium.org/2084393003 [modify] https://crrev.com/668eb9f26c043e0d7708fba37faeb7502be8c8c9/infra/config/recipes.cfg
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/6ad7d98dfa5fbf2bbe19043a091dbdabd4ad2935 commit 6ad7d98dfa5fbf2bbe19043a091dbdabd4ad2935 Author: recipe-roller <recipe-roller@chromium.org> Date: Thu Jun 23 00:07:11 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/668eb9f26c043e0d7708fba37faeb7502be8c8c9 Roll recipe dependencies (trivial). (recipe-roller@chromium.org) depot_tools: https://crrev.com/828e8a871ea38fe4fe68954d3cdbbbec57f23204 Roll recipe dependencies (trivial). (recipe-roller@chromium.org) recipe_engine: https://crrev.com/98030a88041df67bae71e0bdb0d0f8248c8dd910 do not print <br> in step text (nodir@chromium.org) R=hinoka@chromium.org,phajdan.jr@chromium.org,nodir@chromium.org,martiniss@chromium.org,recipe-roller@chromium.org BUG= 622503 TBR=martiniss@chromium.org,phajdan.jr@chromium.org Review-Url: https://codereview.chromium.org/2090253002 [modify] https://crrev.com/6ad7d98dfa5fbf2bbe19043a091dbdabd4ad2935/infra/config/recipes.cfg
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/cfb258c35d2cfca391c6580acaaad2da08d10a3d commit cfb258c35d2cfca391c6580acaaad2da08d10a3d Author: nodir <nodir@chromium.org> Date: Thu Jun 23 01:05:00 2016 annotations: change meaning of STEP_TEXT recipe engine prints new lines in step text by putting <br/>; it abuses the fact that buildbot prints step text as HTML without escaping it. Milo escapes step text and as a result we see <br/> in step text. Change buildbot so that messages specified in STEP_TEXT annotation mean lines, not strings that are joined by space. Next CLs will change recipe engine to not print <br> and change milo to put <br> between step text strings. R=martiniss@chromium.org, hinoka@chromium.org BUG= 622503 Review-Url: https://codereview.chromium.org/2089223003 [modify] https://crrev.com/cfb258c35d2cfca391c6580acaaad2da08d10a3d/scripts/master/chromium_step.py
The following revision refers to this bug: https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/66d8950942a7d3850db0e3808fe93e7464d41dc4 commit 66d8950942a7d3850db0e3808fe93e7464d41dc4 Author: nodir <nodir@chromium.org> Date: Thu Jun 23 01:11:37 2016 milo: put line breaks between step text strings divs are used instead of br because putting <br> before each line except first one is surprisingly complicated. in particular, {{join .Text "<br"}} will escape <br> also divs are more semantic, so it is kind of the way it should be done R=hinoka@chromium.org, estaab@chromium.org BUG= 622503 Review-Url: https://codereview.chromium.org/2086353004 [modify] https://crrev.com/66d8950942a7d3850db0e3808fe93e7464d41dc4/appengine/cmd/milo/buildbot/expectations/CrWinGoma.30608.build.json [modify] https://crrev.com/66d8950942a7d3850db0e3808fe93e7464d41dc4/appengine/cmd/milo/buildbot/testdata/buildbot/CrWinGoma.30608.json [modify] https://crrev.com/66d8950942a7d3850db0e3808fe93e7464d41dc4/appengine/cmd/milo/frontend/expectations/bootstrap-buildbot.TestableBuild-Debug_page-_CrWinGoma_30608.html [modify] https://crrev.com/66d8950942a7d3850db0e3808fe93e7464d41dc4/appengine/cmd/milo/frontend/expectations/buildbot-buildbot.TestableBuild-Debug_page-_CrWinGoma_30608.html [modify] https://crrev.com/66d8950942a7d3850db0e3808fe93e7464d41dc4/appengine/cmd/milo/frontend/static/buildbot/css/default.css [modify] https://crrev.com/66d8950942a7d3850db0e3808fe93e7464d41dc4/appengine/cmd/milo/frontend/templates/bootstrap/pages/build.html [modify] https://crrev.com/66d8950942a7d3850db0e3808fe93e7464d41dc4/appengine/cmd/milo/frontend/templates/buildbot/pages/build.html [modify] https://crrev.com/66d8950942a7d3850db0e3808fe93e7464d41dc4/appengine/cmd/milo/frontend/testdata/build-patch-failure [modify] https://crrev.com/66d8950942a7d3850db0e3808fe93e7464d41dc4/appengine/cmd/milo/frontend/testdata/buildbot/CrWinGoma.30608.json [modify] https://crrev.com/66d8950942a7d3850db0e3808fe93e7464d41dc4/appengine/cmd/milo/swarming/expectations/build-exception.json [modify] https://crrev.com/66d8950942a7d3850db0e3808fe93e7464d41dc4/appengine/cmd/milo/swarming/expectations/build-patch-failure.json [modify] https://crrev.com/66d8950942a7d3850db0e3808fe93e7464d41dc4/appengine/cmd/milo/swarming/expectations/build-running.json [modify] https://crrev.com/66d8950942a7d3850db0e3808fe93e7464d41dc4/appengine/cmd/milo/swarming/expectations/build-timeout.json [modify] https://crrev.com/66d8950942a7d3850db0e3808fe93e7464d41dc4/appengine/cmd/milo/swarming/testdata/build-exception [modify] https://crrev.com/66d8950942a7d3850db0e3808fe93e7464d41dc4/appengine/cmd/milo/swarming/testdata/build-patch-failure [modify] https://crrev.com/66d8950942a7d3850db0e3808fe93e7464d41dc4/appengine/cmd/milo/swarming/testdata/build-running [modify] https://crrev.com/66d8950942a7d3850db0e3808fe93e7464d41dc4/appengine/cmd/milo/swarming/testdata/build-timeout
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/56b336e1971b7fb02212492b894104fe71c11fc7 commit 56b336e1971b7fb02212492b894104fe71c11fc7 Author: recipe-roller <recipe-roller@chromium.org> Date: Thu Jun 23 19:39:29 2016
Comment 1 by bugdroid1@chromium.org
, Jun 22 2016