Deprecate bitmaps in GBB |
||||||
Issue descriptionVboot screens used to be rendered using bitmap images stored in GBB but are now rendered by Depthcharge using bitmaps in CBFS. This is controlled ebuild's bitmap_in_cbfs switch. This is a bug which tracks the followings: - transition all boards currently built from ToT to bitmap_in_cbfs (e.g. Samus, Rambi) - remove bitmap_in_cbfs from all ebuild scripts (coreboot, chromeos-bootimage, bmpblk) - remove VbDisplayScreenLegacy and the code around it from vboot_reference - remove code in gbb_utility (around '--bmpfv' option) - remove USE=bitmap_in_cbfs in make.conf from overlays
,
Jun 23 2016
- remove '--skip-bmpblk' from cros_bundle_firmware
,
Jun 23 2016
,
Jun 27 2016
,
Jun 27 2016
- remove the code generating final screen images from chromeos-bmpblk
,
Jun 27 2016
,
Jul 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/53f869f715dc18c8490e86afc2420504dbe03a05 commit 53f869f715dc18c8490e86afc2420504dbe03a05 Author: Daisuke Nojiri <dnojiri@chromium.org> Date: Tue Jun 21 19:43:21 2016 vboot: deprecate bitmaps in GBB This patch makes vboot screens rendered by Depthcharge using bitmaps in CBFS for all boards. Thus, bitmap_in_cbfs can be removed. BUG=chromium:622501 BRANCH=tot TEST=emerge-samus chromeos-bootimage gbb_utility -g /build/samus/firmware/image.bin -b /tmp/bmpfv.bin CQ-DEPEND=CL:355040,CL:355100 Change-Id: I97cfa8019951ba3f865111f9b91bdeb90ab9cd94 Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/354710 [modify] https://crrev.com/53f869f715dc18c8490e86afc2420504dbe03a05/sys-boot/chromeos-bmpblk/chromeos-bmpblk-9999.ebuild [modify] https://crrev.com/53f869f715dc18c8490e86afc2420504dbe03a05/sys-boot/coreboot/coreboot-9999.ebuild [modify] https://crrev.com/53f869f715dc18c8490e86afc2420504dbe03a05/sys-boot/chromeos-bootimage/chromeos-bootimage-9999.ebuild
,
Jul 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/coreboot/+/201a82311ba539b9b02d546ba331ff5bf73e0edf commit 201a82311ba539b9b02d546ba331ff5bf73e0edf Author: Daisuke Nojiri <dnojiri@chromium.org> Date: Wed Jun 22 17:55:21 2016 Increase RO coreboot size on flash Bitmap images will be moved to CBFS from GBB. This patch adjust the flash map accordingly for rambi, samus, peppy, parrot, falco, panther, auron, strago. BUG=chromium:622501 BRANCH=tot TEST=emerge-{samus,falco} chromeos-bootimage CQ-DEPEND=CL:354710,CL:355100 Change-Id: I0b82285186540aa27757e312e7bd02957f9962ec Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/355040 [modify] https://crrev.com/201a82311ba539b9b02d546ba331ff5bf73e0edf/src/mainboard/intel/strago/chromeos.fmd [modify] https://crrev.com/201a82311ba539b9b02d546ba331ff5bf73e0edf/src/mainboard/google/panther/chromeos.fmd [modify] https://crrev.com/201a82311ba539b9b02d546ba331ff5bf73e0edf/src/mainboard/google/samus/chromeos.fmd [modify] https://crrev.com/201a82311ba539b9b02d546ba331ff5bf73e0edf/src/mainboard/google/falco/chromeos.fmd [modify] https://crrev.com/201a82311ba539b9b02d546ba331ff5bf73e0edf/src/mainboard/google/peppy/chromeos.fmd [modify] https://crrev.com/201a82311ba539b9b02d546ba331ff5bf73e0edf/src/mainboard/google/auron/chromeos.fmd [modify] https://crrev.com/201a82311ba539b9b02d546ba331ff5bf73e0edf/src/mainboard/google/parrot/chromeos.fmd [modify] https://crrev.com/201a82311ba539b9b02d546ba331ff5bf73e0edf/src/mainboard/google/rambi/chromeos.fmd
,
Jul 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/depthcharge/+/0b8e290aa6970534b4b95e6817e53ebf1638bd86 commit 0b8e290aa6970534b4b95e6817e53ebf1638bd86 Author: Daisuke Nojiri <dnojiri@chromium.org> Date: Wed Jun 22 19:46:49 2016 Increase RO coreboot size on flash Bitmap images will be moved to CBFS from GBB. This patch adjust the flash map accordingly for rambi, samus, peppy, falco, panther, auron, strago. BUG=chromium:622501 BRANCH=tot TEST=emerge-{samus,rambi,falco} chromeos-bootimage CQ-DEPEND=CL:355040,CL:354710 Change-Id: I2967ef16b4ed8fcc16d4ced6212b9e9251085789 Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/355100 [modify] https://crrev.com/0b8e290aa6970534b4b95e6817e53ebf1638bd86/board/auron/fmap.dts [modify] https://crrev.com/0b8e290aa6970534b4b95e6817e53ebf1638bd86/board/peppy/fmap.dts [modify] https://crrev.com/0b8e290aa6970534b4b95e6817e53ebf1638bd86/board/rambi/fmap.dts [modify] https://crrev.com/0b8e290aa6970534b4b95e6817e53ebf1638bd86/board/samus/fmap.dts [modify] https://crrev.com/0b8e290aa6970534b4b95e6817e53ebf1638bd86/board/strago/fmap.dts [modify] https://crrev.com/0b8e290aa6970534b4b95e6817e53ebf1638bd86/board/panther/fmap.dts [modify] https://crrev.com/0b8e290aa6970534b4b95e6817e53ebf1638bd86/board/falco/fmap.dts
,
Jul 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/coreboot/+/c859ce04d2df5f21c47a164cabbc9ef6dec61818 commit c859ce04d2df5f21c47a164cabbc9ef6dec61818 Author: Daisuke Nojiri <dnojiri@chromium.org> Date: Mon Jul 18 17:48:25 2016 jecht: Increase RO coreboot size on flash Bitmap images has been moved to CBFS from GBB. This patch adjusts the flash size accordingly for jecht. BUG=chromium:622501, chromium:628494 BRANCH=none TEST=emerge-jecht chromeos-bootimage CQ-DEPEND=CL:361380 Change-Id: I50a9ade2e90237b0a7c277bffd7b540132415f13 Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/361370 Reviewed-by: Aaron Durbin <adurbin@chromium.org> [modify] https://crrev.com/c859ce04d2df5f21c47a164cabbc9ef6dec61818/src/mainboard/google/jecht/chromeos.fmd
,
Jul 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/depthcharge/+/2e3bfaafca225582b33d892405395889d5390111 commit 2e3bfaafca225582b33d892405395889d5390111 Author: Daisuke Nojiri <dnojiri@chromium.org> Date: Mon Jul 18 18:04:57 2016 jecht: Increase RO coreboot size on flash Bitmap images has been moved to CBFS from GBB. This patch adjusts the flash size accordingly for jecht. BUG=chromium:622501, chromium:628494 BRANCH=none TEST=emerge-jecht chromeos-bootimage CQ-DEPEND=CL:361370 Change-Id: I1ef5c2487652a548cae2acb6a94efc553d1e09bf Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/361380 Reviewed-by: Aaron Durbin <adurbin@chromium.org> [modify] https://crrev.com/2e3bfaafca225582b33d892405395889d5390111/board/jecht/fmap.dts
,
Jul 25 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/overlays/overlay-aplrvp-private/+/d2f98aa6680de0322bd2a84ba4bd40ac1ca4a4d4 commit d2f98aa6680de0322bd2a84ba4bd40ac1ca4a4d4 Author: Daisuke Nojiri <dnojiri@chromium.org> Date: Mon Jul 25 17:05:41 2016
,
Jul 25 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/overlays/overlay-reef-private/+/d4c62218dd1f6953f8d42e447e9aa50196dcf9a1 commit d4c62218dd1f6953f8d42e447e9aa50196dcf9a1 Author: Daisuke Nojiri <dnojiri@chromium.org> Date: Mon Jul 25 17:06:20 2016
,
Jul 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/285e531d68319ade2dbee0554cf831ae122eb45a commit 285e531d68319ade2dbee0554cf831ae122eb45a Author: Daisuke Nojiri <dnojiri@chromium.org> Date: Mon Jul 25 17:06:51 2016 Remove bitmap_in_cbfs This switch is on by default and cannot be turned off, thus it has no effect. BUG=chromium:622501 BRANCH=none TEST=none Change-Id: Ie9f8b603a724358946d6265014a90830fdd90837 Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/362977 Reviewed-by: Aaron Durbin <adurbin@chromium.org> [modify] https://crrev.com/285e531d68319ade2dbee0554cf831ae122eb45a/sys-apps/coreboot-utils/coreboot-utils-9999.ebuild
,
Jul 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/b896e3a3344e6a2eaccb515c97a419a66143011c commit b896e3a3344e6a2eaccb515c97a419a66143011c Author: Daisuke Nojiri <dnojiri@chromium.org> Date: Mon Jul 25 17:02:24 2016 Remove bitmap_in_cbfs This switch is on by default and cannot be turned off, thus it has no effect. BUG=chromium:622501 BRANCH=none TEST=none Change-Id: Ida50458504b501dbd7f630fd65111e920dc5a427 Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/362645 Reviewed-by: Aaron Durbin <adurbin@chromium.org> [modify] https://crrev.com/b896e3a3344e6a2eaccb515c97a419a66143011c/chipset-mt8173/make.conf [modify] https://crrev.com/b896e3a3344e6a2eaccb515c97a419a66143011c/chipset-skl/make.conf [modify] https://crrev.com/b896e3a3344e6a2eaccb515c97a419a66143011c/baseboard-gru/make.conf [modify] https://crrev.com/b896e3a3344e6a2eaccb515c97a419a66143011c/overlay-veyron/make.conf
,
Aug 24 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/bmpblk/+/04abee74418d13fa94a687664f8ce55ad02ec647 commit 04abee74418d13fa94a687664f8ce55ad02ec647 Author: Daisuke Nojiri <dnojiri@chromium.org> Date: Thu Aug 18 23:28:43 2016 Depcreate bmpblk.bin bmpblk.bin used to be used for vboot to render screens using bitmap and layout data stored in GBB. It's no longer used after we switched to bitmaps in CBFS. This removes code generating bmpblk.bin. BUG=chromium:622501,chrome-os-partner:54619 BRANCH=none TEST=Vboot screens are properly rendered on Jerry && emerge-samus chromeos-bootimage Change-Id: Ic97d49ef0e6d1bd751922f6bfdb1571cf3171487 Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/373123 Reviewed-by: Hung-Te Lin <hungte@chromium.org> [modify] https://crrev.com/04abee74418d13fa94a687664f8ce55ad02ec647/images/build_images.py [modify] https://crrev.com/04abee74418d13fa94a687664f8ce55ad02ec647/images/make_default_yaml.py
,
Mar 31 2017
Dai, does anything else need to happen here?
,
Apr 1 2017
There is some dead code in vboot_reference. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by dnojiri@chromium.org
, Jun 22 2016