New issue
Advanced search Search tips

Issue 622499 link

Starred by 3 users

Issue metadata

Status: Started
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

USB Type-C Infrastructure development

Project Member Reported by groeck@chromium.org, Jun 22 2016

Issue description

Add support for USB Type-C infrastructure

Cherry-pick upstream Type-C infrastructure, implement necessary API functions, merge related upstream patches as needed, enhance existing drivers and add new drivers as necessary.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 23 2016

Labels: merge-merged-chromeos-4.4
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/6e599f2b53b54a3a0dfe61c21ddaeb09f06a0fe0

commit 6e599f2b53b54a3a0dfe61c21ddaeb09f06a0fe0
Author: Kees Cook <keescook@chromium.org>
Date: Thu Mar 17 21:22:50 2016

UPSTREAM: lib: move strtobool() to kstrtobool()

Create the kstrtobool_from_user() helper and move strtobool() logic into
the new kstrtobool() (matching all the other kstrto* functions).
Provides an inline wrapper for existing strtobool() callers.

BUG=chromium:622499
TEST=Build image with kstrtobool() enabled

Signed-off-by: Kees Cook <keescook@chromium.org>
Cc: Joe Perches <joe@perches.com>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Daniel Borkmann <daniel@iogearbox.net>
Cc: Amitkumar Karwar <akarwar@marvell.com>
Cc: Nishant Sarmukadam <nishants@marvell.com>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: Steve French <sfrench@samba.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
(cherry picked from commit ef951599074ba4fad2d0efa0a977129b41e6d203)
Signed-off-by: Guenter Roeck <groeck@chromium.org>

Change-Id: I6b19a1eef46de40698a2c36f5fad67a84dfa13cf
Reviewed-on: https://chromium-review.googlesource.com/355211
Commit-Ready: Guenter Roeck <groeck@chromium.org>
Tested-by: Guenter Roeck <groeck@chromium.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>

[modify] https://crrev.com/6e599f2b53b54a3a0dfe61c21ddaeb09f06a0fe0/include/linux/kernel.h
[modify] https://crrev.com/6e599f2b53b54a3a0dfe61c21ddaeb09f06a0fe0/lib/string.c
[modify] https://crrev.com/6e599f2b53b54a3a0dfe61c21ddaeb09f06a0fe0/lib/kstrtox.c
[modify] https://crrev.com/6e599f2b53b54a3a0dfe61c21ddaeb09f06a0fe0/include/linux/string.h

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 23 2016

Labels: merge-merged-chromeos-4.4
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/8b7f8e2916ef68c98a53b0b374754c963a674b1f

commit 8b7f8e2916ef68c98a53b0b374754c963a674b1f
Author: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: Thu Mar 17 21:22:14 2016

UPSTREAM: lib/string: introduce match_string() helper

Occasionally we have to search for an occurrence of a string in an array
of strings.  Make a simple helper for that purpose.

BUG=chromium:622499
TEST=Build image with match_string() enabled

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: David Airlie <airlied@linux.ie>
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Cc: Sebastian Reichel <sre@kernel.org>
Cc: Tejun Heo <tj@kernel.org>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
(cherry picked from commit 56b060814e2d87d6646a85a2f4609c73587399ca)
Signed-off-by: Guenter Roeck <groeck@chromium.org>

Change-Id: I6075bb868e3578caa33561c85f4be57f4ea94cc2
Reviewed-on: https://chromium-review.googlesource.com/355210
Commit-Ready: Guenter Roeck <groeck@chromium.org>
Tested-by: Guenter Roeck <groeck@chromium.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>

[modify] https://crrev.com/8b7f8e2916ef68c98a53b0b374754c963a674b1f/include/linux/string.h
[modify] https://crrev.com/8b7f8e2916ef68c98a53b0b374754c963a674b1f/lib/string.c

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/04eb78f7b5fd97a602ad3d0583847f57ca7b9cee

commit 04eb78f7b5fd97a602ad3d0583847f57ca7b9cee
Author: Kees Cook <keescook@chromium.org>
Date: Thu Mar 17 21:22:57 2016

UPSTREAM: lib: add "on"/"off" support to kstrtobool

Add support for "on" and "off" when converting to boolean.

BUG=chromium:622499
TEST=Build image with kstrtobool() enabled

Signed-off-by: Kees Cook <keescook@chromium.org>
Cc: Amitkumar Karwar <akarwar@marvell.com>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Daniel Borkmann <daniel@iogearbox.net>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Joe Perches <joe@perches.com>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Nishant Sarmukadam <nishants@marvell.com>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Steve French <sfrench@samba.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
(cherry picked from commit a81a5a17d44b26521fb1199f8ccf27f4af337a67)
Signed-off-by: Guenter Roeck <groeck@chromium.org>

Change-Id: Ia57db77cc62c20519258e30eda6302331f9881ff
Reviewed-on: https://chromium-review.googlesource.com/355212
Commit-Ready: Guenter Roeck <groeck@chromium.org>
Tested-by: Guenter Roeck <groeck@chromium.org>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>

[modify] https://crrev.com/04eb78f7b5fd97a602ad3d0583847f57ca7b9cee/lib/kstrtox.c

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/c1b70902560a77a11c66b552664be4af81ea12f0

commit c1b70902560a77a11c66b552664be4af81ea12f0
Author: Kees Cook <keescook@chromium.org>
Date: Thu Mar 17 21:22:54 2016

UPSTREAM: lib: update single-char callers of strtobool()

Some callers of strtobool() were passing a pointer to unterminated
strings.  In preparation of adding multi-character processing to
kstrtobool(), update the callers to not pass single-character pointers,
and switch to using the new kstrtobool_from_user() helper where
possible.

BUG=chromium:622499
TEST=Build image with kstrtobool() enabled

Signed-off-by: Kees Cook <keescook@chromium.org>
Cc: Amitkumar Karwar <akarwar@marvell.com>
Cc: Nishant Sarmukadam <nishants@marvell.com>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: Steve French <sfrench@samba.org>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Daniel Borkmann <daniel@iogearbox.net>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Joe Perches <joe@perches.com>
Cc: Kees Cook <keescook@chromium.org>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
(cherry picked from commit 1404297ebf76fd91a41de215fc8c94c2619e5fdb)
Signed-off-by: Guenter Roeck <groeck@chromium.org>

Change-Id: I8f54c899cd0a09c852fba0f3a36050dc18f9814f
Reviewed-on: https://chromium-review.googlesource.com/355261
Commit-Ready: Guenter Roeck <groeck@chromium.org>
Tested-by: Guenter Roeck <groeck@chromium.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>

[modify] https://crrev.com/c1b70902560a77a11c66b552664be4af81ea12f0/fs/cifs/cifs_debug.c
[modify] https://crrev.com/c1b70902560a77a11c66b552664be4af81ea12f0/fs/cifs/cifsglob.h
[modify] https://crrev.com/c1b70902560a77a11c66b552664be4af81ea12f0/fs/cifs/cifs_debug.h
[modify] https://crrev.com/c1b70902560a77a11c66b552664be4af81ea12f0/drivers/net/wireless/marvell/mwifiex/debugfs.c
[modify] https://crrev.com/c1b70902560a77a11c66b552664be4af81ea12f0/fs/cifs/cifsfs.c

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/155fca2a23dd7d8b10fc78d2a2ba3e80ee0ab637

commit 155fca2a23dd7d8b10fc78d2a2ba3e80ee0ab637
Author: Guenter Roeck <groeck@chromium.org>
Date: Wed Jun 15 21:13:01 2016

CHROMIUM: extcon: cros_ec: Drop else after return

As checkpatch rightfully notices, else after return is unnecessary.

BUG=chromium:622499
TEST=Build gru image and verify that extcon-cros_ec still works

Change-Id: Icdec5b9441a1e72bef612e958fa448c97fb7b7a9
Signed-off-by: Guenter Roeck <groeck@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/355541
Reviewed-by: Douglas Anderson <dianders@chromium.org>

[modify] https://crrev.com/155fca2a23dd7d8b10fc78d2a2ba3e80ee0ab637/drivers/extcon/extcon-cros_ec.c

Project Member

Comment 6 by bugdroid1@chromium.org, Jul 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/8c77b708e84096107cb784068dbcc5282d557ce1

commit 8c77b708e84096107cb784068dbcc5282d557ce1
Author: Guenter Roeck <groeck@chromium.org>
Date: Wed Jun 15 16:07:06 2016

CHROMIUM: extcon: cros_ec: Return error from extcon_cros_ec_detect_cable()

Return error value from extcon_cros_ec_detect_cable(), and abort the probe
function if initial cable state detection fails.

Also return an error from the probe function if registering the event
notifier fails. This should never happen, but if it does, the driver
would be quite useless, so it is better to fail in that case.

BUG=chromium:622499
TEST=Build gru image and verify that extcon-cros_ec still works

Change-Id: Ied0b52a30db8869527b9edc820c974a0c7560ce9
Signed-off-by: Guenter Roeck <groeck@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/355540
Reviewed-by: Douglas Anderson <dianders@chromium.org>

[modify] https://crrev.com/8c77b708e84096107cb784068dbcc5282d557ce1/drivers/extcon/extcon-cros_ec.c

Project Member

Comment 7 by bugdroid1@chromium.org, Jul 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/0cfb964963488e74e65dcca1b1e69653522133bf

commit 0cfb964963488e74e65dcca1b1e69653522133bf
Author: Guenter Roeck <groeck@chromium.org>
Date: Fri Jul 01 19:58:17 2016

CHROMIUM: extcon: cros_ec: Initialize wakelock before registering notifier

After registering the event notifier, it is possible that it is executed
and calls extcon_cros_ec_detect_cable() before the wakelock is initialized.
Initialize the wakelock first to ensure that this can not happen.

BUG=chromium:622499
TEST=Build gru image and verify that extcon-cros_ec still works

Change-Id: I788b28aaa7bed817fd2f6dc2f36d4ca66d082bda
Signed-off-by: Guenter Roeck <groeck@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/358353
Reviewed-by: Douglas Anderson <dianders@chromium.org>

[modify] https://crrev.com/0cfb964963488e74e65dcca1b1e69653522133bf/drivers/extcon/extcon-cros_ec.c

Project Member

Comment 8 by bugdroid1@chromium.org, Jul 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/03640947076774c098934f97287edbe800c29930

commit 03640947076774c098934f97287edbe800c29930
Author: Guenter Roeck <groeck@chromium.org>
Date: Wed Jun 15 16:02:31 2016

CHROMIUM: extcon: cros_ec: Return value directly if possible

cros_ec_usb_get_power_type(), cros_ec_usb_get_role(), and
cros_ec_pd_get_num_ports() all return a byte sized value on success.

Combine error return and function return into a single return value
and drop the pointer to the return value where possible. This simplifies
the code and reduces its size.

BUG=chromium:622499
TEST=Build gru image and verify that extcon-cros_ec still works

Change-Id: Ie26f5c6bb799e3848e6311963d98dd1577abb3a5
Signed-off-by: Guenter Roeck <groeck@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/355539
Reviewed-by: Douglas Anderson <dianders@chromium.org>

[modify] https://crrev.com/03640947076774c098934f97287edbe800c29930/drivers/extcon/extcon-cros_ec.c

Project Member

Comment 9 by bugdroid1@chromium.org, Jul 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/6dd17c57bbfb58b10968509b0438bce26a78ba01

commit 6dd17c57bbfb58b10968509b0438bce26a78ba01
Author: Guenter Roeck <groeck@chromium.org>
Date: Wed Jun 15 15:15:38 2016

CHROMIUM: extcon: cros_ec: Remove extra break statements

break after return statements are unnecessary and may cause gcc
and static code checkers to complain.

BUG=chromium:622499
TEST=Build gru image and verify that extcon-cros_ec still works

Change-Id: I59a7847bab637d71dde6b507a48ac6742847c36b
Signed-off-by: Guenter Roeck <groeck@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/355538
Reviewed-by: Douglas Anderson <dianders@chromium.org>

[modify] https://crrev.com/6dd17c57bbfb58b10968509b0438bce26a78ba01/drivers/extcon/extcon-cros_ec.c

Project Member

Comment 10 by bugdroid1@chromium.org, Jul 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/88ec1d26b4b2e9b182fffbe4a155c747329f516b

commit 88ec1d26b4b2e9b182fffbe4a155c747329f516b
Author: Guenter Roeck <groeck@chromium.org>
Date: Tue Jun 14 18:31:19 2016

CHROMIUM: extcon: cros_ec: Support multiple ports

Get the port ID from the platform ID or from devicetree data,
and use it to instantiate multiple ports.

BUG=chromium:622499,  chromium:491368 
TEST=Build gru image and verify that multiple ports work as expected

Change-Id: Iba9267cd1f3d1e1f0a2734efa81cace0466e26f7
Signed-off-by: Guenter Roeck <groeck@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/355537
Reviewed-by: Douglas Anderson <dianders@chromium.org>

[modify] https://crrev.com/88ec1d26b4b2e9b182fffbe4a155c747329f516b/drivers/extcon/extcon-cros_ec.c
[modify] https://crrev.com/88ec1d26b4b2e9b182fffbe4a155c747329f516b/Documentation/devicetree/bindings/extcon/extcon-cros-ec.txt

Project Member

Comment 11 by bugdroid1@chromium.org, Jul 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/b722dd4c0b1222abcc3785e8a59ffbe20e5ae436

commit b722dd4c0b1222abcc3785e8a59ffbe20e5ae436
Author: Guenter Roeck <groeck@chromium.org>
Date: Tue Jun 14 18:24:21 2016

CHROMIUM: extcon: cros_ec: Improve cros_ec_pd_command

Pass info as parameter to cros_ec_pd_command() and its calling functions.
Use void * for parameter pointers and drop typecasts in calling code.

BUG=chromium:622499,  chromium:491368 
TEST=Build gru image and verify that extcon-cros_ec still works

Change-Id: I1b631d710d7a38954f7fec89263656e64bdf56d2
Signed-off-by: Guenter Roeck <groeck@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/355536
Reviewed-by: Douglas Anderson <dianders@chromium.org>

[modify] https://crrev.com/b722dd4c0b1222abcc3785e8a59ffbe20e5ae436/drivers/extcon/extcon-cros_ec.c

Sign in to add a comment