kSBXProfilePureComputation is deprecated with a 10.8 deployment target |
|||
Issue descriptionhttps://codereview.chromium.org/1855303003/ cunningly moved sandbox_init() behind a wrapper, since Apple deprecated it with a 10.7 deployment target. (Now that I look at it, chrome/utility/safe_browsing/mac/crdmg.cc doesn't use that wrapper yet, but that's not what this bug here is about.) However, those meddling Apple engineers now also deprecated kSBXProfilePureComputation when using a 10.8 deployment target, so ipc_send_fds_test.cc gets another deprecation warning for that. Should the wrapper have a symbol for that too? Or maybe the test doesn't need that profile?
,
Jun 22 2016
Yeah, I think adding sandbox::Seatbelt::PROFILE_PURE_COMPUTATION as a |static const char*| would make sense.
,
Jun 23 2016
Greg: Can you take this? Should be a small change.
,
Jun 23 2016
Happy to help.
,
Sep 20 2016
kerrnel: Ping?
,
Sep 20 2016
Thanks for the ping, this is now on my TODO list for this week.
,
Sep 23 2016
Since I promised to do it this week, I have a CL I'm getting ready for review.
,
Sep 24 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/df7ac746097f96e4b6150c017f1e0f7f722926ca commit df7ac746097f96e4b6150c017f1e0f7f722926ca Author: kerrnel <kerrnel@chromium.org> Date: Sat Sep 24 00:39:26 2016 Suppress sandbox deprecation warnings by using the Seatbelt wrapper. OS X deprecated all of the Sandbox API and never provided a replacement. To hide the deprecation suppressions in the code, we use a wrapper class. BUG= chromium:622489 NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2369553002 Cr-Commit-Position: refs/heads/master@{#420799} [modify] https://crrev.com/df7ac746097f96e4b6150c017f1e0f7f722926ca/chrome/utility/safe_browsing/DEPS [modify] https://crrev.com/df7ac746097f96e4b6150c017f1e0f7f722926ca/chrome/utility/safe_browsing/mac/BUILD.gn [modify] https://crrev.com/df7ac746097f96e4b6150c017f1e0f7f722926ca/chrome/utility/safe_browsing/mac/crdmg.cc [modify] https://crrev.com/df7ac746097f96e4b6150c017f1e0f7f722926ca/ipc/ipc_send_fds_test.cc [modify] https://crrev.com/df7ac746097f96e4b6150c017f1e0f7f722926ca/sandbox/mac/seatbelt.cc [modify] https://crrev.com/df7ac746097f96e4b6150c017f1e0f7f722926ca/sandbox/mac/seatbelt.h
,
Sep 26 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by thakis@chromium.org
, Jun 22 2016Oh, the warning: ../../ipc/ipc_send_fds_test.cc:196:39: error: 'kSBXProfilePureComputation' is deprecated: first deprecated in OS X 10.8 [-Werror,-Wdeprecated-declarations] int error = sandbox::Seatbelt::Init(kSBXProfilePureComputation, SANDBOX_NAMED, ^ /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk/usr/include/sandbox.h:97:19: note: 'kSBXProfilePureComputation' has been explicitly marked deprecated here extern const char kSBXProfilePureComputation[]; ^