See ScreenPinningController.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ea37af717f1569dd93282e09b6fb49ff22b771f8 commit ea37af717f1569dd93282e09b6fb49ff22b771f8 Author: sky <sky@chromium.org> Date: Tue Mar 07 22:59:41 2017 Last sets of tests that can move to common_unittests This way they run in both mash_unittests and ash_unittests. Interesting things of note: . Had to remove DCHECKs for GetRootWindowForDisplayId() as some tests call with invalid. . Had to rename class in mus named WindowManagerTest as it conflicts with test with same name in ash. BUG= 622486 , 631103 , 637853 , 648733 ,695556, 696028 ,698091, 698129 , 698878 , 698887 ,698888,698892,698894, 698895 , 698914 ,699172,699175, 693114 TEST=test changes R=msw@chromium.org Review-Url: https://codereview.chromium.org/2739703003 Cr-Commit-Position: refs/heads/master@{#455272} [modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/BUILD.gn [modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/mus/bridge/wm_shell_mus.cc [modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/mus/window_manager_unittest.cc [modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/test/ash_test_base.cc [modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/wm/overview/window_selector_unittest.cc [modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/wm/panels/panel_layout_manager_unittest.cc [modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/wm/panels/panel_window_resizer_unittest.cc [modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/wm/system_modal_container_layout_manager_unittest.cc [modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/wm/window_cycle_controller_unittest.cc [modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/wm/window_manager_unittest.cc [modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/wm/window_modality_controller_unittest.cc [modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/wm/window_state_unittest.cc [modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/wm/window_util_unittest.cc [modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/wm/workspace/workspace_event_handler_unittest.cc [modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/wm/workspace/workspace_window_resizer_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1385715e4bbb9aa74264578e5dba49890c49c12d commit 1385715e4bbb9aa74264578e5dba49890c49c12d Author: sky <sky@chromium.org> Date: Wed Mar 29 15:46:04 2017 Enables ScreenPinningController for mash/mus And removes unnecessary code in WmShell/WmWindow. BUG= 622486 TEST=covered by tests R=msw@chromium.org Review-Url: https://codereview.chromium.org/2780943002 Cr-Commit-Position: refs/heads/master@{#460399} [modify] https://crrev.com/1385715e4bbb9aa74264578e5dba49890c49c12d/ash/BUILD.gn [modify] https://crrev.com/1385715e4bbb9aa74264578e5dba49890c49c12d/ash/aura/wm_shell_aura.cc [modify] https://crrev.com/1385715e4bbb9aa74264578e5dba49890c49c12d/ash/aura/wm_shell_aura.h [modify] https://crrev.com/1385715e4bbb9aa74264578e5dba49890c49c12d/ash/common/accelerators/accelerator_controller.cc [modify] https://crrev.com/1385715e4bbb9aa74264578e5dba49890c49c12d/ash/common/shelf/shelf_layout_manager.cc [modify] https://crrev.com/1385715e4bbb9aa74264578e5dba49890c49c12d/ash/common/wm/default_state.cc [modify] https://crrev.com/1385715e4bbb9aa74264578e5dba49890c49c12d/ash/common/wm/maximize_mode/maximize_mode_window_state.cc [modify] https://crrev.com/1385715e4bbb9aa74264578e5dba49890c49c12d/ash/common/wm/overview/window_selector_controller.cc [modify] https://crrev.com/1385715e4bbb9aa74264578e5dba49890c49c12d/ash/common/wm/window_cycle_controller.cc [modify] https://crrev.com/1385715e4bbb9aa74264578e5dba49890c49c12d/ash/common/wm/workspace/workspace_layout_manager.cc [modify] https://crrev.com/1385715e4bbb9aa74264578e5dba49890c49c12d/ash/common/wm/workspace/workspace_layout_manager_unittest.cc [modify] https://crrev.com/1385715e4bbb9aa74264578e5dba49890c49c12d/ash/common/wm_shell.h [modify] https://crrev.com/1385715e4bbb9aa74264578e5dba49890c49c12d/ash/common/wm_window.cc [modify] https://crrev.com/1385715e4bbb9aa74264578e5dba49890c49c12d/ash/common/wm_window.h [modify] https://crrev.com/1385715e4bbb9aa74264578e5dba49890c49c12d/ash/mus/bridge/wm_shell_mus.cc [modify] https://crrev.com/1385715e4bbb9aa74264578e5dba49890c49c12d/ash/mus/bridge/wm_shell_mus.h [modify] https://crrev.com/1385715e4bbb9aa74264578e5dba49890c49c12d/ash/shell.cc [modify] https://crrev.com/1385715e4bbb9aa74264578e5dba49890c49c12d/ash/wm/screen_pinning_controller.h [modify] https://crrev.com/1385715e4bbb9aa74264578e5dba49890c49c12d/ash/wm/screen_pinning_controller_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a4e55ccbf27b3b2b8b8ddcb52bdc42e1372e8e28 commit a4e55ccbf27b3b2b8b8ddcb52bdc42e1372e8e28 Author: sky <sky@chromium.org> Date: Wed Mar 29 18:37:10 2017 Enables WorkspaceLayoutManagerSoloTest.PinnedSuspendsAlwaysOnTop for mash Now that pinning has been wired up for mash this test can actually be run in mash. BUG= 622486 TEST=test only change R=msw@chromium.org Review-Url: https://codereview.chromium.org/2778373004 Cr-Commit-Position: refs/heads/master@{#460467} [modify] https://crrev.com/a4e55ccbf27b3b2b8b8ddcb52bdc42e1372e8e28/ash/common/wm/workspace/workspace_layout_manager_unittest.cc
Issue 705665 has been merged into this issue.
Comment 1 by dtapu...@chromium.org
, Sep 2 2016