New issue
Advanced search Search tips

Issue 622486 link

Starred by 1 user

Issue metadata

Status: Archived
Owner: ----
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Mash needs to support pinned windows

Project Member Reported by sky@chromium.org, Jun 22 2016

Issue description

See ScreenPinningController.
 
Components: MUS
Components: Internals>MUS
Labels: Proj-Mustash
Labels: Proj-Mustash-Mash-WM
Status: Available (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea37af717f1569dd93282e09b6fb49ff22b771f8

commit ea37af717f1569dd93282e09b6fb49ff22b771f8
Author: sky <sky@chromium.org>
Date: Tue Mar 07 22:59:41 2017

Last sets of tests that can move to common_unittests

This way they run in both mash_unittests and ash_unittests.
Interesting things of note:
. Had to remove DCHECKs for GetRootWindowForDisplayId() as some tests
  call with invalid.
. Had to rename class in mus named WindowManagerTest as it conflicts
  with test with same name in ash.

BUG= 622486 , 631103 , 637853 , 648733 ,695556, 696028 ,698091, 698129 , 698878 , 698887 ,698888,698892,698894, 698895 , 698914 ,699172,699175, 693114 
TEST=test changes
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2739703003
Cr-Commit-Position: refs/heads/master@{#455272}

[modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/BUILD.gn
[modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/mus/bridge/wm_shell_mus.cc
[modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/mus/window_manager_unittest.cc
[modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/test/ash_test_base.cc
[modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/wm/panels/panel_layout_manager_unittest.cc
[modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/wm/panels/panel_window_resizer_unittest.cc
[modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/wm/system_modal_container_layout_manager_unittest.cc
[modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/wm/window_cycle_controller_unittest.cc
[modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/wm/window_manager_unittest.cc
[modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/wm/window_modality_controller_unittest.cc
[modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/wm/window_state_unittest.cc
[modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/wm/window_util_unittest.cc
[modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/wm/workspace/workspace_event_handler_unittest.cc
[modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/wm/workspace/workspace_window_resizer_unittest.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Mar 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1385715e4bbb9aa74264578e5dba49890c49c12d

commit 1385715e4bbb9aa74264578e5dba49890c49c12d
Author: sky <sky@chromium.org>
Date: Wed Mar 29 15:46:04 2017

Enables ScreenPinningController for mash/mus

And removes unnecessary code in WmShell/WmWindow.

BUG= 622486 
TEST=covered by tests
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2780943002
Cr-Commit-Position: refs/heads/master@{#460399}

[modify] https://crrev.com/1385715e4bbb9aa74264578e5dba49890c49c12d/ash/BUILD.gn
[modify] https://crrev.com/1385715e4bbb9aa74264578e5dba49890c49c12d/ash/aura/wm_shell_aura.cc
[modify] https://crrev.com/1385715e4bbb9aa74264578e5dba49890c49c12d/ash/aura/wm_shell_aura.h
[modify] https://crrev.com/1385715e4bbb9aa74264578e5dba49890c49c12d/ash/common/accelerators/accelerator_controller.cc
[modify] https://crrev.com/1385715e4bbb9aa74264578e5dba49890c49c12d/ash/common/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/1385715e4bbb9aa74264578e5dba49890c49c12d/ash/common/wm/default_state.cc
[modify] https://crrev.com/1385715e4bbb9aa74264578e5dba49890c49c12d/ash/common/wm/maximize_mode/maximize_mode_window_state.cc
[modify] https://crrev.com/1385715e4bbb9aa74264578e5dba49890c49c12d/ash/common/wm/overview/window_selector_controller.cc
[modify] https://crrev.com/1385715e4bbb9aa74264578e5dba49890c49c12d/ash/common/wm/window_cycle_controller.cc
[modify] https://crrev.com/1385715e4bbb9aa74264578e5dba49890c49c12d/ash/common/wm/workspace/workspace_layout_manager.cc
[modify] https://crrev.com/1385715e4bbb9aa74264578e5dba49890c49c12d/ash/common/wm/workspace/workspace_layout_manager_unittest.cc
[modify] https://crrev.com/1385715e4bbb9aa74264578e5dba49890c49c12d/ash/common/wm_shell.h
[modify] https://crrev.com/1385715e4bbb9aa74264578e5dba49890c49c12d/ash/common/wm_window.cc
[modify] https://crrev.com/1385715e4bbb9aa74264578e5dba49890c49c12d/ash/common/wm_window.h
[modify] https://crrev.com/1385715e4bbb9aa74264578e5dba49890c49c12d/ash/mus/bridge/wm_shell_mus.cc
[modify] https://crrev.com/1385715e4bbb9aa74264578e5dba49890c49c12d/ash/mus/bridge/wm_shell_mus.h
[modify] https://crrev.com/1385715e4bbb9aa74264578e5dba49890c49c12d/ash/shell.cc
[modify] https://crrev.com/1385715e4bbb9aa74264578e5dba49890c49c12d/ash/wm/screen_pinning_controller.h
[modify] https://crrev.com/1385715e4bbb9aa74264578e5dba49890c49c12d/ash/wm/screen_pinning_controller_unittest.cc

Comment 6 by sky@chromium.org, Mar 29 2017

Status: Fixed (was: Available)
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4e55ccbf27b3b2b8b8ddcb52bdc42e1372e8e28

commit a4e55ccbf27b3b2b8b8ddcb52bdc42e1372e8e28
Author: sky <sky@chromium.org>
Date: Wed Mar 29 18:37:10 2017

Enables WorkspaceLayoutManagerSoloTest.PinnedSuspendsAlwaysOnTop for mash

Now that pinning has been wired up for mash this test can actually be
run in mash.

BUG= 622486 
TEST=test only change
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2778373004
Cr-Commit-Position: refs/heads/master@{#460467}

[modify] https://crrev.com/a4e55ccbf27b3b2b8b8ddcb52bdc42e1372e8e28/ash/common/wm/workspace/workspace_layout_manager_unittest.cc

Comment 8 by sky@chromium.org, Apr 4 2017

Cc: penghuang@chromium.org
 Issue 705665  has been merged into this issue.

Comment 9 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 11 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
Components: -Internals>MUS Internals>Services>WindowService
Components: -MUS

Sign in to add a comment