mash: Implement display related classes in ShellPort for mus |
|||||||||||||
Issue descriptionmash: Convert DisplayManager to use WmWindow types This is a tracking bug for making the code in //ash/display use ash::wm::WmWindow instead of aura::Window directly. For mash, we're starting to collapse the window manager (desktop_wm) and system UI (ash_sysui) into a single process/service. The window manager bits manipulate mus windows, via a wrapper class ash::wm::WmWindow. In order to make the display manager work in this environment it will need to avoid direct access to aura::Window and use the wrappers instead. As things are converted they will move into //ash/common/display Portions without ash dependencies my move to //ui/display See related Issue 619636 (this bug may actually block some of that work).
,
Jun 29 2016
+kylechar as he has been looking at this.
,
Jul 18 2016
,
Aug 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7626933226e5e892cbaf50590f0ca1367cf0d0e0 commit 7626933226e5e892cbaf50590f0ca1367cf0d0e0 Author: msw <msw@chromium.org> Date: Sat Aug 06 02:25:48 2016 mash: Migrate ShelfLayoutManager ScreenUtil usage to ash common types. Add WmShell::IsInUnifiedMode and GetFirstDisplay helpers. Migrate wm::GetShelfDisplayBoundsForWindow. Update ShelfLayoutManager ScreenUtil usage to ash/common. BUG= 615155 , 622480 TEST=Automated; no [unified] shelf layout changes. R=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2215223004 Cr-Commit-Position: refs/heads/master@{#410253} [modify] https://crrev.com/7626933226e5e892cbaf50590f0ca1367cf0d0e0/ash/app_list/app_list_presenter_delegate.cc [modify] https://crrev.com/7626933226e5e892cbaf50590f0ca1367cf0d0e0/ash/aura/wm_shell_aura.cc [modify] https://crrev.com/7626933226e5e892cbaf50590f0ca1367cf0d0e0/ash/aura/wm_shell_aura.h [modify] https://crrev.com/7626933226e5e892cbaf50590f0ca1367cf0d0e0/ash/common/wm/wm_screen_util.cc [modify] https://crrev.com/7626933226e5e892cbaf50590f0ca1367cf0d0e0/ash/common/wm/wm_screen_util.h [modify] https://crrev.com/7626933226e5e892cbaf50590f0ca1367cf0d0e0/ash/common/wm_shell.h [modify] https://crrev.com/7626933226e5e892cbaf50590f0ca1367cf0d0e0/ash/display/window_tree_host_manager_unittest.cc [modify] https://crrev.com/7626933226e5e892cbaf50590f0ca1367cf0d0e0/ash/mus/bridge/wm_shell_mus.cc [modify] https://crrev.com/7626933226e5e892cbaf50590f0ca1367cf0d0e0/ash/mus/bridge/wm_shell_mus.h [modify] https://crrev.com/7626933226e5e892cbaf50590f0ca1367cf0d0e0/ash/screen_util.cc [modify] https://crrev.com/7626933226e5e892cbaf50590f0ca1367cf0d0e0/ash/screen_util.h [modify] https://crrev.com/7626933226e5e892cbaf50590f0ca1367cf0d0e0/ash/screen_util_unittest.cc [modify] https://crrev.com/7626933226e5e892cbaf50590f0ca1367cf0d0e0/ash/shelf/shelf_layout_manager.cc [modify] https://crrev.com/7626933226e5e892cbaf50590f0ca1367cf0d0e0/ash/system/toast/toast_manager_unittest.cc [modify] https://crrev.com/7626933226e5e892cbaf50590f0ca1367cf0d0e0/ash/wm/lock_window_state.cc
,
Oct 4 2016
,
Mar 2 2017
No longer relevant.
,
Mar 27 2017
I'm changing the title to reflect we still need these functions and we need implementations in WmShellMus. Specifically functions such as GetDisplayInfo, IsActiveDisplayId...
,
Mar 27 2017
Kyle, I'm passing this to you, if you feel that isn't right kick it back to me.
,
Apr 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/729110102e87635cba60ede6f631d68a374d25e8 commit 729110102e87635cba60ede6f631d68a374d25e8 Author: sky <sky@chromium.org> Date: Tue Apr 11 23:19:53 2017 Disables a couple more tests for ash_unittests --mus These are failing on the bot. Will investigate separately. BUG= 705715 , 622480 TEST=this is test change R=msw@chromium.org Review-Url: https://codereview.chromium.org/2814563006 Cr-Commit-Position: refs/heads/master@{#463829} [modify] https://crrev.com/729110102e87635cba60ede6f631d68a374d25e8/testing/buildbot/filters/ash_mus_unittests.filter
,
May 2 2017
,
May 3 2017
,
Jun 5 2017
,
Jun 21 2017
With simplified display management this is indeed no longer relevant.
,
Feb 26 2018
,
Feb 26 2018
,
Aug 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4f7bb1dc11771a4d2ce63f26264377da0bd93a1e commit 4f7bb1dc11771a4d2ce63f26264377da0bd93a1e Author: Mike Wasserman <msw@chromium.org> Date: Tue Aug 21 19:39:06 2018 Cleanup obsolete WallpaperController Mash conditionals. Bug: 613657 , 622480 Change-Id: Ief1471c2f5830a99f9e650d7447b821c155e4a49 Reviewed-on: https://chromium-review.googlesource.com/1183900 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#584882} [modify] https://crrev.com/4f7bb1dc11771a4d2ce63f26264377da0bd93a1e/ash/wallpaper/wallpaper_controller.cc |
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by sky@chromium.org
, Jun 22 2016