remove_build_metadata fails to process mini_installer.exe |
||||
Issue descriptionhttps://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/243586/steps/remove_build_metadata/logs/stdio ini_installer.exe failed: [0622/132230:INFO:application_impl.h(46)] Syzygy Zap Timestamp Version 0.8.19.0 (da2c31c). [0622/132230:INFO:application_impl.h(48)] Copyright (c) Google Inc. All rights reserved. [0622/132230:INFO:zap_timestamp.cc(551)] Analyzing PE file: E:\b\build\slave\win\build\src\out\Release\mini_installer.exe [0622/132230:INFO:zap_timestamp.cc(590)] Found matching PDB file: E:\b\build\slave\win\build\src\out\Release\mini_installer.exe.pdb [0622/132230:ERROR:pe_file_parser.cc(1249)] Failed to add debug directory references. [0622/132230:ERROR:pe_file_parser.cc(381)] Failed to parse data directory debug. [0622/132230:ERROR:zap_timestamp.cc(144)] Failed to parse PE file: E:\b\build\slave\win\build\src\out\Release\mini_installer.exe Doesn't make the build fail, but seems like something we probably want to fix anyhow (?).
,
Jun 22 2016
can the recipes script skip it then? having steps that print warnings by default make people blind to warnings.
,
Jun 22 2016
Sure.
,
Aug 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1d692d1e0170d7b6b1670073b2be2c14edb2a65e commit 1d692d1e0170d7b6b1670073b2be2c14edb2a65e Author: sebmarchand <sebmarchand@chromium.org> Date: Thu Aug 25 20:34:05 2016 Add a blacklist for the files that should be processed by zap_timestamps Right now this is only for mini_installer.exe, which can't be processed by the Syzygy toolchain. R=maruel@chromium.org BUG= 622455 Review-Url: https://codereview.chromium.org/2280513003 Cr-Commit-Position: refs/heads/master@{#414528} [modify] https://crrev.com/1d692d1e0170d7b6b1670073b2be2c14edb2a65e/tools/determinism/remove_build_metadata.py
,
Aug 25 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by sebmarchand@chromium.org
, Jun 22 2016