New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 622448 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Jun 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Candidate window in pepper plugin can be shown at the top left corner.

Project Member Reported by osh...@chromium.org, Jun 22 2016

Issue description

Candidate window in flash can be shown at the top left corner.

looks like this is regressed in https://crrev.com/66ddf2b33cf65c4d16e0dc6e9c39e2c3f1d2bebc

Fix: https://codereview.chromium.org/2089783004
 

Comment 1 by osh...@chromium.org, Jun 22 2016

Cc: nona@chromium.org
Summary: Candidate window in pepper plugin can be shown at the top left corner. (was: Candidate window in flash can be shown at the top left corner.)
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a517f584d88458b14aac79589a515e7d8c58665d

commit a517f584d88458b14aac79589a515e7d8c58665d
Author: oshima <oshima@chromium.org>
Date: Thu Jun 23 00:50:15 2016

Correctly fallback  to caret bounds when composition_head is not provided

BUG= 622448 
TEST=manual

Review-Url: https://codereview.chromium.org/2089783004
Cr-Commit-Position: refs/heads/master@{#401485}

[modify] https://crrev.com/a517f584d88458b14aac79589a515e7d8c58665d/ui/base/ime/input_method_chromeos.cc

Comment 3 by osh...@chromium.org, Jun 23 2016

Labels: Merge-Request-52
can we merge this too? it's chromeos only and very low risk.
Labels: Merge-Approved-52
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 23 2016

Labels: -merge-approved-52 merge-merged-2743
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ac17c23b18c70166b05f8631974897e65cc53d9

commit 3ac17c23b18c70166b05f8631974897e65cc53d9
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Thu Jun 23 21:05:01 2016

Correctly fallback  to caret bounds when composition_head is not provided

BUG= 622448 
TEST=manual

Review-Url: https://codereview.chromium.org/2089783004
Cr-Commit-Position: refs/heads/master@{#401485}
(cherry picked from commit a517f584d88458b14aac79589a515e7d8c58665d)

Review URL: https://codereview.chromium.org/2091693003 .

Cr-Commit-Position: refs/branch-heads/2743@{#460}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/3ac17c23b18c70166b05f8631974897e65cc53d9/ui/base/ime/input_method_chromeos.cc

Comment 6 by osh...@chromium.org, Jun 23 2016

Status: Fixed (was: Started)

Comment 7 by dimu@google.com, Jun 24 2016

Labels: -Merge-Request-52 Merge-Review-52 Hotlist-Merge-Review
[Automated comment] There appears to be on-going work (i.e. bugroid changes), needs manual review.

Comment 8 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 9 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 10 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 11 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 13 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment