New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 622440 link

Starred by 2 users
Status: Fixed
Owner:
█ lushnikov@chromium.org
Last visit 29 days ago
Closed: Nov 2017
Cc:
pdr@chromium.org
█ mikelawther@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

DevTools: search across files doesn't include main document.

Project Member Reported by pdr@chromium.org, Jun 22 2016 
Version: 53.0.2767.4/dev
OS: year of the linux desktop

What steps will reproduce the problem?
(1) Visit http://www.ostsee-zeitung.de/Vorpommern/Greifswald/Bildergalerien-Greifswald/Happy-Birthday!-Guetzkow-feierte-888.-Geburtstag
(2) Press escape to bring up the drawer, then search for "ad_dart"
(3) Notice there are no search results.

Similarly, going to Sources, right click "top", and select "find in all files"; this will not work either.

What is the expected output?
The search should find the ad_dart present on the page. If you go to the elements view and press ctrl+f and search for "ad_dart", it will be found.

This was originally found by Mike Lawther and I was similarly confused trying to help him out.

Comment 1 by paulir...@chromium.org, Jul 1 2016

Owner: pfeldman@chromium.org
Status: Assigned (was: Untriaged)
Summary: DevTools: search across files doesn't include main document. (was: Search in devtools does find results)
Interesting. It's found in the main document, but that's not part of the search-all-files index.
Screen Shot 2016-07-01 at 3.40.44 PM.png
170 KB View Download

Comment 2 by pfeldman@chromium.org, Jul 6 2016

Owner: lushnikov@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d081f57b93a0bcd10901bcf404222d468d488de2

commit d081f57b93a0bcd10901bcf404222d468d488de2
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Fri Nov 17 08:54:38 2017

DevTools: fix searching in main resources

This patch:
- Introduces a new protocol method Network.searchInResponse.
- Properly defines SDK.NetworkRequest.searchInContent method in
  devtools_frontend
- Starts falling back to searching in request response if resource is
  originating from request
- Migrates sources-search-scope.js to the new style

As a consequence, the sources-search-scope no longer will be flaky, and
searching in main resource will work reliably.

BUG= chromium:521853 , chromium:622440 
R=dgozman, caseq

Change-Id: I92fd582661a6537ebbe1506d8dba97a700a139c3
Reviewed-on: https://chromium-review.googlesource.com/773596
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517346}
[modify] https://crrev.com/d081f57b93a0bcd10901bcf404222d468d488de2/third_party/WebKit/LayoutTests/SlowTests
[modify] https://crrev.com/d081f57b93a0bcd10901bcf404222d468d488de2/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/d081f57b93a0bcd10901bcf404222d468d488de2/third_party/WebKit/LayoutTests/http/tests/devtools/search/sources-search-scope-expected.txt
[delete] https://crrev.com/1948b8ca8a3737fb72c8721af0cce63f6fd2cd7b/third_party/WebKit/LayoutTests/http/tests/devtools/search/sources-search-scope.html
[add] https://crrev.com/d081f57b93a0bcd10901bcf404222d468d488de2/third_party/WebKit/LayoutTests/http/tests/devtools/search/sources-search-scope.js
[add] https://crrev.com/d081f57b93a0bcd10901bcf404222d468d488de2/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/search-in-response-expected.txt
[add] https://crrev.com/d081f57b93a0bcd10901bcf404222d468d488de2/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/search-in-response.js
[modify] https://crrev.com/d081f57b93a0bcd10901bcf404222d468d488de2/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.cpp
[modify] https://crrev.com/d081f57b93a0bcd10901bcf404222d468d488de2/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp
[modify] https://crrev.com/d081f57b93a0bcd10901bcf404222d468d488de2/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.h
[modify] https://crrev.com/d081f57b93a0bcd10901bcf404222d468d488de2/third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp
[modify] https://crrev.com/d081f57b93a0bcd10901bcf404222d468d488de2/third_party/WebKit/Source/core/inspector/browser_protocol.json
[modify] https://crrev.com/d081f57b93a0bcd10901bcf404222d468d488de2/third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js
[modify] https://crrev.com/d081f57b93a0bcd10901bcf404222d468d488de2/third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js
[modify] https://crrev.com/d081f57b93a0bcd10901bcf404222d468d488de2/third_party/WebKit/Source/devtools/front_end/sdk/Resource.js

Comment 4 by lushnikov@chromium.org, Nov 17 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment